From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54349 invoked by alias); 20 Jun 2019 10:04:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 54340 invoked by uid 89); 20 Jun 2019 10:04:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=51876, H*Ad:U*patches X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Jun 2019 10:04:30 +0000 Received: from svr-orw-mbx-06.mgc.mentorg.com ([147.34.90.206]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1hdtvd-000076-E6 from Thomas_Schwinge@mentor.com ; Thu, 20 Jun 2019 03:04:25 -0700 Received: from SVR-ORW-MBX-07.mgc.mentorg.com (147.34.90.207) by SVR-ORW-MBX-06.mgc.mentorg.com (147.34.90.206) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Thu, 20 Jun 2019 03:04:23 -0700 Received: from tftp-cs (147.34.91.1) by SVR-ORW-MBX-07.mgc.mentorg.com (147.34.90.207) with Microsoft SMTP Server id 15.0.1320.4 via Frontend Transport; Thu, 20 Jun 2019 03:04:22 -0700 Received: by tftp-cs (Postfix, from userid 49978) id 904C3C2212; Thu, 20 Jun 2019 03:04:22 -0700 (PDT) From: Thomas Schwinge To: Kugan , Christophe Lyon , Marcus Shawcroft CC: Yufeng Zhang , "gcc-patches@gcc.gnu.org" , "patches@linaro.org" Subject: Re: AARCH64 configure check for gas -mabi support In-Reply-To: References: <529F98A0.8020503@linaro.org> <52A1F8C0.70302@arm.com> <52A5A765.7000106@linaro.org> <52A63CA3.9000304@arm.com> <52A6B2D4.3080105@linaro.org> <52A6FB03.4050500@arm.com> <52A77837.9000108@linaro.org> <52A85A26.3060604@arm.com> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Thu, 20 Jun 2019 10:04:00 -0000 Message-ID: <87ef3ofu90.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-SW-Source: 2019-06/txt/msg01207.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 2226 Hi! I was just building an aarch64 cross-compiler (indeed compiler only: 'make all-gcc'), and then wanted to check something in gimplification ('-S -fdump-tree-gimple'), with '-mabi=3Dilp32', which told me: "cc1: error: assembler does not support '-mabi=3Dilp32'". That's unexpected, as for '-S' GCC isn't even going to invoke the assembler. It's coming from this change: On Wed, 11 Dec 2013 13:57:59 +0100, Christophe Lyon wrote: > Committed on Kugan's behalf as rev 205891. >=20 > On 11 December 2013 13:27, Marcus Shawcroft wr= ote: > > On 10/12/13 20:23, Kugan wrote: > > > >> gcc/ > >> > >> +2013-12-11 Kugan Vivekanandarajah > >> + * configure.ac: Add check for aarch64 assembler -mabi support. > >> + * configure: Regenerate. > >> + * config.in: Regenerate. > >> + * config/aarch64/aarch64-elf.h (ASM_MABI_SPEC): New define. > >> + (ASM_SPEC): Update to substitute -mabi with ASM_MABI_SPEC. > >> + * config/aarch64/aarch64.h (aarch64_override_options): Issue > >> error if > >> + assembler does not support -mabi and option ilp32 is selected. > >> + * doc/install.texi: Added note that building gcc 4.9 and after > >> with pre > >> + 2.24 binutils will not support -mabi=3Dilp32. > >> + > >> > > > > Kugan, Thanks for sorting this out. OK to commit. > > > > /Marcus Specifically: --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -5187,6 +5187,13 @@ aarch64_override_options (void) aarch64_parse_tune (); } =20=20=20=20 +#ifndef HAVE_AS_MABI_OPTION + /* The compiler may have been configured with 2.23.* binutils, which= does + not have support for ILP32. */ + if (TARGET_ILP32) + error ("Assembler does not support -mabi=3Dilp32"); +#endif Why is that necessary? Won't the assembler itself tell the user that it "does not support -mabi=3Dilp32", thus this check can be removed? If not, can a condition simply be added here to only emit this error if we're indeed going to invoke the assembler? (For my own testing, I just locally disabled that, of course.) Gr=C3=BC=C3=9Fe Thomas --=-=-= Content-Type: application/pgp-signature; name="signature.asc" Content-length: 658 -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEU9WEfWKGQazCmycCAKI7+41Q4XkFAl0LWhsACgkQAKI7+41Q 4Xk6IAwAmOB0Gk0Ik9CbSkVs++Nd/H72lXu442jq8k7Xa6pXe5LPCieQ8NmmqXQ+ OhV0DzQbawER32buX9TTHJAWXD4x1GnSoW2zHQU7vlaNnX2GL2eA9kS9V7UkyNcK u2eGxhChULHaFmf2BpsyNXtJUubL2V8y7ajN05uwQrHSAKhlB+QW8/DEc7wyFAMz EnBGZd1FhPY4GG+gDt3HWGLRzmBiN199nX+f00bP44eyog2i6p2dPd/wBCSX0EHm GR6Vrrse9/+A4pRIvLtQ7DdPkqqoCnPTmBdovU9/U4cXHWkWaXwaenyIpQ+moizz 0fjgeaxosTl4dl+0ZHmKhs/yEiHYojQVRUSBFzvZpdUt3l20k0DVPdmJiUdRvT/Q ek578O6ZZdXccJFN10SgMN68NbwYOU6xR2R8a4dKFWLmJCXZDnUQihNXF9CWn5kG RN9cHWIBfU8ex/hjqC2vQzRbXL9It8ZXDNxRhwTpii6VU3l7HLJZfqKaI+1lvPwa jSYJtqWG =kw4t -----END PGP SIGNATURE----- --=-=-=--