From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30345 invoked by alias); 20 Nov 2017 13:00:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30227 invoked by uid 89); 20 Nov 2017 13:00:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:threembb.co.uk X-HELO: mail-wm0-f52.google.com Received: from mail-wm0-f52.google.com (HELO mail-wm0-f52.google.com) (74.125.82.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Nov 2017 13:00:25 +0000 Received: by mail-wm0-f52.google.com with SMTP id b189so18658697wmd.0 for ; Mon, 20 Nov 2017 05:00:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:mail-followup-to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version; bh=iYqbwFUECem1vtEKDBsHli7Jy8XBi9qABlbcZbR+hIU=; b=l8VGhk5UPMEb+lc7pd7rNwcEnob6GD+y14cB6+wDPoolxfBFNy3eZrG6H7PCGah9Fm TOWS364KHaLLl9uTe5cyts/dQPZq4VwNJNkw3Oey9tfMY/3IkFRv0w/QmSgNCyBR0jxk 93XjjB4ikJ3OVCX3T/gp+t/tB7AFrDQa+aSCiu3uWrouAJrCPTxfyElNYq7OWphOrcuA YQniwlgKXij7oHXJk2V6vY39pzujBqCvBRkdi5EGhosrZbQ4h6clPbzqKLJUFcHyEttx dc+gs13do8LGzC0aRIKK+cA8lAxqfAxCgXHPrZQxJznC10IZrzqJbKzw7A2BvGd7uuXh V1rQ== X-Gm-Message-State: AJaThX4L7Bao6HttpkZzA/y3Qyd+VmpU8zp72m8xKAiStNZ/nSClcPe0 UxuP8JOWK4aJ5F+UtLPq7audXNNCkCs= X-Google-Smtp-Source: AGs4zMYO02CyelBNQI5Mbd8xvr/8U5I92+soSJpqWGhCRRJMs/LB6lcuWmtYuQ63CBGHLpP02ERCVw== X-Received: by 10.28.73.193 with SMTP id w184mr10273258wma.3.1511182822036; Mon, 20 Nov 2017 05:00:22 -0800 (PST) Received: from localhost (188.29.164.241.threembb.co.uk. [188.29.164.241]) by smtp.gmail.com with ESMTPSA id o2sm4307977wmo.5.2017.11.20.05.00.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 Nov 2017 05:00:21 -0800 (PST) From: Richard Sandiford To: Jeff Law Mail-Followup-To: Jeff Law ,gcc-patches@gcc.gnu.org, richard.sandiford@linaro.org Cc: gcc-patches@gcc.gnu.org Subject: Re: [014/nnn] poly_int: indirect_refs_may_alias_p References: <871sltvm7r.fsf@linaro.org> <877evlssk3.fsf@linaro.org> <2843c11a-465e-b6cb-d234-e7311beaa5ca@redhat.com> Date: Mon, 20 Nov 2017 13:31:00 -0000 In-Reply-To: <2843c11a-465e-b6cb-d234-e7311beaa5ca@redhat.com> (Jeff Law's message of "Fri, 17 Nov 2017 11:05:13 -0700") Message-ID: <87efotw1el.fsf@linaro.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-11/txt/msg01760.txt.bz2 Jeff Law writes: > On 10/23/2017 11:05 AM, Richard Sandiford wrote: >> This patch makes indirect_refs_may_alias_p use ranges_may_overlap_p >> rather than ranges_overlap_p. Unlike the former, the latter can handle >> negative offsets, so the fix for PR44852 should no longer be necessary. >> It can also handle offset_int, so avoids unchecked truncations to >> HOST_WIDE_INT. >> >> >> 2017-10-23 Richard Sandiford >> Alan Hayward >> David Sherwood >> >> gcc/ >> * tree-ssa-alias.c (indirect_ref_may_alias_decl_p) >> (indirect_refs_may_alias_p): Use ranges_may_overlap_p >> instead of ranges_overlap_p. > OK. > > Note that this highlighted a nit in patch 001 -- namely that there's new > function templates that aren't mentioned in the ChangeLog. Do you mean ranges_may_overlap_p? I can add that and the other new poly-int.h functions to the changelog if you think it's useful, but I thought for new files it was more usual just to do: * foo.h: New file. Thanks, Richard