From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107163 invoked by alias); 26 Jan 2016 10:46:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 107134 invoked by uid 89); 26 Jan 2016 10:46:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=regarded, Non, individually, Put X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Jan 2016 10:46:41 +0000 Received: from svr-orw-fem-03.mgc.mentorg.com ([147.34.97.39]) by relay1.mentorg.com with esmtp id 1aO18v-0006hJ-0t from Thomas_Schwinge@mentor.com ; Tue, 26 Jan 2016 02:46:37 -0800 Received: from tftp-cs (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.3.224.2; Tue, 26 Jan 2016 02:46:36 -0800 Received: by tftp-cs (Postfix, from userid 49978) id CF343C224D; Tue, 26 Jan 2016 02:46:35 -0800 (PST) From: Thomas Schwinge To: Martin Jambor , Jakub Jelinek CC: GCC Patches , Richard Biener , Martin Liska , Michael Matz , Nathan Sidwell Subject: (Non-)offloading diagnostics (was: [hsa 0/10] Merge of HSA branch) In-Reply-To: <20151210175147.GE3534@virgil.suse.cz> References: <20151207111758.GA24234@virgil.suse.cz> <20151207114645.GV5675@tucnak.redhat.com> <20151210175147.GE3534@virgil.suse.cz> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/24.5.1 (i586-pc-linux-gnu) Date: Tue, 26 Jan 2016 10:46:00 -0000 Message-ID: <87egd4y5xl.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2016-01/txt/msg01950.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 2148 Hi! On Thu, 10 Dec 2015 18:51:48 +0100, Martin Jambor wrote: > On Mon, Dec 07, 2015 at 12:46:45PM +0100, Jakub Jelinek wrote: > > On Mon, Dec 07, 2015 at 12:17:58PM +0100, Martin Jambor wrote: > > > [...] There are no failing > > > testcases if HSA is not configured. If it is, there are some, all of > > > which fall into one the following categories: > > >=20 > > > 1) HSA cannot compile a function for one reason or another (most > > > common cause is inability of HSA to take an address of a function > > > or make an indirect call) and gives a warning, which is regarded > > > as an "excess error" by dejagnu. Confirmed: [...]/gcc/testsuite/c-c++-common/gomp/clauses-1.c: In function 'bar._om= p_fn.26.hsa.31': cc1: warning: could not emit HSAIL for the function [-Whsa] cc1: note: support for HSA does not implement non-gridified OpenMP para= llel constructs. [...] ..., and many more. So, with --enable-offload-targets=3D[...],hsa we regress (PASS -> FAIL; "test for excess errors") such compile tests. > > It would be good if there is a -W* switch to turn such warnings off. > > Not just for the purposes of dejagnu libgomp testing, but say one > > might try to compile a program primarily say for XeonPhi or PTX offload= ing, > > but have HSA enabled to, but care primarily about the former two, etc. >=20 > All these warnings are in the -Whsa group and can be suppressed with > -Wno-hsa. These compile tests are done without any -W* flags; -Whsa is enabled by default. How to address this mismatch? Put -Wno-has into all regressing test case files individually? Run the affected testsuites with -Wno-hsa? Not enable -Whsa by default (but I agree it's useful to users)? (Instead, enable with -Wall, which any sane user should be specifying?) A very similar problem also exists for nvptx offloading (Nathan CCed), where we emit similar warnings (enabled by default). As nvptx offloading happens during link-time (not compile-time, as with hsa offloading), these don't affect GCC's compile tests, but need to be worked around in libgomp test cases. Gr=C3=BC=C3=9Fe Thomas --=-=-= Content-Type: application/pgp-signature; name="signature.asc" Content-length: 472 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWp052AAoJEK3/DN1sMFFt+9gH/2T/KJboUQr13J94PuOVpoAb ZPoqLhwNTlQ4EzzlCN1N4ZKOrV8lKD2qTEaX1IZLJ7HXnvAAuLCoK42fpMO8FttU YhJKfZncoauD6VTzZNhvEFtIFFnt7/s8FkbDABhCIIDqlN58+oEBXTa+x5f/zsD/ uXrNN+a5/m+4ejpwWObdhC4QnHJS4rJZtZXSXoGrG97XfQcQV7NDfaBhBzzh2Z/A RKJOWUKZQGezQ/xX58yK91Y14WLfDn1KYjbJHK8my2ibRK1533Mmo3o6K9x1XVab ohTJg2+VBhjutG9ZBjj7a9GFczcCtGc3JhoFRtp+1k7HP0vHnCNAESodkIvdB5k= =3Q+G -----END PGP SIGNATURE----- --=-=-=--