Re: [PATCH 2/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

[Thomas Schwinge <thomas@codesourcery.com>]

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]

Hi!

On Mon, 10 Feb 2014 00:10:26 +0100, Tobias Burnus <burnus@net-b.de> wrote:
> Ilmir Usmanov wrote:
> >     OpenACC 1.0 fortran FE support -- matching and resolving.

> > +static void
> > +resolve_oacc_cache (gfc_code *)
> > +{
> > +	//TODO: resolve subarrays
> > +}
> 
> ;-)

Just to clarify: I'm fine with incomplete changes being committed to the
gomp-4_0-branch, which is a development branch, as long as such changes
don't largely break the existing (working) code, as determined by the
testsuite for example.  Occasional "small" breakage should be fine, if it
is understood, and will be fixed later, like in the case where a recent
merge that I did from trunk into gomp-4_0-branch caused a regression in
one C++ OpenMP test case, which I could pinpoint to one
gomp-4_0-branch-specific patch, which Ilya Tocar by now has fixed
(pending commit).

What I'd generally like to see added are markers à la:

    /* TODO: resolve subarrays */
    gcc_unreachable ();

This makes it obvious both to the reader/reviewer and user of GCC ;-)
that this code path has not yet been implemented.  This is of course not
acceptable for released versions of GCC, but I think it's fine for the
gomp-4_0-branch, in this early OpenACC development stage.


Grüße,
 Thomas

[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]