public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [patch, mips] Change -mad to -mmad to match documentation
@ 2013-01-07 19:27 Steve Ellcey 
  2013-01-07 20:33 ` Richard Sandiford
  0 siblings, 1 reply; 2+ messages in thread
From: Steve Ellcey  @ 2013-01-07 19:27 UTC (permalink / raw)
  To: gcc-patches

The MIPS documentation describes a -mmad (-mno-mad) flag, but it is incorrectly
implemented as -mad (-mno-ad) instead.  This patch changes the implementation
to match the documentation.  This means that users who are currently using the
-mad or -mno-ad flags would have to change.  If we want we could leave -mad and
-mno-ad as aliases for -mmad and -mno-ad but I don't think that is necessary.

If someone does think we should do allow -mad, please let me know.

OK to checkin?

Steve Ellcey
sellcey@mips.com


2013-01-07  Steve Ellcey  <sellcey@mips.com>

	PR target/42661
	* config/mips/mips.opt: Change mad to mmad to match documentation.


diff --git a/gcc/config/mips/mips.opt b/gcc/config/mips/mips.opt
index dec028d..201d46f 100644
--- a/gcc/config/mips/mips.opt
+++ b/gcc/config/mips/mips.opt
@@ -55,7 +55,7 @@ mabicalls
 Target Report Mask(ABICALLS)
 Generate code that can be used in SVR4-style dynamic objects
 
-mad
+mmad
 Target Report Var(TARGET_MAD)
 Use PMC-style 'mad' instructions
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch, mips] Change -mad to -mmad to match documentation
  2013-01-07 19:27 [patch, mips] Change -mad to -mmad to match documentation Steve Ellcey 
@ 2013-01-07 20:33 ` Richard Sandiford
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Sandiford @ 2013-01-07 20:33 UTC (permalink / raw)
  To: Steve Ellcey ; +Cc: gcc-patches

"Steve Ellcey " <sellcey@mips.com> writes:
> The MIPS documentation describes a -mmad (-mno-mad) flag, but it is incorrectly
> implemented as -mad (-mno-ad) instead.  This patch changes the implementation
> to match the documentation.  This means that users who are currently using the
> -mad or -mno-ad flags would have to change.  If we want we could leave -mad and
> -mno-ad as aliases for -mmad and -mno-ad but I don't think that is necessary.
>
> If someone does think we should do allow -mad, please let me know.
>
> OK to checkin?

OK, thanks.  Looks like I introduced this in the TARGET_OPTINS ->
.opt-file conversion.

Richard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-01-07 20:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-07 19:27 [patch, mips] Change -mad to -mmad to match documentation Steve Ellcey 
2013-01-07 20:33 ` Richard Sandiford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).