public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kenneth Zadeck <Kenneth.Zadeck@NaturalBridge.com>
To: volodyan@gmail.com, abel@ispras.ru, gcc-patches@gcc.gnu.org,
	Ayal Zaks <ZAKS@il.ibm.com>
Subject: [PATCH][Modulo-sched] Avoid SMS when the candidate loop contains INC  instruction
Date: Thu, 26 Jul 2007 16:40:00 -0000	[thread overview]
Message-ID: <87ejivjft5.fsf@moria.site> (raw)
In-Reply-To: <OF75BAE848.B63E5DE5-ONC2257323.005B1F08-C2257324.003B7333@il.ibm.com>

> Hello,
> 
> We decided to break Patch 1 of 2 into sub-patches and insert them
> gradually.  (http://gcc.gnu.org/ml/gcc-patches/2007-07/msg01515.html)
> 
> This is the first one which avoids performing SMS when the candidate
> loop contains auto-increment instruction.
> 
> The testcase attached is inspired from array_constructor_12.f90 testcase.
> 
> This patch was bootstrapped and tested on ppc64 with -fmodulo-sched
> flag. (all languages except Ada)

This really cannot be the right thing to do.

If you have a loop that you want to modulo schedule, you should expand
the autoinc insn back into two insns.  If you really find some reason
why you do not want to do that, then you should not run the auto inc
finding pass when you enable modulo scheduling.

Kenny

> 
> :ADDPATCH modulo-sched:
> 
> OK for mainline?
> 
> Thanks,
> Revital
> 
> 2007-07-26  Vladimir Yanovsky  <yanov@il.ibm.com>
> 
>         * modulo-sched.c (sms_schedule): Avoid loops which includes
>         auto-increment instructions.
> 
>         * testsuite/gfortran.dg/sms-1.f90: New test.

  reply	other threads:[~2007-07-26 16:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-26 11:06 Revital1 Eres
2007-07-26 16:40 ` Kenneth Zadeck [this message]
2007-07-26 18:21   ` Ayal Zaks
     [not found] <OF75BAE848.B63E5DE5-ONC2257323.005B1F08-C2257324.003B7333@LocalDomain>
2007-07-26 11:34 ` Ayal Zaks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ejivjft5.fsf@moria.site \
    --to=kenneth.zadeck@naturalbridge.com \
    --cc=ZAKS@il.ibm.com \
    --cc=abel@ispras.ru \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=volodyan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).