From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path:
Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
by sourceware.org (Postfix) with ESMTP id C89F9385840D
for ; Tue, 9 Apr 2024 12:56:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C89F9385840D
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C89F9385840D
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712667398; cv=none;
b=ok9Jf4kU0fe+yg8bMUavXpI30z1qH41liwZ4qmH8znYjbf42ZPI/qA1dlLz42u88tpRySCZBd8zLXBFOpShIgTKmMQt3ksPWNZHltXCBzMupUuBypPa0aPCqqhZ6JTmS6nOJGfkSEmb+oZrGz3A70lHPd1ODZFuQdcvYV7kZefg=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
t=1712667398; c=relaxed/simple;
bh=oKxEsXI6LUXuXpV5dukMox0A0W9OnIiD7FbevIM+KEA=;
h=From:To:Subject:Date:Message-ID:MIME-Version; b=eyZ/qsFx0/lU2UX0r3zRXYNKbXYy/6w5t4WocqOa8zXcFW5GoFky4Db4EUeWbvyDXRCLBYi8+wfGBDxfbTuIJ4AttZ075KOGhD0xDW/6CORpXMnXAJfK/bXBHou8gTs1tXDLt6zeDInt5pwCkALKtuE0AsxcaE1cCjub+qEUEUQ=
ARC-Authentication-Results: i=1; server2.sourceware.org
From: Sam James
To: Sebastian Huber
Cc: Florian Weimer , gcc-patches@gcc.gnu.org, Gerald
Pfeifer
Subject: Re: [PATCH v3 06/11] c: Turn -Wimplicit-function-declaration into a
permerror
In-Reply-To: <61b1ac1e-26d8-494d-ace2-175f06e8f632@embedded-brains.de>
(Sebastian Huber's message of "Tue, 9 Apr 2024 14:26:34 +0200")
Organization: Gentoo
References:
<1f9c86b42e3c99ba679df6282f6c28f359c3f4ec.1700473918.git.fweimer@redhat.com>
<9b9591c7-7080-4fb8-9486-23408e77cdde@embedded-brains.de>
<87o7aizqhz.fsf@gentoo.org>
<61b1ac1e-26d8-494d-ace2-175f06e8f632@embedded-brains.de>
User-Agent: mu4e 1.12.2; emacs 30.0.50
Date: Tue, 09 Apr 2024 13:56:30 +0100
Message-ID: <87frvuzoch.fsf@gentoo.org>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id:
Sebastian Huber writes:
> On 09.04.24 14:10, Sam James wrote:
>> Sebastian Huber writes:
>>
>>> On 20.11.23 10:56, Florian Weimer wrote:
>>>> In the future, it may make sense to avoid cascading errors from
>>>> the implicit declaration, especially its assumed int return type.
>>>> This change here only changes the kind of the diagnostic, not
>>>> its wording or consequences.
>>> Maybe this change should be added to the GCC 14 release notes.
>> Can you be more specific? Florian wrote about it in detail at
>> https://gcc.gnu.org/gcc-14/porting_to.html#c.
>> If you're referring specifically to the
>> cascade-affecting-diagnostics,
>> that change hasn't been made yet.
>> What am I missing?
>
> I searched for "implicit-function-declaration" at
>
> https://gcc.gnu.org/gcc-14/changes.html
>
> and found nothing. All right, the
>
> https://gcc.gnu.org/gcc-14/porting_to.html
>
> has a description, but this is one step away from the release
> notes. Maybe something like this could be added to the release notes:
>
I sympathise with the request. I note that we *did* mention -fno-common
at https://gcc.gnu.org/gcc-10/changes.html and just gave more detail at
https://gcc.gnu.org/gcc-10/porting_to.html. (I was pretty sure we hadn't
until I checked.)
Gerald?
> diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
> index ff69e859..90a14f37 100644
> --- a/htdocs/gcc-14/changes.html
> +++ b/htdocs/gcc-14/changes.html
> @@ -231,6 +231,17 @@ a work-in-progress.
> previous options -std=c2x
, -std=gnu2x
> and -Wc11-c2x-compat
, which are deprecated but remain
> supported.
> + The following warnings are now errors (see also
> + Porting to GCC 14):
> +
> + -Werror=declaration-missing-parameter-type
> + -Werror=implicit-function-declaration
> + -Werror=implicit-int
> + -Werror=incompatible-pointer-types
> + -Werror=int-conversion
> + -Werror=return-mismatch
> +
> +
>
>
> C++
thanks,
sam