From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 310D93858CD1 for ; Fri, 8 Dec 2023 09:33:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 310D93858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 310D93858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.129.153 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702028002; cv=none; b=hKGyhZCvXyrOeLIawJQlTQekulxm29M/tEeD2KOP/fDlc4ORGWIQJ7LdDzHpLz9Gruj7/xER+nfQ9GQeo+Va2CE/9G4FYI6NuNTGfqOy0Uhtizc0Wv20yTSiK2SsYeAKaIEfEiTpN5YCaXeP8Rij2GUS+dBlEGQnT/srrs0y+To= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702028002; c=relaxed/simple; bh=lleDmBf9q3x746AF70Gzen9HsIaUx0IHEwQa14g5yuI=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=sq1mz6kGrk/Qq6gtZyDa5juK45kirRECgotFlsQgBMVifKQAOcOe8DzKXjIjLu0BK+2XTW/CmORyWZBAd3juImj2xtLlkbGb7N3ccnrlxMu8Hnp2krXhNs5KaG9m11FHZBDRIRSIjPQBDsfCLgps4DiXdElH/g0pjFhaWCxW+zw= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: 8jjA0M1lSi2fMHaLTZFyAw== X-CSE-MsgGUID: bYMjNF2dTZmsfNk3DC55dA== X-IronPort-AV: E=Sophos;i="6.04,260,1695715200"; d="scan'208";a="28025929" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 08 Dec 2023 01:33:18 -0800 IronPort-SDR: IlDN3R1CDjCjAvzkabgnccn/s149G7WGnyU3R4AiH3prqH4SCyD3jGRmAIoEBC5uJAKhtalMIx 7VQf3BmOoNhHpj+dxodzr3LbhW/QimhoHGXMqaFdCLePea9hzLI9kNTMoDrvAFjU0Q9l1yaOip GlXz1Uv+GtphFA6fIfkeOZSfaadNfO63/7mX0RicW6TNJpN6+JaoKv9gX1pddF4AypqYxEe+w/ jlpDUmKr/vD3E+cUVC1LF9iARYTmxjI7mtMSoz3ELDmHaUkHlVaw4+MR9FiqDNBWTczsaX2OFR IbY= From: Thomas Schwinge To: Alexandre Oliva CC: FX Coudert , Tobias Burnus , Richard Biener , , Jeremy Bennett , Craig Blackmore , Graham Markall , Martin Jambor , "Jan Hubicka" , Jim Wilson , Jeff Law , Jakub Jelinek , Tom de Vries Subject: Re: [PATCH] strub: skip emutls after strubm errors In-Reply-To: References: <87lea7sh0h.fsf@euler.schwinge.homeip.net> <8734wet11e.fsf@euler.schwinge.homeip.net> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Fri, 8 Dec 2023 10:33:10 +0100 Message-ID: <87fs0dyr6x.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-13.mgc.mentorg.com (139.181.222.13) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Alexandre! On 2023-12-07T14:52:19-0300, Alexandre Oliva wrote: > On Dec 7, 2023, Thomas Schwinge wrote: >> during IPA pass: emutls >> [...]/source-gcc/gcc/testsuite/c-c++-common/strub-unsupported-3.c:18= :1: internal compiler error: in verify_curr_properties, at passes.cc:2198 > > Aah, this smells a lot like the issue that Fran=C3=A7ois-Xavier reported, > that the following patch is expected to fix. I'm still regstrapping it > on x86_64-linux-gnu, after checking that it addressed the symptom on a > cross compiler to the target for which it had originally been reported. > Ok to install, once you confirm that it cures these ICEs? Yes, GCC/nvptx ICEs gone with that, thanks! Gr=C3=BC=C3=9Fe Thomas > strub: skip emutls after strubm errors > > The emutls pass requires PROP_ssa, but if the strubm pass (or any > other pre-SSA pass) issues errors, all of the build_ssa_passes are > skipped, so the property is not set, but emutls still attempts to run, > on targets that use it, despite earlier errors, so it hits the > unsatisfied requirement. > > Adjust emutls to be skipped in case of earlier errors. > > > for gcc/ChangeLog > > * tree-emutls.cc: Include diagnostic-core.h. > (pass_ipa_lower_emutls::gate): Skip if errors were seen. > --- > gcc/tree-emutls.cc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gcc/tree-emutls.cc b/gcc/tree-emutls.cc > index 5dca5a8291356..38de202717a1a 100644 > --- a/gcc/tree-emutls.cc > +++ b/gcc/tree-emutls.cc > @@ -35,6 +35,7 @@ along with GCC; see the file COPYING3. If not see > #include "langhooks.h" > #include "tree-iterator.h" > #include "gimplify.h" > +#include "diagnostic-core.h" /* for seen_error */ > > /* Whenever a target does not support thread-local storage (TLS) nativel= y, > we can emulate it with some run-time support in libgcc. This will in > @@ -841,7 +842,7 @@ public: > bool gate (function *) final override > { > /* If the target supports TLS natively, we need do nothing here. = */ > - return !targetm.have_tls; > + return !targetm.have_tls && !seen_error (); > } > > unsigned int execute (function *) final override ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955