Hi David, Please find the new version inline right after the inline reply. >> gcc/ChangeLog: >> * config/bpf/bpf-passes.def (pass_lower_bpf_core): Added pass. > > It may only be due to how the patch is formatted in the attachment > (everything above the first diff seems to be indented?), but each entry > here should start with a tab rather than spaces. > > Please double-check with contrib/gcc-changelog/git_check_commit.py, it > will complain if the indentation is wrong. It did pass the check. I think it might be because of inline attachment. > * config/bpf/core-builtins.cc (cr_builtins, is_attr_preserve_access) > (core_field_info, bpf_core_get_index): Changed to do blah. > > Same thing about the multi-line entry within a single () pair. > Corrected! >> +/* Declaration of target-specific passes for eBPF. >> + Copyright (C) 2021-2023 Free Software Foundation, Inc. > > This file is new, so just 2023 no? Yes ! >> - const char * section_name; >> + const char section_name; > > Why this change from char* to char? > > This change doesn't make sense given the expressions assigned to > the variable. In fact, this does not compile. > It was an editor mistake ... caused by the editor sitting in a chair. ;-) Apologies for this mistake and thanks for catching it. Thanks, Cupertino