From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id BB1AE3858D32 for ; Mon, 26 Sep 2022 11:16:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB1AE3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,345,1654588800"; d="scan'208";a="83612460" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 26 Sep 2022 03:16:26 -0800 IronPort-SDR: MFBfYuiDXQn+gzaAGU4q4ZdwSNHpV/camh7uZi/0h3YyXI4j84Mis6n8ED6c+Sn2/CIvZxXj/a hpo1jYjRyOj8VfBboFAyssvyp4e3DgCb1TDmne7HI1UVy1uG0ziCo1J01ak+yX5knoHRyPF1v8 5mMkUyufSUOrA9y3SlFtJJ/OqXnGoT1vz63/1Ba5S4pzdUqrHj+P/Yi6lTfdrrijjC740n8mEP FPO95bbTMkvvnX9sz3oZ5c7A1rBnlFKulZYkpiFjkknxl/VRk8najukEXk+bvrlI/CWMy8hZqN O4s= From: Thomas Schwinge To: Richard Biener , Tobias Burnus CC: Subject: Re: [Patch] OpenACC: Fix reduction tree-sharing issue [PR106982] In-Reply-To: References: User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Mon, 26 Sep 2022 13:16:17 +0200 Message-ID: <87fsgel726.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-14.mgc.mentorg.com (139.181.222.14) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On 2022-09-26T11:34:48+0200, Richard Biener via Gcc-patches wrote: > On Mon, Sep 26, 2022 at 11:27 AM Tobias Burnus = wrote: >> On 26.09.22 10:32, Richard Biener wrote: >>> On Fri, Sep 23, 2022 at 5:25 PM Tobias Burnus = wrote: >> >>> This fixes a tree-sharing ICE. Thanks for looking into this! >> looks like v1/v2/v3 are now unshared twice > I prefer v2a - the unshare_exprs at the sinks where sharing isn't OK. > > That variant is OK, ACK from me, too. Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955