From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 22BE03858C50 for ; Tue, 29 Mar 2022 09:23:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 22BE03858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.90,219,1643702400"; d="scan'208,223";a="73566875" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 29 Mar 2022 01:23:18 -0800 IronPort-SDR: jqwWcIBIkEZXLYHxddm2Wp2UEDoY0wEtL1VFPwFiMQEAjVUShMnmByNEj7+G+XnyktvqbEPrPy mENXCuroJjzvWse0wbgoF3Fk4WCWHxTBjJYqEYhp6+F1Dq0pMj7YdppDzb0xdpETC9MRlsY5my 7jxJA1FJ+nXczYpOPlI7UI6staPaw3Q8F3vc89HA1J1AjjYgr/ug+430QBMBbAQHLjgMiLWRXv HsaUIgfqsQir+RUVkhb0U+Ldpuj140p+U8q9hsOWM2wnBagX11xaZ5wzx2IBav1SUobghcipQv 8eo= From: Thomas Schwinge To: Martin Sebor , , Joseph Myers Subject: options: Remove 'gcc/c-family/c.opt:Warray-bounds' option definition record (was: committed: remove redundant -Wall from -Warray-bounds (PR 82063)) In-Reply-To: References: User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Tue, 29 Mar 2022 11:23:09 +0200 Message-ID: <87fsn19koy.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2022 09:23:19 -0000 --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi! On 2018-07-20T15:22:23-0600, Martin Sebor wrote: > As the last observation in PR 82063 Jim points out that > > Both -Warray-bounds and -Warray-bounds=3D are listed in the c.opt > file as being enabled by -Wall, but they are the same option, > and it causes this one option to be processed twice in the > C_handle_option_auto function in the generated options.c file. > It gets set to the same value twice, so it does work as intended, > but this is wasteful. > > I have removed the redundant -Wall from the first option and > committed the change as obvious in r262912. That's r262912/commit 0d7f90652080c42cddca6f9b68f6895218c70880 "PR middle-end/82063 - issues with arguments enabled by -Wall": | --- gcc/c-family/c.opt | +++ gcc/c-family/c.opt | [...] | Warray-bounds | -LangEnabledBy(C ObjC C++ LTO ObjC++,Wall) | +LangEnabledBy(C ObjC C++ LTO ObjC++) | ; in common.opt | | Warray-bounds=3D OK to push the attached "options: Remove 'gcc/c-family/c.opt:Warray-bounds' option definition record"? Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename="0001-options-Remove-gcc-c-family-c.opt-Warray-bounds-opti.patch" >From 15b8d3d6265529bcab74c81b742cd4d1ef2ef37b Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Thu, 24 Mar 2022 22:17:23 +0100 Subject: [PATCH] options: Remove 'gcc/c-family/c.opt:Warray-bounds' option definition record A one-argument form of the 'LangEnabledBy' option property isn't defined, and effectively appears to be a no-op. Removing that one, the 'gcc/c-family/c.opt:Warray-bounds' option definition record becomes empty, and doesn't add anything over 'gcc/common.opt:Warray-bounds', and may thus be removed entirely. This only changes 'build-gcc/gcc/optionlist' accordingly, but no other generated files. Clean-up after r262912/commit 0d7f90652080c42cddca6f9b68f6895218c70880 "PR middle-end/82063 - issues with arguments enabled by -Wall". gcc/c-family/ * c.opt (Warray-bounds): Remove. --- gcc/c-family/c.opt | 4 ---- 1 file changed, 4 deletions(-) diff --git a/gcc/c-family/c.opt b/gcc/c-family/c.opt index 790d47caf0a..3c2ec7744b0 100644 --- a/gcc/c-family/c.opt +++ b/gcc/c-family/c.opt @@ -342,10 +342,6 @@ Wno-alloca-larger-than C ObjC C++ LTO ObjC++ Alias(Walloca-larger-than=,18446744073709551615EiB,none) Warning Disable Walloca-larger-than= warning. Equivalent to Walloca-larger-than= or larger. -Warray-bounds -LangEnabledBy(C ObjC C++ LTO ObjC++) -; in common.opt - Warray-bounds= LangEnabledBy(C ObjC C++ LTO ObjC++,Wall,1,0) ; in common.opt -- 2.25.1 --=-=-=--