From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121124 invoked by alias); 29 Apr 2015 17:19:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 120343 invoked by uid 89); 29 Apr 2015 17:19:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Apr 2015 17:18:59 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1YnVdP-0006bv-Hy from Thomas_Schwinge@mentor.com ; Wed, 29 Apr 2015 10:18:55 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Wed, 29 Apr 2015 18:18:53 +0100 From: Thomas Schwinge To: Julian Brown CC: , Jakub Jelinek Subject: Re: [PATCH] Tidy up locking for libgomp OpenACC entry points In-Reply-To: <20150424181308.099d8a26@octopus> References: <20150422194243.115f26fa@octopus> <87egnavltt.fsf@schwinge.name> <20150424181308.099d8a26@octopus> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Wed, 29 Apr 2015 17:47:00 -0000 Message-ID: <87fv7irgy5.fsf@schwinge.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2015-04/txt/msg01909.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1132 Hi Julian! On Fri, 24 Apr 2015 18:13:08 +0100, Julian Brown = wrote: > On Thu, 23 Apr 2015 18:41:34 +0200 > Thomas Schwinge wrote: > > On Wed, 22 Apr 2015 19:42:43 +0100, Julian Brown > > wrote: > > > This patch is an attempt to fix some potential race conditions with > > > accesses to shared data structures from multiple concurrent threads > > > in libgomp's OpenACC entry points. > > > Tests look OK (with offloading to NVidia PTX). > >=20 > > How did you test to get some confidence in the locking being > > sufficient? >=20 > Merely by running the existing tests and via inspection, sadly. I'm not > sure how much value we'd get from implementing an exhaustive threading > testsuite at this stage: I guess testcases will be easier to come by in > the future if/when people start to use e.g. OpenMP and OpenACC together. ;-) The poor person to be the first to actually exercise all that code... Thanks for your explanations and the rework. > Re-tested (libgomp), results look OK. >=20 > OK to apply now? OK, thanks! Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature Content-length: 472 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVQRJzAAoJEPoxNhtoi6COicwIAI2Rip/R1FYogFmALIe8qF3Z c14sL4G0GaHuaLzSsSdiXR0hEfFe2C73lj0tCR+nIVg9e0tqtUmuqJn8lM2WDQoB PKGi0ecZwMKzy0BSh2aC84xrVRwnh+NrYNupX/mp80yQac3/Bq7+eigyavkwUgBa 2PPJLDUVFpVzk+mhDs7B4Bb+Vy/yGbbbbZqdtbLUzjkqZED1tpCfuusqym6A1yuC PSXkSjBoIOgdtC+h6LzBBqpEsnmlzerJaXOTH4RX3Bde7ihNx2hJKcVmUq2AUWrg mA/g6IwjbdWYYmJln7nnw/M5eUfHs4R0aH7H5B/8vNtLYJ/+OHo/SxoapjhqsjE= =A3GO -----END PGP SIGNATURE----- --=-=-=--