Re: [PATCH][3/3][PR65460] Mark offloaded functions as parallelized

[Thomas Schwinge <Thomas_Schwinge@mentor.com>]

[-- Attachment #1: Type: text/plain, Size: 4614 bytes --]

Hi Tom!

On Sat, 21 Mar 2015 23:30:51 +0100, Tom de Vries <Tom_deVries@mentor.com> wrote:
> On 20-03-15 12:38, Tom de Vries wrote:
> > On 19-03-15 12:05, Tom de Vries wrote:
> >> On 18-03-15 18:22, Tom de Vries wrote:
> >>> this patch fixes PR65460.
> >>>
> >>> The patch marks offloaded functions as parallelized, which means the parloops
> >>> pass no longer attempts to modify that function.
> >>
> >> Updated patch to postpone mark_parallelized_function until the corresponding
> >> cgraph_node is available, to ensure it works with the updated
> >> mark_parallelized_function from patch 2/3.
> >
> > Updated to eliminate mark_parallelized_function.
> >
> > Bootstrapped and reg-tested on x86_64.
> >
> > OK for stage4?
> 
> as requested, applied to gomp-4_0-branch.

Thanks!


Committed to gomp-4_0-branch in r221652:

commit 68c0851cb7ce420d5d938d7f0d9247adf79190a5
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Wed Mar 25 08:28:09 2015 +0000

    Use ChangeLog.gomp on gomp-4_0-branch.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@221652 138bc75d-0d04-0410-961f-82ee72b054a4
---
 gcc/ChangeLog      |   34 ----------------------------------
 gcc/ChangeLog.gomp |   34 ++++++++++++++++++++++++++++++++++
 2 files changed, 34 insertions(+), 34 deletions(-)

diff --git gcc/ChangeLog gcc/ChangeLog
index 48dca87..e474fc8 100644
--- gcc/ChangeLog
+++ gcc/ChangeLog
@@ -1,37 +1,3 @@
-2015-03-21  Tom de Vries  <tom@codesourcery.com>
-
-	PR tree-optimization/65460
-	* omp-low.c (expand_omp_target): Set parallelized_function on
-	cgraph_node for child_fn.
-
-2015-03-21  Tom de Vries  <tom@codesourcery.com>
-
-	backport from trunk:
-	2015-03-21  Tom de Vries  <tom@codesourcery.com>
-
-	PR tree-optimization/65458
-	* cgraph.c (cgraph_node::dump): Handle parallelized_function field.
-	* cgraph.h (cgraph_node): Add parallelized_function field.
-	* lto-cgraph.c (lto_output_node): Write parallelized_function field.
-	(input_overwrite_node): Read parallelized_function field.
-	* omp-low.c (expand_omp_taskreg, finalize_task_copyfn): Set
-	parallelized_function on cgraph_node for child_fn.
-	* tree-parloops.c: Add include of plugin-api.h, ipa-ref.h and cgraph.h.
-	Remove include of gt-tree-parloops.h.
-	(parallelized_functions): Remove static variable.
-	(parallelized_function_p): Rewrite using parallelized_function field of
-	cgraph_node.
-	(create_loop_fn): Remove adding to parallelized_functions.
-	* Makefile.in (GTFILES): Remove tree-parloops.c
-
-2015-03-21  Tom de Vries  <tom@codesourcery.com>
-
-	backport from trunk:
-	2015-03-18  Tom de Vries  <tom@codesourcery.com>
-
-	* tree-parloops.c (parallelize_loops): Make static.
-	* tree-parloops.h (parallelize_loops): Remove extern declaration.
-
 2015-03-11  Thomas Schwinge  <thomas@codesourcery.com>
 
 	* config/nvptx/nvptx.h (LIBSTDCXX): Define to "gcc".
diff --git gcc/ChangeLog.gomp gcc/ChangeLog.gomp
index 6ed6962..b499d04 100644
--- gcc/ChangeLog.gomp
+++ gcc/ChangeLog.gomp
@@ -1,3 +1,37 @@
+2015-03-21  Tom de Vries  <tom@codesourcery.com>
+
+	PR tree-optimization/65460
+	* omp-low.c (expand_omp_target): Set parallelized_function on
+	cgraph_node for child_fn.
+
+2015-03-21  Tom de Vries  <tom@codesourcery.com>
+
+	backport from trunk:
+	2015-03-21  Tom de Vries  <tom@codesourcery.com>
+
+	PR tree-optimization/65458
+	* cgraph.c (cgraph_node::dump): Handle parallelized_function field.
+	* cgraph.h (cgraph_node): Add parallelized_function field.
+	* lto-cgraph.c (lto_output_node): Write parallelized_function field.
+	(input_overwrite_node): Read parallelized_function field.
+	* omp-low.c (expand_omp_taskreg, finalize_task_copyfn): Set
+	parallelized_function on cgraph_node for child_fn.
+	* tree-parloops.c: Add include of plugin-api.h, ipa-ref.h and cgraph.h.
+	Remove include of gt-tree-parloops.h.
+	(parallelized_functions): Remove static variable.
+	(parallelized_function_p): Rewrite using parallelized_function field of
+	cgraph_node.
+	(create_loop_fn): Remove adding to parallelized_functions.
+	* Makefile.in (GTFILES): Remove tree-parloops.c
+
+2015-03-21  Tom de Vries  <tom@codesourcery.com>
+
+	backport from trunk:
+	2015-03-18  Tom de Vries  <tom@codesourcery.com>
+
+	* tree-parloops.c (parallelize_loops): Make static.
+	* tree-parloops.h (parallelize_loops): Remove extern declaration.
+
 2015-01-13  Thomas Schwinge  <thomas@codesourcery.com>
 
 	* tree-core.h: Don't include "gomp-constants.h".


Grüße,
 Thomas

[-- Attachment #2: Type: application/pgp-signature, Size: 472 bytes --]