public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <rdsandiford@googlemail.com>
To: Richard Earnshaw <rearnsha@arm.com>
Cc: Andrew Pinski <andrew.pinski@caviumnetworks.com>,
	 GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [AARCH64/Committed] Fix g++.dg/abi/aarch64_guard1.C
Date: Wed, 28 Nov 2012 21:00:00 -0000	[thread overview]
Message-ID: <87fw3tmoi8.fsf@talisman.default> (raw)
In-Reply-To: <50B62BA0.6060003@arm.com> (Richard Earnshaw's message of "Wed,	28 Nov 2012 15:20:00 +0000")

Richard Earnshaw <rearnsha@arm.com> writes:
> On 06/11/12 22:05, Andrew Pinski wrote:
>> Hi,
>>    The problem here is with section anchors turned on, we generate a
>> BSS rather than a local common symbol and we no longer match the
>> pattern: "_ZGVZ3foovE1x,8,8".  This fixes this testcase by just adding
>> -fno-section-anchors.
>>
>
> Why is -fsection-anchors changing the choice of output section?  Sure, 
> section anchors are more useful when you use BSS rather than Common, but 
> it shouldn't in itself be changing that choice.

It's not really changing the output section, just the assembly syntax
used to define the symbol.  Local common ends up as the equivalent of:

	.section .bss,...
	.align   M
foo:
	.size    N

Richard

      reply	other threads:[~2012-11-28 21:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-06 22:06 Andrew Pinski
2012-11-28 15:20 ` Richard Earnshaw
2012-11-28 21:00   ` Richard Sandiford [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fw3tmoi8.fsf@talisman.default \
    --to=rdsandiford@googlemail.com \
    --cc=andrew.pinski@caviumnetworks.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rearnsha@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).