* [AARCH64/Committed] Fix g++.dg/abi/aarch64_guard1.C
@ 2012-11-06 22:06 Andrew Pinski
2012-11-28 15:20 ` Richard Earnshaw
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Pinski @ 2012-11-06 22:06 UTC (permalink / raw)
To: GCC Patches
[-- Attachment #1: Type: text/plain, Size: 361 bytes --]
Hi,
The problem here is with section anchors turned on, we generate a
BSS rather than a local common symbol and we no longer match the
pattern: "_ZGVZ3foovE1x,8,8". This fixes this testcase by just adding
-fno-section-anchors.
Thanks,
Andrew Pinski
2012-11-06 Andrew Pinski <apinski@cavium.com>
* g++.dg/abi/aarch64_guard1.C: Add -fno-section-anchors.
[-- Attachment #2: fixabitestcase.diff.txt --]
[-- Type: text/plain, Size: 499 bytes --]
Index: g++.dg/abi/aarch64_guard1.C
===================================================================
--- g++.dg/abi/aarch64_guard1.C (revision 193259)
+++ g++.dg/abi/aarch64_guard1.C (working copy)
@@ -2,7 +2,7 @@
// 8-byte doubleword and that only the least significant bit is used
// for initialization guard variables.
// { dg-do compile { target aarch64*-*-* } }
-// { dg-options "-O -fdump-tree-original" }
+// { dg-options "-O -fdump-tree-original -fno-section-anchors" }
int bar();
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [AARCH64/Committed] Fix g++.dg/abi/aarch64_guard1.C
2012-11-06 22:06 [AARCH64/Committed] Fix g++.dg/abi/aarch64_guard1.C Andrew Pinski
@ 2012-11-28 15:20 ` Richard Earnshaw
2012-11-28 21:00 ` Richard Sandiford
0 siblings, 1 reply; 3+ messages in thread
From: Richard Earnshaw @ 2012-11-28 15:20 UTC (permalink / raw)
To: Andrew Pinski; +Cc: GCC Patches
On 06/11/12 22:05, Andrew Pinski wrote:
> Hi,
> The problem here is with section anchors turned on, we generate a
> BSS rather than a local common symbol and we no longer match the
> pattern: "_ZGVZ3foovE1x,8,8". This fixes this testcase by just adding
> -fno-section-anchors.
>
Why is -fsection-anchors changing the choice of output section? Sure,
section anchors are more useful when you use BSS rather than Common, but
it shouldn't in itself be changing that choice.
R.
> Thanks,
> Andrew Pinski
>
> 2012-11-06 Andrew Pinski <apinski@cavium.com>
>
> * g++.dg/abi/aarch64_guard1.C: Add -fno-section-anchors.
>
>
> fixabitestcase.diff.txt
>
>
> Index: g++.dg/abi/aarch64_guard1.C
> ===================================================================
> --- g++.dg/abi/aarch64_guard1.C (revision 193259)
> +++ g++.dg/abi/aarch64_guard1.C (working copy)
> @@ -2,7 +2,7 @@
> // 8-byte doubleword and that only the least significant bit is used
> // for initialization guard variables.
> // { dg-do compile { target aarch64*-*-* } }
> -// { dg-options "-O -fdump-tree-original" }
> +// { dg-options "-O -fdump-tree-original -fno-section-anchors" }
>
> int bar();
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [AARCH64/Committed] Fix g++.dg/abi/aarch64_guard1.C
2012-11-28 15:20 ` Richard Earnshaw
@ 2012-11-28 21:00 ` Richard Sandiford
0 siblings, 0 replies; 3+ messages in thread
From: Richard Sandiford @ 2012-11-28 21:00 UTC (permalink / raw)
To: Richard Earnshaw; +Cc: Andrew Pinski, GCC Patches
Richard Earnshaw <rearnsha@arm.com> writes:
> On 06/11/12 22:05, Andrew Pinski wrote:
>> Hi,
>> The problem here is with section anchors turned on, we generate a
>> BSS rather than a local common symbol and we no longer match the
>> pattern: "_ZGVZ3foovE1x,8,8". This fixes this testcase by just adding
>> -fno-section-anchors.
>>
>
> Why is -fsection-anchors changing the choice of output section? Sure,
> section anchors are more useful when you use BSS rather than Common, but
> it shouldn't in itself be changing that choice.
It's not really changing the output section, just the assembly syntax
used to define the symbol. Local common ends up as the equivalent of:
.section .bss,...
.align M
foo:
.size N
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-28 21:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-06 22:06 [AARCH64/Committed] Fix g++.dg/abi/aarch64_guard1.C Andrew Pinski
2012-11-28 15:20 ` Richard Earnshaw
2012-11-28 21:00 ` Richard Sandiford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).