From: ludovic.courtes@inria.fr (Ludovic Courtès)
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, Paul Brook <paul@codesourcery.com>
Subject: Re: [PATCH] Don't insert white space in 'orig_option_with_args_text' for OPT_l
Date: Tue, 13 Mar 2012 10:12:00 -0000 [thread overview]
Message-ID: <87fwdcrese.fsf@inria.fr> (raw)
In-Reply-To: <Pine.LNX.4.64.1203121241180.28122@digraph.polyomino.org.uk> (Joseph S. Myers's message of "Mon, 12 Mar 2012 12:41:37 +0000 (UTC)")
[-- Attachment #1: Type: text/plain, Size: 617 bytes --]
Hi,
(Cc: Paul Brook.)
"Joseph S. Myers" <joseph@codesourcery.com> skribis:
> On Mon, 12 Mar 2012, Ludovic Courtès wrote:
>
>> The patch below solves the problem in a gfortran-specific way. WDYT?
>
> I think that's the right approach for this issue.
The previous patch was produced with ‘diff -b’. Here’s a fixed one.
Let me know if anything else needs to be done.
Thanks,
Ludo’.
2012-03-09 Ludovic Courtès <ludovic.courtes@inria.fr>
* gcc/fortran/gfotranspec.c (lang_specific_driver): When
VERBOSE, make sure `-l' options are printed with no intertwined
white spaces.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 792 bytes --]
diff --git a/gcc/fortran/gfortranspec.c b/gcc/fortran/gfortranspec.c
index 2240bfb..55e5e42 100644
--- a/gcc/fortran/gfortranspec.c
+++ b/gcc/fortran/gfortranspec.c
@@ -461,8 +461,15 @@ For more information about these matters, see the file named COPYING\n\n"));
{
fprintf (stderr, _("Driving:"));
for (i = 0; i < g77_newargc; i++)
- fprintf (stderr, " %s",
- g77_new_decoded_options[i].orig_option_with_args_text);
+ {
+ if (g77_new_decoded_options[i].opt_index == OPT_l)
+ /* Make sure no white space is inserted after `-l'. */
+ fprintf (stderr, " -l%s",
+ g77_new_decoded_options[i].canonical_option[1]);
+ else
+ fprintf (stderr, " %s",
+ g77_new_decoded_options[i].orig_option_with_args_text);
+ }
fprintf (stderr, "\n");
}
next prev parent reply other threads:[~2012-03-13 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 15:38 [PATCH] Don’t insert white space in ‘orig_option_with_args_text’ " Ludovic Courtès
2012-03-09 17:28 ` [PATCH] Don't insert white space in 'orig_option_with_args_text' " Joseph S. Myers
2012-03-12 11:02 ` Ludovic Courtès
2012-03-12 12:41 ` Joseph S. Myers
2012-03-13 10:12 ` Ludovic Courtès [this message]
2012-03-29 8:38 ` [PATCH, ping #1] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwdcrese.fsf@inria.fr \
--to=ludovic.courtes@inria.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=paul@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).