From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-123954-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 25607 invoked by alias); 2 Aug 2004 15:35:06 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 25600 invoked from network); 2 Aug 2004 15:35:05 -0000
Received: from unknown (HELO email3.peakpeak.com) (207.189.223.52)
  by sourceware.org with SMTP; 2 Aug 2004 15:35:05 -0000
Received: (qmail 17899 invoked by uid 513); 2 Aug 2004 15:43:20 -0000
Received: from tromey@redhat.com by email3 by uid 504 with qmail-scanner-1.20 
 (clamscan: 0.65.  Clear:RC:1(204.144.239.10):. 
 Processed in 0.10627 secs); 02 Aug 2004 15:43:20 -0000
Received: from tf0010.peakpeak.com (HELO fleche.redhat.com) ([204.144.239.10])
          (envelope-sender <tromey@redhat.com>)
          by email3.peakpeak.com (qmail-ldap-1.03) with SMTP
          for <gcc-patches@gcc.gnu.org>; 2 Aug 2004 15:43:20 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id A55414F8058; Mon,  2 Aug 2004 09:19:13 -0600 (MDT)
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] libffi/: check mmap() availability explicitly
References: <Pine.LNX.4.58L.0407301757210.23489@blysk.ds.pg.gda.pl>
From: Tom Tromey <tromey@redhat.com>
Reply-To: tromey@redhat.com
X-Attribution:  Tom
Date: Mon, 02 Aug 2004 15:46:00 -0000
In-Reply-To: <Pine.LNX.4.58L.0407301757210.23489@blysk.ds.pg.gda.pl>
Message-ID: <87fz75600e.fsf@fleche.redhat.com>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-08/txt/msg00052.txt.bz2

>>>>> "Maciej" == Maciej W Rozycki <macro@linux-mips.org> writes:

Maciej> 2004-07-30  Maciej W. Rozycki  <macro@linux-mips.org>
Maciej> * acinclude.m4 (AC_FUNC_MMAP_BLACKLIST): Check for <sys/mman.h>
Maciej> and mmap() explicitly instead of relying on preset autoconf cache
Maciej> variables.
Maciej> * aclocal.m4: Regenerate.
Maciej> * configure: Regenerate.

It looks like the intent here was for the explicit checks in
configure.ac to set these variables:

    AC_CHECK_HEADERS(sys/mman.h)
    AC_CHECK_FUNCS(mmap)
    AC_FUNC_MMAP_BLACKLIST

... but IMO relying on autoconf cache variable names is not a very
good practice.  I agree we ought to move these calls into
AC_FUNC_MMAP_BLACKLIST.  Can you re-test with the checks removed from
configure.ac?  If that works for you I will check it in.

Tom