From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id BB28B3858C39 for ; Thu, 9 Nov 2023 20:00:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BB28B3858C39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BB28B3858C39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.137.180 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699560020; cv=none; b=ScKBp2Pfcn0WFXkGhUGyMhmsi03tY0YGXYDMNe4wVxJ1h+8VSCzFnmoHp5Tl4hKQy4XOct2ly/XhxZ/RvrB9kPuc6nZFlnqZD0ORxEqbaF1AVnHblTZZb0Hi68in+AIH9C+iB4RIR/UjNEkn4glEHqAwqQ6TofZhHZHHWS5CoY4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699560020; c=relaxed/simple; bh=91j7jy5yhlqiZW1dO+WylghKBsT0FQUo6Bagto/fV24=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=kfJboXK/jWh4WQ4w6aK9aSJ62VsdZd2sgnd8sqwlXUgJYbBEXyVAk280OpNnCjMMw+6ug1V/hjtQx+iPEtV8BYqmavEEfTDeHO3oPV82jehd2mtbOkO9k1n9WzJ8bfPsxa9nDqETCvIPjQ+pUKNnzB8fU7LQ5klzvw9ZqesWA/o= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: SGGY1mpRQ7KHA4cVweHquA== X-CSE-MsgGUID: bqdjF8vjRguHI31+ErdgcA== X-IronPort-AV: E=Sophos;i="6.03,290,1694764800"; d="scan'208";a="22393942" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 09 Nov 2023 12:00:17 -0800 IronPort-SDR: tja+4huqqqg3eWSEDhMdQOrg6RQqv3TSBodvQg/waoyO9WS3T/X8cpAZZB0D5NM1IkeZ4IqFRY 4ykZJ9tZYNUYxfIyew7eO6/kArE88jC/Ga5VhHgkN/JH3y/Xz6/70YrL6CmdWqkymv+kxylf1j JZDoKILKI9Xsx50USxANy5NGA0zjKtahXIiCAm+FNGi+M7idnsfeUV6FPHFQ0ZgiUpdxdH0yOp YYLv5ID0P6Wc+zpDPJFtKTh3hAr3x4sk+4+P5gjeQs9C9m6XkWqTC6fWl2iVA1BOEa4HmfSsNL xgw= From: Thomas Schwinge To: Robin Dapp CC: , Richard Biener , Andrew Stubbs , Julian Brown Subject: Re: [PATCH] testsuite/vect: Make check more accurate. In-Reply-To: <7cb311dd-d1ae-41d6-bde1-6a0b68a0189d@gmail.com> References: <7cb311dd-d1ae-41d6-bde1-6a0b68a0189d@gmail.com> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Thu, 9 Nov 2023 21:00:06 +0100 Message-ID: <87h6luvgs9.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On 2023-11-07T09:22:16+0100, Robin Dapp wrote: > similar to before this modifies a check so we do only match a > vectorization attempt if it succeeded. On riscv we potentially try > several modes of which some may fail. > > I tested on riscv, aarch64 and x86 but on the cfarm machines > there is no vect_fold_extract_last. Maybe gcn would work? With GCN (tested '-march=3Dgfx906'), I actually see a "regression": PASS: gcc.dg/vect/vect-cond-reduc-4.c (test for excess errors) PASS: gcc.dg/vect/vect-cond-reduc-4.c execution test PASS: gcc.dg/vect/vect-cond-reduc-4.c scan-tree-dump-times vect "LOOP V= ECTORIZED" 2 [-PASS:-]{+FAIL:+} gcc.dg/vect/vect-cond-reduc-4.c scan-tree-dump-times= vect "optimizing condition reduction with [-FOLD_EXTRACT_LAST"-]{+FOLD_EXT= RACT_LAST(?:(?!failed)(?!Re-trying).)*succeeded"+} 2 That's "regression" in quotes as indeed there is no "succeeded": $ grep -C1 'optimizing condition reduction with FOLD_EXTRACT_LAST' -- v= ect-cond-reduc-4.c.176t.vect [...]/source-gcc/gcc/testsuite/gcc.dg/vect/vect-cond-reduc-4.c:19:21: n= ote: vect_is_simple_use: vectype vector(64) int [...]/source-gcc/gcc/testsuite/gcc.dg/vect/vect-cond-reduc-4.c:19:21: m= issed: optimizing condition reduction with FOLD_EXTRACT_LAST. vect_model_reduction_cost: inside_cost =3D 0, prologue_cost =3D 0, epil= ogue_cost =3D 0 . -- [...]/source-gcc/gcc/testsuite/gcc.dg/vect/vect-cond-reduc-4.c:19:21: n= ote: vect_is_simple_use: vectype vector(64) int [...]/source-gcc/gcc/testsuite/gcc.dg/vect/vect-cond-reduc-4.c:19:21: m= issed: optimizing condition reduction with FOLD_EXTRACT_LAST. vect_model_reduction_cost: inside_cost =3D 0, prologue_cost =3D 0, epil= ogue_cost =3D 0 . Gr=C3=BC=C3=9Fe Thomas > gcc/testsuite/ChangeLog: > > * gcc.dg/vect/vect-cond-reduc-4.c: Make check more accurate. > --- > gcc/testsuite/gcc.dg/vect/vect-cond-reduc-4.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-cond-reduc-4.c b/gcc/testsuit= e/gcc.dg/vect/vect-cond-reduc-4.c > index 8ea8c538713..c5aa989ec29 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-cond-reduc-4.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-cond-reduc-4.c > @@ -42,7 +42,7 @@ main (void) > } > > /* { dg-final { scan-tree-dump-times "LOOP VECTORIZED" 2 "vect" } } */ > -/* { dg-final { scan-tree-dump-times "optimizing condition reduction wit= h FOLD_EXTRACT_LAST" 2 "vect" { target { vect_fold_extract_last && vect_pac= k_trunc } } } } */ > +/* { dg-final { scan-tree-dump-times "optimizing condition reduction wit= h FOLD_EXTRACT_LAST(?:(?!failed)(?!Re-trying).)*succeeded" 2 "vect" { targe= t { vect_fold_extract_last && vect_pack_trunc } } } } */ > /* { dg-final { scan-tree-dump-times "optimizing condition reduction wit= h FOLD_EXTRACT_LAST" 4 "vect" { target { { vect_fold_extract_last } && { ! = vect_pack_trunc } } } } } */ > /* { dg-final { scan-tree-dump-times "condition expression based on inte= ger induction." 2 "vect" { target { ! vect_fold_extract_last } } } } */ > > -- > 2.41.0 ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955