From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id E715C3858D1E for ; Tue, 24 Jan 2023 12:25:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E715C3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30OBiG35030253; Tue, 24 Jan 2023 12:25:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=w7/A4BaCUbYVQMWh21zTpZ1a5g5DthS8niwDSMiYX3w=; b=1V167eWF43+zgzz0FTIsWy9A1QP9rU8+k49hetBoaC/Vt5feoHkmgQ2Pdgk/Kx+iXeYJ KHGhw/T1alijGvhsEOQZaf4fEZ4ISeqRN3Y9tkYKhWLJinrLm6i1RKg1B2kMmy2M0yR4 BERl/lJDKAKm8/TmNbODRTyA/X0uII+hUp1jVr2fJGkjacojjEcuE4r1aFQbc6/t23ra 3OL833ffYEMUBqgjj1iNYEc4zUEO+WBYklvi4HAdSx1xUx8g78TGIsL2v9xh82+BGCN+ qVkY3AnDxGLhMRXPk92SA6ynsAsZ/Am37EKr5VEjz9wofxgZGtA2Z5T4i3b8XpRoclTf IQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3n86fcd88x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Jan 2023 12:25:07 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 30OBmnSA029378; Tue, 24 Jan 2023 12:25:06 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3n86gb55dv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Jan 2023 12:25:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lcgsdh/jB7tmQ2kVLyoewUv9NOgWquh5e81C8qXV2NXy7612/iTQLrIXNQ0VYFHJ0LOc0V7hjJkBS7DvEGmf3IA7N0qmQ2ZHhsrsfCu6tnsMU+CluRxKT6NLUOoQxotTgvSI6nPDsvYMRJIKqsu6peLtC6Sj4oiaPdjTz5xXA/uoTh8cCgTH2OIu55HAzVsYkPrE5JrOkVRzx+TDr0kQTKo8tIOFq5i7HH5Gf9KSC385DxUYizknxGZeTaHLo1LuEs8acv2xKOulU5kmby8unrzaxixZpvPUTISxnvO40CtJfLbSRdXN6Ong+xBYUs9X4xqh7qkJEMEssJ7kEuCYpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w7/A4BaCUbYVQMWh21zTpZ1a5g5DthS8niwDSMiYX3w=; b=oJA/B5653CQyZYvY4weBFa2VKqiqf849TtCRgKRKvZ84rlnjcB0I48/sHIviWLIip0xWPH88dXURkRxSVa/uIyE1kkSYi8/xTuE4J1GDDT+Zsk7V2sj4etDZBU7fkYcY8QmTCcyB3rDNhfl0TLuhNaqsjz9CYbvugd6StiOjmxnrR/PblvT4lquy+aAWeF1a3BTDUE8ixi75HPfXaFIKpgjjZVYmaCWljH3I0EcYe/C0AK706+4Sr7o3zTrL2Jiy5lpJVNC5O5uycJEY7GqqIGNo2UVl7qc/CPOaNufxAr62IjkUjeDtIMY2eTV4i9Fo+SkaZ30mesGnt32rxFRTqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w7/A4BaCUbYVQMWh21zTpZ1a5g5DthS8niwDSMiYX3w=; b=VEAhfwTGTTqXSJcX35Hh4+NGzoxIHsVkfNx9PPyoNkp03kSXQOWlMTjpDM/Ei9zGUusgiNjpJ1cpsTnzktUwqudox6uGVeu4cJ5cF+PAwhZXOj20hPZs8Br7ZkSiU8IVvkxCEvf9k5da7q6YMgXUfEGWuyXrkTigRodSq9tqEJA= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by PH0PR10MB4424.namprd10.prod.outlook.com (2603:10b6:510:41::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.17; Tue, 24 Jan 2023 12:25:04 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::2b7a:b98b:e12:b750]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::2b7a:b98b:e12:b750%7]) with mapi id 15.20.6043.007; Tue, 24 Jan 2023 12:25:04 +0000 References: <20221202175225.2780-1-cupertino.miranda@oracle.com> <20221202175225.2780-3-cupertino.miranda@oracle.com> <795fde7f-5bde-d1a5-e790-b15774effd1c@gmail.com> <875yen5ib4.fsf@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: Jeff Law Cc: gcc-patches@gcc.gnu.org, jose.marchesi@oracle.com Subject: Re: [PATCH 2/2] Corrected pr25521.c target matching. In-reply-to: Date: Tue, 24 Jan 2023 12:24:58 +0000 Message-ID: <87h6wg15np.fsf@oracle.com> Content-Type: multipart/mixed; boundary="=-=-=" X-ClientProxiedBy: LO2P265CA0024.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::36) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|PH0PR10MB4424:EE_ X-MS-Office365-Filtering-Correlation-Id: 7fd2fc21-bf8c-4a1f-8510-08dafe06050e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0qn5UX2FhvjqMoj8wAFabQjA168o1PehS5m8CGnSXtlO+O7EamhBlujeuihnx3N3ulijxloFLZOhPEQokiKFUb2hy3hHbe1//Nh/ZCRD8Y4Jomxj0G6yBpmz81GtFlRn+SehLKZFmoLeftMwalGR/tpOOBsKgrJSv7/k8G2zWxLhJPuFw7h1gzyGCrNAYK3YVfZicCRYhFNEwLAWnQfBtm9TYd+ExKDGBaiOH+3DCFCTilJmJ3hPq50JuMGY3op/BSRcZKMyEjOnRrczVpFwoA9Ks1xaej8bfjyMxGgc4WIJ9WYM3mCL326jzJO8NrjR98ocXxgqhDZYzb3Lpo00k7chCGIh7Gi2r4ATtagkT4QhZdejZZHl3cBCY1ULB76d9CnFPCav6lu6aZ3wIjEFplTrSQ/XElUi6dArYkBLTLyp+fYSPSzKlqytZxOw+vYJwGNLoe80IFULrMWTYEyF0BzboPeizAjNNh5PYpQ6kLf/n3/DYlpDdny5rn+HgLyaSR+eI0T1fiqg1RxEJrONp7mWFC4OsMjKZauKgRsmLyDeqCSlc4wiz4Aaw86IJbTtBN01hqfGFNmyPRD62urUfHhy5FJxs3dDHcXI2KirkNUtzAskrhOfvfsjShGmF6zF5JJ+KYwDVXczyfNvg9tMxA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(346002)(396003)(39860400002)(376002)(451199015)(86362001)(36756003)(316002)(8676002)(6916009)(66946007)(4326008)(6512007)(53546011)(66556008)(66476007)(186003)(6666004)(107886003)(478600001)(6506007)(2616005)(6486002)(38100700002)(41300700001)(83380400001)(8936002)(2906002)(5660300002)(44832011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7tRQ2/4eLedJ6DvwRdtVSBIP7wpeWbtzIdBz53gxqhGAR4PUfPkf7RrJYdim?= =?us-ascii?Q?wpOhR59T2IXWLS9k7bzJxrSnSJOcKC6h3wMyy39ox2dPKQ7AJlugep3g0iOK?= =?us-ascii?Q?Hv4GmMD/gcIaeN+Ik7UJDxGAnk7z10n1DbmrFjRRJf/MBqh9yig0RibUH2F1?= =?us-ascii?Q?wb9fHtBy9ue15KRxxku9XhnvqO9empKC+usKl/vg/nZcKJtmCY/VgmPjV3Xd?= =?us-ascii?Q?UeSOYZLWaOuU4Um6jkkZGeQE58QRfN18Nj4XqdoMIbd1jEQ7YjJWgvShQ+k3?= =?us-ascii?Q?YmmptoG0h1BgPGgYHwe4QseGUkAiT+ru9PqXDLp22waEIkqSZbr8/FAnQyc+?= =?us-ascii?Q?BuyCh39f4UUx8tTS/Wig35Sk7tbpKm7kHtBMzjJ4IxYy5kFEuVp3nfKcRFIO?= =?us-ascii?Q?iuAJbQWPg/vrcUvrD0zQ4bLlaHcLKABpqVOTt91hqBL39t1kRWoHMIa53MN8?= =?us-ascii?Q?ciIwMo5IPBj/qiV8Eb5WHsA965wngEkEMj2tWZXEHcWSCIFfhaHGHZtMwg1z?= =?us-ascii?Q?SLD2loEUL+Og6GtBKjsSL7/SSXB82W/ABkJpbLNHJBYuSil+yo0M8xteppnk?= =?us-ascii?Q?Zgj52KrEWLTkUW1L5XIAAm2aYT2JQxWLWe3CQzPqsVSfTXCOYgeOub4oXi7q?= =?us-ascii?Q?90zHcR4+uOcrdq4xMxnG9K0wX4hYM3NGqPicyxwOhmzDjmlo2dVYE5F9yDmi?= =?us-ascii?Q?cyOS5pEamkxA5Zi5ybGBkEPoADF6vtWwlbHed6T0AM3Fg2GDHHkw73VFSVNp?= =?us-ascii?Q?Q9SF8TA6UkccXkxt6nwKJosiLGRzVmwEN1tF3x0A3ciYvln8LBxf7UbYPlO3?= =?us-ascii?Q?hFQgXjOCSnjM2942R6piUziqQHbFbAeaHwHr0TcrzMStnCfxv3Gbp0vcX8LU?= =?us-ascii?Q?dEGAEPCEdxPDRc4KL6M3lGCCaGjsnuOHNS7s96oK65ol3gcmpf3E/nBEUQa/?= =?us-ascii?Q?UUofJmPfN6lgMK6A//8HAgTXajlCK1/2+o7ggiSkAT0qS+prZ2wetzm4PfYu?= =?us-ascii?Q?c4rqCUvyaeVFmu35dvOqAzKK8W03IEgrIiHwMTyPDuIMP+h6jNP7b0pNFGuB?= =?us-ascii?Q?G15+MjpTX7bwOGq+NB02Jn54rpgINsjgxEfpRXQnvtOs5stEoN8Xijmi0lqa?= =?us-ascii?Q?JVtuUAoqyDM87tMMYuyadXOqvk2WpdhtL/jHqeVGpt4Ga7mHGpqmy0K42xzC?= =?us-ascii?Q?5eDr/8KeITnZTq1jiY1zsty2w9Uxm76cZv/za+vXW6C7OR3zi9FCNFo/WGo0?= =?us-ascii?Q?gl+Afm6SHatdvzudo1xVh30zA6IL91zBmfdHbaO3zG8g72viH3rNIBunoh7A?= =?us-ascii?Q?1b3oJbG7cn/p00rqdGdzjAzdYP4WR4K477wpxcaUUUhCafxXV4K5wAF8uiOQ?= =?us-ascii?Q?yWGaPGCllrUBeLKBxPtacVscHOlW0JtTgVNSkRhBMbu0kSQlRl/rR5f0guex?= =?us-ascii?Q?j/Ax7+SGsCOciLJLXDvo12BFzcAeRNageeVIl9zSW4SqQWTaxeJOAcvUoC7z?= =?us-ascii?Q?kPkOeXA6P+mj+BlRDqeIGvONkMRsmOJlisCSJhFX98AgHir5Ml3mrYBAFZhR?= =?us-ascii?Q?/1xJnxl3MjvQYOSXdzLrNLlYcp65x0OpfHtGrC7gmysvs+cUOr/0C3FjTM5O?= =?us-ascii?Q?HNPEOAk0QTxmTL0V1JVooGi4UjWYwsuX1oSrdkIvL9PB?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6+/zrZnovk6IfVu2m3hoXpQivaFcpWAdJdozWnJjHPOJreJCE+mMKjsOs3z5rede4hB3Lxt/QsT2kl2kqOGZKC0z5WNt9NS9DLzR1QrfFpcjx66K4MXs1mPMLQvJzPEclCRYwr2ICTNJp6yDdSlw2jIAEDtU+sgyEc0/17WiB+cTMKUDXCk6conNzXuGOqZMZkDFW4CHFHAeYdP8+bkwDuSy4S471R6LreaUUPssaBvzfj0QDFpj/zS/hjwTuj849KnSmrPGnqLczKG9CBPZSTNzwBeJWjoa/Wlo1uEnNe7Ro0IiMlBsNQAYZtpvBWlpo5v0s3ecpp8xnG6ocMlsaZDhnFFmHA6KP5itUNo8uuQb167WLETUnDvlSnRet9CCDGOLpa44iPuR3m/uZWp+y/MTlAzv03NFSnQ2Anc/71aLBWvT+5Xc5Wf8+uJWAPs0jTAmvtDvQcbrIoBoJwsYoSc1YZNps0bh8shMsCM962rjZxuwEyTuycUm7W/E+mpJA5fOMHaW/nbguF6ZORv9sOHBrfNygf8Xanwnw5teXjvbDntFTGK9HClAmJaqAi7EHLgZCSy9VGI1FlaNN3KNgUxrDEupFausMXUKpE7i7hiPjWgfIq5roWAC0cC8dECV6oY+fLgCD5ukVc8/CpK2ZRB9vv2RJwHAeeIih+w3D3gB3EkT2N+aMOduHMKLe5GeJV0r4Ckhupy7NTK7q2ETPyLK/w2AW41X2FD054OkmkZmfwm3ptX7feN/ATmKawcyTNKEIWRUowyzU9QIKV+9FQ== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fd2fc21-bf8c-4a1f-8510-08dafe06050e X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 12:25:03.7724 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nE68Ty6Ycho6MmiP0580FU5mco3jvQH5e2tTQSNLRLP13m6wMOARpTGe5b3zGG+ZUx1bnf66bcDZ595rBjN/faB8lYHAwdkHNt/sxSxQqnY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4424 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-23_12,2023-01-24_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxlogscore=999 adultscore=0 mlxscore=0 suspectscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301240114 X-Proofpoint-GUID: Hg53Soq9G2bhvreGhgohKkYdF2yekWQy X-Proofpoint-ORIG-GUID: Hg53Soq9G2bhvreGhgohKkYdF2yekWQy X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain Thank you for the comments and suggestions. I have changed the patch. Unfortunately in case of rx target I could not make scan-assembler-symbol-section to match. I believe it is because the .section and .global entries order is reversed in this target. Patch in inlined below. looking forward to your comments. Cupertino --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=a.patch diff --git a/gcc/testsuite/gcc.dg/pr25521.c b/gcc/testsuite/gcc.dg/pr25521.c index 63363a03b9f..82b4cd88ec0 100644 --- a/gcc/testsuite/gcc.dg/pr25521.c +++ b/gcc/testsuite/gcc.dg/pr25521.c @@ -2,9 +2,10 @@ sections. { dg-require-effective-target elf } - { dg-do compile } */ + { dg-do compile } + { dg-skip-if "" { ! const_volatile_readonly_section } } */ const volatile int foo = 30; - -/* { dg-final { scan-assembler "\\.s\?rodata" } } */ +/* { dg-final { scan-assembler {.section C,} { target { rx-*-* } } } } */ +/* { dg-final { scan-assembler-symbol-section {^_?foo$} {^\.(const|s?rodata)} { target { ! "rx-*-*" } } } } */ diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index c0694af2338..91aafd89909 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -12295,3 +12295,13 @@ proc check_is_prog_name_available { prog } { return 1 } + +# returns 1 if target does selects a readonly section for const volatile variables. +proc check_effective_target_const_volatile_readonly_section { } { + + if { [istarget powerpc-*-*] + || [check-flags { "" { powerpc64-*-* } { -m32 } }] } { + return 0 + } + return 1 +} --=-=-= Content-Type: text/plain Jeff Law writes: > On 12/7/22 08:45, Cupertino Miranda wrote: >> >>> On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote: >>>> This commit is a follow up of bugzilla #107181. >>>> The commit /a0aafbc/ changed the default implementation of the >>>> SELECT_SECTION hook in order to match clang/llvm behaviour w.r.t the >>>> placement of `const volatile' objects. >>>> However, the following targets use target-specific selection functions >>>> and they choke on the testcase pr25521.c: >>>> *rx - target sets its const variables as '.section C,"a",@progbits'. >>> That's presumably a constant section. We should instead twiddle the test to >>> recognize that section. >> Although @progbits is indeed a constant section, I believe it is >> more interesting to detect if the `rx' starts selecting more >> standard sections instead of the current @progbits. >> That was the reason why I opted to XFAIL instead of PASSing it. >> Can I keep it as such ? > I'm not aware of any ongoing development for that port, so I would not let > concerns about the rx port changing behavior dominate how we approach this > problem. > > The rx port is using a different name for the section. That's valid thing to > do and to the extent we can, we should support that in the test rather than > (incorrectly IMHO) xfailing the test just becuase the name isn't what we > expected. > > To avoid over-eagerly matching, I would probably search for "C," I wouldn't do > that for the const or rodata sections as they often have a suffix like 1, 2, 4, > 8 for different sized rodata sections. > > PPC32 is explicitly doing something different and placing those objects into an > RW section. So for PPC32 it makes more sense to skip the test rather than xfail > it. > > Jeff --=-=-=--