From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 9A22E3858427 for ; Fri, 26 Aug 2022 15:46:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9A22E3858427 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27QDcl32026684; Fri, 26 Aug 2022 15:46:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2022-7-12; bh=jUfWkcqm1KXlhlopk5T5ediFfKjN4uIskgovnEYCZvE=; b=uoONS9kw06yYGcPaRt61c9ow4/0v7Qyxq3uPFI2z8uWNBAUCgeUTGUO9Odt9YbXiPBH2 tO7uTGTKl8N7mycnD0pdrCYkvcDIGMtYuHL4QInu5kZhoQKNdVQDRZ5TkJE2AkmUnZP6 drZ63njdyy2Y/jCWBipD6QUzWaY++FOmXsf21yPYVCOlS1V6qIVVTy+e4p2uZufR9BKP 8yxcMM5gS20Fv0IHu9H5VgSo6lbpwKF2pnQItHw6rYvjn1po/IlxUzwv8zEIOCZ2YaQQ 0G8ZcckBWNZ1t2+YnB6kCPWEf9mbdVQapXWB+C57u+jtfJY4dbIjQp9qWxGQFmPU0koI nw== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3j5aww7duq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Aug 2022 15:46:22 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 27QDqI8K028237; Fri, 26 Aug 2022 15:46:21 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3j5n4nyxkq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Aug 2022 15:46:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cxPEUp6x4n6uMpuENGxmXq0eJltpq4SlWaA+c8Vve8S2BfPPDhwMbKp+DcjJbo8CI2Mt4aNWuWZgCy/XWQJymc0oTatZneWFfvht8ZHT6BXxWm8ftNwHT6zikJoMWfMLUFmoz1lj7+VY8cFGKZhAPVUfgOQRz/QxAeXQqbV7VfodH2KNX567X23vOrT8aZO8b6UB8hQj9McfuQ3IH6KGSYP+YYhKNcf5HO3eyVscMsRpBZBtJsTSnK3K6HoNx6/BfWhstLE9c/lYOVaZqCDDJpmM2FW98TVOgLWuPLePUDwlFABlp/pu1uD8KnlM+v5xGHRUgeM+obc7YC7XV6D15w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jUfWkcqm1KXlhlopk5T5ediFfKjN4uIskgovnEYCZvE=; b=jAX2JXOefE00NI1WpKE7P+aQEANVjbYnrQS+Y2P7q85speD9gT5TKWuZi05XEQkmd9ZphxlVPpSEzwtE7dkWjg8K/M+wjLycEjnYLyahu+G6ebi31heQVnm0uMu9TgjF1AngUzQCztxzryUTpjy9/JqeX5F5aycO7Oah63Pvx5e5kKva7JWJo3GQbDh4YJYdL++fQuGpTG1F6xd58p+dWxTwqpqMqancbeSO3/4onyAYVxB1YkoHEuewoX9BivuH39i83QoZcKe+fDLK+TD12xWd5SGiN8ec/tN0GeE5QNqcArYmB8iN2yLzFQXsl8sML+RnJpAAjn2mRueB1XQE+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jUfWkcqm1KXlhlopk5T5ediFfKjN4uIskgovnEYCZvE=; b=nb4TYw+DDTSK7Jbz9IVYbYH9VKXnurJGukK7rgRZSfRXYxX0Ehvv5rTQakCC0sUMXFUpiWhBaAo+cj4OI6s1CTTc14pKYRkaJvzQbVbz73NfLyfSEvNRcDtMVBSvnLRDIVtfYj7OGvhXMGXLRU8SmReQdYp9d4euS2mhyHCI+Ns= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by MN2PR10MB3696.namprd10.prod.outlook.com (2603:10b6:208:11a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.21; Fri, 26 Aug 2022 15:46:18 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::6440:83d5:754:2daf]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::6440:83d5:754:2daf%5]) with mapi id 15.20.5546.023; Fri, 26 Aug 2022 15:46:18 +0000 From: "Jose E. Marchesi" To: Joseph Myers Cc: Subject: Re: [PATCH V2] Add warning options -W[no-]compare-distinct-pointer-types References: <87mtciu23z.fsf@oracle.com> <87a681d7tf.fsf_-_@oracle.com> Date: Fri, 26 Aug 2022 17:45:52 +0200 In-Reply-To: (Joseph Myers's message of "Thu, 18 Aug 2022 15:34:15 +0000") Message-ID: <87h71zdn4f.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LNXP265CA0008.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::20) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 492509db-49ef-4278-0279-08da877a1d7c X-MS-TrafficTypeDiagnostic: MN2PR10MB3696:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pqe6hYO8l20eJlAiMPseG2Fe2ET3f9tNyegsC1ie8H5a1ret3wUR21tFnTthHZ3UBfCPbgeaW2r6BTiFdSibwBi3Yma0/AHq9/12teaKPP6piHQgmiGopBthxG/AqsQJo8y77hEOAsskBEOC3AhQe89KvLkqMswoxLn4VgLqUMQrAJqfNEZDF45K/Cgmg16TAIPEoclzQqqg6HItNvT5TkksCpCjh0cBmeVxA8GVMyVR5caTYWbxYpUjUW4WMpkQvMF1vUZqANKXEgLWksrC3UlNgRawYIS3Zx/Dbs55YdhbNIcXzLAmX4hk8gj+5ksgevKh6CVMsAg9Bn/ZR4r/TZXAmdu/NiDCuCC1dKs6hZ61zowbszHnvjYSXp8s1fqAcVWTEcIHHcEoEm2BU+nBgTj2Wms2r3ygVDBPk4kndXSGR7G1DpGFtFNMXgQ7RS1s+yXn7A4kBK1djvT9qP8F97h1HNZ9UOUiPWsFyz/nwh9nk5j4aPizwzfKQRAfBXUjitFJxK4ohFZ+uBbOi3+DONNxpQyjbXwXzsx79RJDfEM4snA4wH8adC+5tru3Nr71tYQk8fq+vcBDGiOdItwCg+ULHU2dy4SSwZ3dq/c7dimX6XIUVqpKLBQoTIr3as9xC2qHo5D7YxlOgttfaQPUM70oVW4JsR2oxZVqIgUv44gMbLQWdjQXF0ps7M8k0vnuKajLSHKEe2DvdVdWz9WUrg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(346002)(366004)(376002)(136003)(2616005)(186003)(38100700002)(83380400001)(8936002)(5660300002)(4326008)(26005)(66946007)(66556008)(66476007)(8676002)(2906002)(41300700001)(478600001)(6486002)(6666004)(6506007)(6512007)(6916009)(316002)(36756003)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?t98L3aKo448XNiQlUe4R2Gpev6JzXuVPSYuCnDZwIHlcQIg5BHHZ2MoRD/x1?= =?us-ascii?Q?mRqg7Wtz5a3gPi7ioIhVfWWfSRZB2rmZjBxlfrxtPKpZesyX4GTwllvBPKoe?= =?us-ascii?Q?KemRH9lCvkAuuA9IjEnIbSLQG0uo3mb4P8s6Gf5jv7U7IoHdDrO/LYhSI3w+?= =?us-ascii?Q?f1WchmWenSJimifSZ7dcrRP6V+sD9DlkauDS0bcAAJN+sfPA1za0jymlBZDL?= =?us-ascii?Q?1+gqG0ZqD2j0/PhjIY5eVFAc5L8AhwKmwouz8F0wM2cHAdQhS2/H4NsTHoR+?= =?us-ascii?Q?9iH8l1TmlBoHCjyvtsR7rY7AvKI7LT1Sarb6MxoB9XdedegGE9N62TiwgySD?= =?us-ascii?Q?SoYEBar5BPZCGlF1E4MhmVS242qEMvs1g3yw4QbwFe1l3JBoAsruHoyX5oB7?= =?us-ascii?Q?s6f06H2hmKG6EQPQTc5USaprbuTGE2eMIVuuczPXiObbD7CElsrC4RaaCE0n?= =?us-ascii?Q?rzyyytzqaSl1XFmDWJXQ94wAMuixnfyjM3RfiFPeqwKYunHcT+ELPJ1FyaM9?= =?us-ascii?Q?f1gxJmYQ9ViA8JJbP6b2LZqlTHBWDr6gK/HETJ0nFkR74tw2Y2uSL3K76k7J?= =?us-ascii?Q?ELkdymIXT5wluuZe48R9OYv1cLF/aWLStWIVL5TiIAPWvPJNX6XJkiyH1QPa?= =?us-ascii?Q?aTpvn6eWZ/yVjd21n6/g933PZi9y9WWteCgfAksIscsB7W6wnS4xaQ3X4JJa?= =?us-ascii?Q?ZSjSR4y/dmqB0DfRwU7dvfBf16SCvXZWxMsqdZDg7VEhQsLSaOyVVXZ7OEbQ?= =?us-ascii?Q?foYC2aHIhVbRqTXSVPHcgV4rl3xgRlFU+ZhKgyIA+MLwS1XezHrcgzMW88rV?= =?us-ascii?Q?cR4hKX0rbnGOtU4SRVqYRzw0MnlVrV/YjyPdsvuJJYbMKeRIbjn/nAsQH3I+?= =?us-ascii?Q?QhWETVtxXw2FPWGLmn4L18EBhG8HeMZbNJiS9JnAJgkjNrprgN0kOGgTN7LN?= =?us-ascii?Q?vYyxj++V+mxy9H2nfD7xFGIdOCmcXoOUSAbd2ZS2fwWBZFl1uZ0yfk2uhYkP?= =?us-ascii?Q?fSSye4mfVCS/pVa078jLx9AwidT3XnoT/6ZqIm77pm0slxNixrNgmKev/L7z?= =?us-ascii?Q?QUYRaXL/haFtZK+8t+UvJLjY2Q3qwdvffErrxHDoLwLUbzN7di6i2fAAu1vG?= =?us-ascii?Q?ZnHme3ttORwtLLTsgq2rCIWmqhQsh78B4EAfnqAy4pzb3aVTfTOw/p1PCSR1?= =?us-ascii?Q?zWiLGNhHnqY0WDry0XVpZ5sshsxfDtQTURWD/9JwxS4acjH9df7bY1gDU2LW?= =?us-ascii?Q?MXT64X0B0YpFys4Prc9BYtYke2iSGzmApTvpAu7Rz8GcOyEIKiLBten9IbGm?= =?us-ascii?Q?B/dFKsd8NlyaqQmRLnm2Ga9UA6DlqtcXDzD/dZGtoxOGX6DtWEEAeIWShqoA?= =?us-ascii?Q?jp/lNXw4xG7uIgQC7+mJRx9uebqc+zICB0TYlAwVMobioMYmkmGZYoOczQPj?= =?us-ascii?Q?0U5nplK+nWg5CzACmFi+CSqNe+Mke502YtBXJQPRfblJWGCYo0IVDPavnxD9?= =?us-ascii?Q?2/Iww0NqZcBpO0nA3NCAE9nz8yE3ZK9ZK6nSDojN+2KswOSqP7sKg9U/VMjK?= =?us-ascii?Q?jhn39zKMcQsBqWGLNMy+V1fsDVJ+ZFey0yOL3NImj8SEhT1ztYury6mQTxmE?= =?us-ascii?Q?RQ=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 492509db-49ef-4278-0279-08da877a1d7c X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2022 15:46:17.9428 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R6xK18UvICPNdWTX+LHcvpuwlWfHoVSg0QQf4ZxNQi13t2daFkIvHT/soi8hsYIajZS/OXD8z8itESOHdxAboNicGE5U3DMH21bXTcoPsK4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3696 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-26_08,2022-08-25_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 phishscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208260064 X-Proofpoint-GUID: OkcTVLqei5OI4WDwfIuYtU3uzhZl_uXA X-Proofpoint-ORIG-GUID: OkcTVLqei5OI4WDwfIuYtU3uzhZl_uXA X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On Thu, 18 Aug 2022, Jose E. Marchesi via Gcc-patches wrote: > >> diff --git a/gcc/c/c-typeck.cc b/gcc/c/c-typeck.cc >> index de8780a1502..04af02add37 100644 >> --- a/gcc/c/c-typeck.cc >> +++ b/gcc/c/c-typeck.cc >> @@ -12397,7 +12397,8 @@ build_binary_op (location_t location, enum tree_code code, >> } >> else >> /* Avoid warning about the volatile ObjC EH puts on decls. */ >> - if (!objc_ok) >> + if (!objc_ok >> + && warn_compare_distinct_pointer_types) >> pedwarn (location, 0, >> "comparison of distinct pointer types lacks a cast"); >> >> @@ -12517,8 +12518,9 @@ build_binary_op (location_t location, enum tree_code code, >> int qual = ENCODE_QUAL_ADDR_SPACE (as_common); >> result_type = build_pointer_type >> (build_qualified_type (void_type_node, qual)); >> - pedwarn (location, 0, >> - "comparison of distinct pointer types lacks a cast"); >> + if (warn_compare_distinct_pointer_types) >> + pedwarn (location, 0, >> + "comparison of distinct pointer types lacks a cast"); > > I think this should use OPT_Wcompare_distinct_pointer_types in place of 0, > and then you shouldn't need to check warn_compare_distinct_pointer_types > (as well as the diagnostic then automatically telling the user what option > controls it). Ouch, better to use pedwarn the way it is intended to be used yes. Sorry for the silly overlook :) Sending a V3 with this modification.