From: Thomas Schwinge <thomas@codesourcery.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: <gcc-patches@gcc.gnu.org>, Cesar Philippidis <cesar@codesourcery.com>
Subject: Re: Fix OpenMP's target update directive in templated code
Date: Wed, 29 Apr 2015 09:30:00 -0000 [thread overview]
Message-ID: <87h9rzs2sa.fsf@schwinge.name> (raw)
In-Reply-To: <20150429085332.GC1751@tucnak.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
Hi Jakub!
On Wed, 29 Apr 2015 10:53:32 +0200, Jakub Jelinek <jakub@redhat.com> wrote:
> On Tue, Apr 28, 2015 at 08:45:50PM +0200, Thomas Schwinge wrote:
> > I guess nobody so far ;-) has been using OpenMP's target update directive
> > in templated code -- OK to commit the following, and to which branches
> > (4.9, 5, trunk)?
>
> Seems I've missed testcases for target {,update,data} in templates indeed,
> generally for C++ I'm trying to add testcases for templates, both when
> relevant types are type dependent and whey aren't.
>
> > gcc/cp/
> > * pt.c (tsubst_expr) <OMP_TARGET_UPDATE>: Use
> > OMP_TARGET_UPDATE_CLAUSES instead of OMP_CLAUSES.
> > gcc/testsuite/
> > * g++.dg/gomp/tpl-target-update.C: New file.
>
> This is ok for trunk, 5.2 and 4.9.3, thanks for fixing that.
Committed in r222564, r222565, r222566, respectively.
Grüße,
Thomas
[-- Attachment #2: Type: application/pgp-signature, Size: 472 bytes --]
next prev parent reply other threads:[~2015-04-29 9:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <553E695A.2070007@mentor.com>
[not found] ` <87zj5ttqpz.fsf@schwinge.name>
[not found] ` <553E787A.1020109@mentor.com>
2015-04-28 19:30 ` Thomas Schwinge
2015-04-29 9:00 ` Jakub Jelinek
2015-04-29 9:30 ` Thomas Schwinge [this message]
2015-04-29 9:32 ` OMP_CLAUSES with clauses in operand 0 (was: Fix OpenMP's target update directive in templated code) Thomas Schwinge
2015-04-29 10:06 ` Jakub Jelinek
2015-04-29 11:14 ` OMP_CLAUSES with clauses in operand 0 Thomas Schwinge
2015-04-29 11:55 ` Jakub Jelinek
2015-04-29 14:37 ` Thomas Schwinge
2015-04-29 14:52 ` Jakub Jelinek
2015-04-29 15:46 ` Thomas Schwinge
2015-04-29 16:04 ` Jakub Jelinek
2015-04-29 16:07 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9rzs2sa.fsf@schwinge.name \
--to=thomas@codesourcery.com \
--cc=cesar@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).