From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
To: David Faust <david.faust@oracle.com>
Cc: gcc-patches@gcc.gnu.org, cupertino.miranda@oracle.com
Subject: Re: [PATCH] bpf: fix zero_extendqidi2 ldx template
Date: Thu, 15 Feb 2024 13:37:17 +0100 [thread overview]
Message-ID: <87il2pkio2.fsf@oracle.com> (raw)
In-Reply-To: <20240214231700.12428-1-david.faust@oracle.com> (David Faust's message of "Wed, 14 Feb 2024 15:17:00 -0800")
Hi Faust.
OK, thank you.
> Commit 77d0f9ec3809b4d2e32c36069b6b9239d301c030 inadvertently changed
> the normal asm dialect instruction template for zero_extendqidi2 from
> ldxb to ldxh. Fix that.
>
> Tested for bpf-unknown-none on x86_64-linux-gnu host.
>
> gcc/
>
> * config/bpf/bpf.md (zero_extendqidi2): Correct asm template to
> use ldxb instead of ldxh.
> ---
> gcc/config/bpf/bpf.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md
> index 080a63cd970..50df1aaa3e2 100644
> --- a/gcc/config/bpf/bpf.md
> +++ b/gcc/config/bpf/bpf.md
> @@ -292,7 +292,7 @@ (define_insn "zero_extendqidi2"
> "@
> {and\t%0,0xff|%0 &= 0xff}
> {mov\t%0,%1\;and\t%0,0xff|%0 = %1;%0 &= 0xff}
> - {ldxh\t%0,%1|%0 = *(u8 *) (%1)}"
> + {ldxb\t%0,%1|%0 = *(u8 *) (%1)}"
> [(set_attr "type" "alu,alu,ldx")])
>
> (define_insn "zero_extendsidi2"
prev parent reply other threads:[~2024-02-15 12:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 23:17 David Faust
2024-02-15 12:37 ` Jose E. Marchesi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il2pkio2.fsf@oracle.com \
--to=jose.marchesi@oracle.com \
--cc=cupertino.miranda@oracle.com \
--cc=david.faust@oracle.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).