From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by sourceware.org (Postfix) with ESMTPS id 854593858C54 for ; Wed, 26 Apr 2023 21:10:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 854593858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Q6BMt3YLfz1s94s; Wed, 26 Apr 2023 23:10:02 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Q6BMt2PKbz1qqlS; Wed, 26 Apr 2023 23:10:02 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id MG2OHM3sUG62; Wed, 26 Apr 2023 23:10:01 +0200 (CEST) X-Auth-Info: bg8xMIcUlYogzBmczDyNTClC01RvjZmMoajusplc/wrCDHmbj1mL8jVcY4FrFsxI Received: from igel.home (aftr-82-135-86-255.dynamic.mnet-online.de [82.135.86.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 26 Apr 2023 23:10:01 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 2D1BC2C1581; Wed, 26 Apr 2023 23:10:01 +0200 (CEST) From: Andreas Schwab To: Patrick O'Neill Cc: gcc-patches@gcc.gnu.org, rep.dot.nop@gmail.com, jeffreyalaw@gmail.com Subject: Re: [PATCH] RISC-V: Fix sync.md and riscv.cc whitespace errors In-Reply-To: <20230426205349.1131469-1-patrick@rivosinc.com> (Patrick O'Neill's message of "Wed, 26 Apr 2023 13:53:49 -0700") References: <20230426205349.1131469-1-patrick@rivosinc.com> X-Yow: Is this my STOP?? Date: Wed, 26 Apr 2023 23:10:01 +0200 Message-ID: <87ildi2vva.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,MEDICAL_SUBJECT,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Apr 26 2023, Patrick O'Neill wrote: > @@ -290,10 +290,10 @@ > [(set (match_operand:GPR 0 "register_operand" "=&r") > (match_operand:GPR 1 "memory_operand" "+A")) > (set (match_dup 1) > - (unspec_volatile:GPR [(match_operand:GPR 2 "reg_or_0_operand" "rJ") > - (match_operand:GPR 3 "reg_or_0_operand" "rJ") > - (match_operand:SI 4 "const_int_operand") ;; mod_s > - (match_operand:SI 5 "const_int_operand")] ;; mod_f > + (unspec_volatile:GPR[(match_operand:GPR 2 "reg_or_0_operand" "rJ") > + (match_operand:GPR 3 "reg_or_0_operand" "rJ") > + (match_operand:SI 4 "const_int_operand") ;; mod_s > + (match_operand:SI 5 "const_int_operand")] ;; mod_f That appears to be a bug in the checker. This isn't a C array expression, but an argument in lispy vector notation, so it should be separated by a space. > @@ -431,15 +431,15 @@ > }) > > (define_insn "subword_atomic_cas_strong" > - [(set (match_operand:SI 0 "register_operand" "=&r") ;; old value at mem > - (match_operand:SI 1 "memory_operand" "+A")) ;; mem location > + [(set (match_operand:SI 0 "register_operand" "=&r") ;; old value at mem > + (match_operand:SI 1 "memory_operand" "+A")) ;; mem location > (set (match_dup 1) > - (unspec_volatile:SI [(match_operand:SI 2 "reg_or_0_operand" "rJ") ;; expected value > - (match_operand:SI 3 "reg_or_0_operand" "rJ")] ;; desired value > + (unspec_volatile:SI[(match_operand:SI 2 "reg_or_0_operand" "rJ") ;; expected value > + (match_operand:SI 3 "reg_or_0_operand" "rJ")] ;; desired value Likewise. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."