Hi! On 2021-12-13T14:12:26-0500, David Malcolm wrote: > On Mon, 2021-12-13 at 10:53 -0700, Martin Sebor via Gcc-patches wrote: >> On 12/10/21 3:42 PM, Thomas Schwinge wrote: >> > OK to push the attached "testsuite: Be more informative for ICEs"? >> >> Adding more detail here seems like a useful improvement to me. > > Agreed. Thanks, and given Jeff's approval, now pushed to master branch in commit 45b768cb80930c0beeb735727349c44ec66f7dd2 "testsuite: Be more informative for ICEs", see attached. > I don't think I can formally approve this patch, but it looks > like a big improvement to me, too. Well, for some meaning of "big improvement" anyway... ;-) But yes, certainly useful when you've (that is: I've) been comparing for a while DejaGnu '*.sum' files before/after a source code change, wondering why ICEs don't go away and only eventually realized that ICEs indeed do go away -- but just to be replaced with other ICEs. That's now becoming obvious. > Does it identify assertion failures, BTW? Some of the examples I have in the commit log actually are that, for example, for 'gcc/cp/constexpr.c': 6954 gcc_checking_assert (ctx->quiet || errorcount); ... we get: [...]/source-gcc/gcc/testsuite/g++.dg/cpp1z/constexpr-lambda26.C: In lambda function: [...]/source-gcc/gcc/testsuite/g++.dg/cpp1z/constexpr-lambda26.C:14:35: internal compiler error: in cxx_eval_constant_expression, at cp/constexpr.c:6954 0x675604 cxx_eval_constant_expression [...]/source-gcc/gcc/cp/constexpr.c:6954 0xdfcfb5 cxx_eval_call_expression [...]/source-gcc/gcc/cp/constexpr.c:2398 [...] ..., and my simple patch just captures the 'internal compiler error: [...]' part and uses it as follows: -XFAIL: g++.dg/cpp1z/constexpr-lambda26.C -std=c++17 (internal compiler error) +XFAIL: g++.dg/cpp1z/constexpr-lambda26.C -std=c++17 (internal compiler error: in cxx_eval_constant_expression, at cp/constexpr.c:6954) Grüße Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955