From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120231 invoked by alias); 6 Aug 2018 13:15:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 120177 invoked by uid 89); 6 Aug 2018 13:15:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,SPF_PASS autolearn=no version=3.3.2 spammy=harness, observed, ensuring, U*alan.hayward X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Aug 2018 13:15:43 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D6F4E15A2; Mon, 6 Aug 2018 06:15:41 -0700 (PDT) Received: from localhost (unknown [10.32.98.51]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0CAB03F2EA; Mon, 6 Aug 2018 06:15:40 -0700 (PDT) From: Richard Sandiford To: Alan Hayward Mail-Followup-To: Alan Hayward ,gcc-patches@gcc.gnu.org, nd@arm.com, richard.sandiford@arm.com Cc: gcc-patches@gcc.gnu.org, nd@arm.com Subject: Re: [PATCH v2 7/7] Enable clobber high for tls descs on Aarch64 References: <20180726091329.26875-1-alan.hayward@arm.com> <20180726091329.26875-8-alan.hayward@arm.com> Date: Mon, 06 Aug 2018 13:15:00 -0000 In-Reply-To: <20180726091329.26875-8-alan.hayward@arm.com> (Alan Hayward's message of "Thu, 26 Jul 2018 10:13:29 +0100") Message-ID: <87in4n7i10.fsf@arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00400.txt.bz2 Alan Hayward writes: > Add the clobber high expressions to tls_desc for aarch64. > It also adds three tests. > > In addition I also tested by taking the gcc torture test suite and making > all global variables __thread. Then emended the suite to compile with -fpic, > save the .s file and only for one given O level. > I ran this before and after the patch and compared the resulting .s files, > ensuring that there were no ASM changes. > I discarded the 10% of tests that failed to compile (due to the code in > the test now being invalid C). > I did this for O0,O2,O3 on both x86 and aarch64 and observed no difference > between ASM files before and after the patch. > > Alan. > > 2018-07-25 Alan Hayward > > gcc/ > * config/aarch64/aarch64.md: Add clobber highs to tls_desc. > > gcc/testsuite/ > * gcc.target/aarch64/sve_tls_preserve_1.c: New test. > * gcc.target/aarch64/sve_tls_preserve_2.c: New test. > * gcc.target/aarch64/sve_tls_preserve_3.c: New test. Like you were saying off-line, these should be in the aarch64/sve/ directory. Files there don't specify an -march* option, since the harness adds one if necessary. OK with that change, thanks. Richard