From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51410 invoked by alias); 16 Mar 2018 13:50:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 51400 invoked by uid 89); 16 Mar 2018 13:50:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=H*F:U*thomas X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Mar 2018 13:50:38 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=svr-ies-mbx-01.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1ewpkh-0003be-DT from Thomas_Schwinge@mentor.com for gcc-patches@gcc.gnu.org; Fri, 16 Mar 2018 06:50:35 -0700 Received: from hertz.schwinge.homeip.net (137.202.0.87) by svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Fri, 16 Mar 2018 13:50:32 +0000 From: Thomas Schwinge To: Cesar Philippidis CC: Tom de Vries , "gcc-patches@gcc.gnu.org" Subject: Re: [og7] vector_length extension part 5: libgomp and tests In-Reply-To: References: User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 16 Mar 2018 13:50:00 -0000 Message-ID: <87in9wdt96.fsf@hertz.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-03/txt/msg00793.txt.bz2 Hi! On Fri, 2 Mar 2018 12:47:23 -0800, Cesar Philippidis wrote: > The attached patch is the last one in the vector length extension > series. It consists of some tweaks to the libgomp nvptx plugin to > accommodate larger vectors along with two test cases. >=20 > I only added two test cases because there's really not much interesting > going on with longer vector lengths. We should eventually add more tests > cases to handle situations where the nvptx BE falls back to using a > shorter vector length. But right now GCC just makes those changes > silently. There is precedent for the nvptx BE to emit a warning when > vector length !=3D 32, but that might be too verbose. On one hand, it > could be argued that the compiler should error if it cannot satisfy the > user's request. On the other hand, falling back to a smaller vector > length ensures correctness. >=20 > Thomas, do you have any thoughts on the warnings/errors or there lack of? Yeah, warning when "vector_length([bigger than 32])" is reduced to "vector_length(32)" is probably too verbose/not useful. But, it'd be useful to have in "-fopt-info-omp"? Gr=C3=BC=C3=9Fe Thomas