From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117497 invoked by alias); 1 Mar 2018 15:37:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117480 invoked by uid 89); 1 Mar 2018 15:37:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=stand X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Mar 2018 15:37:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7A8241529; Thu, 1 Mar 2018 07:37:05 -0800 (PST) Received: from localhost (unknown [10.32.99.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7013D3F25C; Thu, 1 Mar 2018 07:37:04 -0800 (PST) From: Richard Sandiford To: Ramana Radhakrishnan Mail-Followup-To: Ramana Radhakrishnan ,GCC Patches , James Greenhalgh , Sudi Das , richard.sandiford@arm.com Cc: GCC Patches , James Greenhalgh , Sudi Das Subject: Re: [Patch AArch64] Turn on frame pointer / partial fix for PR84521 References: Date: Thu, 01 Mar 2018 15:37:00 -0000 In-Reply-To: (Ramana Radhakrishnan's message of "Fri, 23 Feb 2018 11:32:57 +0000") Message-ID: <87inafyfhd.fsf@e105548-lin.cambridge.arm.com> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-03/txt/msg00034.txt.bz2 Ramana Radhakrishnan writes: > This fixes a GCC-8 regression that we accidentally switched off frame > pointers in the AArch64 backend when changing the defaults in the common > parts of the code. This breaks an ABI decision that was made in GCC at > the dawn of the port with respect to having a frame pointer at all > times. If we really want to turn this off lets have a discussion around > that separately. > > For now turn this back on and I believe this will leave PR84521 latent > again with -fomit-frame-pointer and (hopefully) make the ruby issue go > away. I'm asking Sudi to pick that up. > > Bootstrapped and regression tested on AArch64-none-linux-gnu but I see > one regression in gcc.c-torture/execute/960419-2.c which needs to be > looked at next (PR84528, thanks Kyrill). > > Ok to put in and then look at PR84528 ? > > gcc/ChangeLog: > > 2018-02-23 Ramana Radhakrishnan > > PR target/84521 > * common/config/aarch64/aarch64-common.c > (aarch_option_optimization_table[]): Switch > off fomit-frame-pointer If we're doing this, we might also want to change the default for -momit-leaf-frame-pointer. As things stand we'll create a frame for things like: void f (void) { volatile int x = 1; } but not use a frame pointer for it. Thanks, Richard