From: Thomas Schwinge <thomas@codesourcery.com>
To: Jakub Jelinek <jakub@redhat.com>, <gcc-patches@gcc.gnu.org>
Subject: Re: Remove unused "default_kind" member from gcc/omp-low.c's "struct omp_context"
Date: Tue, 23 May 2017 16:06:00 -0000 [thread overview]
Message-ID: <87inkry324.fsf@hertz.schwinge.homeip.net> (raw)
In-Reply-To: <20170523103618.GN8499@tucnak>
Hi!
On Tue, 23 May 2017 12:36:18 +0200, Jakub Jelinek <jakub@redhat.com> wrote:
> On Fri, Mar 31, 2017 at 05:05:29PM +0200, Thomas Schwinge wrote:
> > Remove unused "default_kind" member from gcc/omp-low.c's "struct omp_context"
> Ok for trunk.
Thanks. As posted, committed to trunk in r248372:
commit 093c94dd910ff55efb5e1bb38cc8020ee488c1e9
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Tue May 23 16:00:56 2017 +0000
Remove unused "default_kind" member from gcc/omp-low.c's "struct omp_context"
gcc/
* omp-low.c (struct omp_context): Remove "default_kind" member.
Adjust all users.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@248372 138bc75d-0d04-0410-961f-82ee72b054a4
---
gcc/ChangeLog | 3 +++
gcc/omp-low.c | 12 +-----------
2 files changed, 4 insertions(+), 11 deletions(-)
diff --git gcc/ChangeLog gcc/ChangeLog
index b38a31d..b626515 100644
--- gcc/ChangeLog
+++ gcc/ChangeLog
@@ -1,5 +1,8 @@
2017-05-23 Thomas Schwinge <thomas@codesourcery.com>
+ * omp-low.c (struct omp_context): Remove "default_kind" member.
+ Adjust all users.
+
* omp-offload.c (execute_oacc_device_lower): Remove the
parallelism dimensions function attributes for unparallelized
OpenACC kernels constructs.
diff --git gcc/omp-low.c gcc/omp-low.c
index 968075c..9a16248 100644
--- gcc/omp-low.c
+++ gcc/omp-low.c
@@ -112,10 +112,6 @@ struct omp_context
otherwise. */
gimple *simt_stmt;
- /* What to do with variables with implicitly determined sharing
- attributes. */
- enum omp_clause_default_kind default_kind;
-
/* Nesting depth of this context. Used to beautify error messages re
invalid gotos. The outermost ctx is depth 1, with depth 0 being
reserved for the main body of the function. */
@@ -1162,10 +1158,6 @@ scan_sharing_clauses (tree clauses, omp_context *ctx,
install_var_field (decl, by_ref, 3, ctx);
break;
- case OMP_CLAUSE_DEFAULT:
- ctx->default_kind = OMP_CLAUSE_DEFAULT_KIND (c);
- break;
-
case OMP_CLAUSE_FINAL:
case OMP_CLAUSE_IF:
case OMP_CLAUSE_NUM_THREADS:
@@ -1332,6 +1324,7 @@ scan_sharing_clauses (tree clauses, omp_context *ctx,
case OMP_CLAUSE_SEQ:
case OMP_CLAUSE_TILE:
case OMP_CLAUSE__SIMT_:
+ case OMP_CLAUSE_DEFAULT:
break;
case OMP_CLAUSE_ALIGNED:
@@ -1826,7 +1819,6 @@ scan_omp_parallel (gimple_stmt_iterator *gsi, omp_context *outer_ctx)
if (taskreg_nesting_level > 1)
ctx->is_nested = true;
ctx->field_map = splay_tree_new (splay_tree_compare_pointers, 0, 0);
- ctx->default_kind = OMP_CLAUSE_DEFAULT_SHARED;
ctx->record_type = lang_hooks.types.make_type (RECORD_TYPE);
name = create_tmp_var_name (".omp_data_s");
name = build_decl (gimple_location (stmt),
@@ -1875,7 +1867,6 @@ scan_omp_task (gimple_stmt_iterator *gsi, omp_context *outer_ctx)
if (taskreg_nesting_level > 1)
ctx->is_nested = true;
ctx->field_map = splay_tree_new (splay_tree_compare_pointers, 0, 0);
- ctx->default_kind = OMP_CLAUSE_DEFAULT_SHARED;
ctx->record_type = lang_hooks.types.make_type (RECORD_TYPE);
name = create_tmp_var_name (".omp_data_s");
name = build_decl (gimple_location (stmt),
@@ -2390,7 +2381,6 @@ scan_omp_target (gomp_target *stmt, omp_context *outer_ctx)
ctx = new_omp_context (stmt, outer_ctx);
ctx->field_map = splay_tree_new (splay_tree_compare_pointers, 0, 0);
- ctx->default_kind = OMP_CLAUSE_DEFAULT_SHARED;
ctx->record_type = lang_hooks.types.make_type (RECORD_TYPE);
name = create_tmp_var_name (".omp_data_t");
name = build_decl (gimple_location (stmt),
Grüße
Thomas
prev parent reply other threads:[~2017-05-23 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 15:06 Thomas Schwinge
2017-05-19 11:13 ` Thomas Schwinge
2017-05-23 10:40 ` Jakub Jelinek
2017-05-23 16:06 ` Thomas Schwinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inkry324.fsf@hertz.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).