From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97577 invoked by alias); 23 Jun 2016 06:45:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 97538 invoked by uid 89); 23 Jun 2016 06:45:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1333 X-HELO: eusmtp01.atmel.com Received: from eusmtp01.atmel.com (HELO eusmtp01.atmel.com) (212.144.249.243) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 23 Jun 2016 06:45:22 +0000 Received: from HNOCHT02.corp.atmel.com (10.161.30.162) by eusmtp01.atmel.com (10.161.101.31) with Microsoft SMTP Server (TLS) id 14.3.235.1; Thu, 23 Jun 2016 08:45:13 +0200 Received: from jaguar.atmel.com (10.161.30.18) by HNOCHT02.corp.atmel.com (10.161.30.162) with Microsoft SMTP Server (TLS) id 14.3.235.1; Thu, 23 Jun 2016 08:45:17 +0200 References: <87y46m1h3y.fsf@atmel.com> <5751B5EA.5000108@gjlay.de> <877fe1nrdy.fsf@atmel.com> <87lh258ufn.fsf@atmel.com> <576AD79E.6090209@gjlay.de> User-agent: mu4e 0.9.17; emacs 24.5.1 From: Senthil Kumar Selvaraj To: Georg-Johann Lay CC: , Denis Chertykov Subject: Re: [Patch, avr] Fix PR 71151 In-Reply-To: <576AD79E.6090209@gjlay.de> Date: Thu, 23 Jun 2016 06:45:00 -0000 Message-ID: <87inx0ietv.fsf@atmel.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg01663.txt.bz2 Georg-Johann Lay writes: > Senthil Kumar Selvaraj schrieb: >> Senthil Kumar Selvaraj writes: >> >>> Georg-Johann Lay writes: >>> >>>> Senthil Kumar Selvaraj schrieb: >>>>> Hi, >>>>> >>>>> [set JUMP_TABLES_IN_TEXT_SECTION to 1] >>> >>> I added tests that use linker relaxation and discovered a relaxation bug >>> in binutils 2.26 (and later) that messes up symbol values in the >>> presence of alignment directives. I'm working on that right now - >>> hopefully, it'll get backported to the release branch. >>> >>> Once that gets upstream, I'll resend the patch - with more tests, and >>> incorporating your comments. >>> >> >> There were two binutils bugs (PR ld/20221 and ld/20254) that were >> blocking this patch - on enabling, relaxation, jumptables were >> getting corrupted. Both of the issues are now fixed, and the fixes >> are in master and 2.26 branch. > > Should we mention in the release notes that Binutils >= 2.26 is needed > for avr-gcc >= 6 ? Yes, we should document it. binutils 2.25 would probably work too, as the bugs were introduced only in binutils 2.26. I'll check and send a patch. > > Maybe even check during configure whether an appropriate version of > Binutils is used? That would be nice, but is it ok to add target specific conditions to configure.ac? Regards Senthil