From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19714 invoked by alias); 8 Jan 2015 14:59:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19595 invoked by uid 89); 8 Jan 2015 14:59:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Jan 2015 14:59:51 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Y9EYt-0006Ek-7R from Thomas_Schwinge@mentor.com ; Thu, 08 Jan 2015 06:59:47 -0800 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.3.224.2; Thu, 8 Jan 2015 14:59:45 +0000 From: Thomas Schwinge To: Jakub Jelinek CC: Ilya Verbin , , Kirill Yukhin , Andrey Turetskiy Subject: Re: [PATCH 1/4] Add mkoffload for Intel MIC In-Reply-To: <20141222112820.GJ1667@tucnak.redhat.com> References: <20141021171323.GA47586@msticlxl57.ims.intel.com> <20141021171602.GB47586@msticlxl57.ims.intel.com> <20141022082103.GH10376@tucnak.redhat.com> <20141022185701.GA21398@msticlxl57.ims.intel.com> <87sig8ylhv.fsf@kepler.schwinge.homeip.net> <20141222112820.GJ1667@tucnak.redhat.com> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Thu, 08 Jan 2015 14:59:00 -0000 Message-ID: <87ioghwc6e.fsf@schwinge.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2015-01/txt/msg00379.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 3685 Hi! On Mon, 22 Dec 2014 12:28:20 +0100, Jakub Jelinek wrote: > On Mon, Dec 22, 2014 at 12:25:32PM +0100, Thomas Schwinge wrote: > > On Wed, 22 Oct 2014 22:57:01 +0400, Ilya Verbin wro= te: > > > --- /dev/null > > > +++ b/gcc/config/i386/intelmic-mkoffload.c > > > @@ -0,0 +1,541 @@ > > > +/* Offload image generation tool for Intel MIC devices. > >=20 > > > +/* Shows if we should compile binaries for i386 instead of x86-64. = */ > > > +bool target_ilp32 =3D false; > >=20 > > My linker defaults to 32-bit x86, so I explicitly have to switch to > > 64-bit x86_64 mode; OK to commit the following, to always explicitly > > specify what is wanted? > >=20 > > gcc/config/i386/intelmic-mkoffload.c | 12 ++++++++---- > > 1 file changed, 8 insertions(+), 4 deletions(-) >=20 > Ok with proper ChangeLog entry. Committed to trunk in r219345: commit c049b358f961f72d0c0cf61a707e9a5855b12b28 Author: tschwinge Date: Thu Jan 8 14:58:45 2015 +0000 intelmic-mkoffload: Deal with linker defaulting to 32-bit x86 mode. =20=20=20=20 ... which explicitly has to be switched into 64-bit x86_64 mode. =20=20=20=20 gcc/ * config/i386/intelmic-mkoffload.c (compile_for_target): Always add "-m32" or "-m64" to argv_obstack. (generate_host_descr_file): Likewise, when invoking host_compiler. (main): Always add "-m elf_i386" or "-m elf_x86_64" when invoking ld. =20=20=20=20 git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@219345 138bc75d-0d04-04= 10-961f-82ee72b054a4 --- gcc/ChangeLog | 8 ++++++++ gcc/config/i386/intelmic-mkoffload.c | 12 ++++++++---- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git gcc/ChangeLog gcc/ChangeLog index bee5f1e..01b6cc6 100644 --- gcc/ChangeLog +++ gcc/ChangeLog @@ -1,3 +1,11 @@ +2015-01-08 Thomas Schwinge + + * config/i386/intelmic-mkoffload.c (compile_for_target): Always + add "-m32" or "-m64" to argv_obstack. + (generate_host_descr_file): Likewise, when invoking host_compiler. + (main): Always add "-m elf_i386" or "-m elf_x86_64" when invoking + ld. + 2015-01-08 Oleg Endo =20 * config/sh/sh-mem.cc: Use constant as second operand when emitting diff --git gcc/config/i386/intelmic-mkoffload.c gcc/config/i386/intelmic-mk= offload.c index c3d2b23..23bc955 100644 --- gcc/config/i386/intelmic-mkoffload.c +++ gcc/config/i386/intelmic-mkoffload.c @@ -191,6 +191,8 @@ compile_for_target (struct obstack *argv_obstack) { if (target_ilp32) obstack_ptr_grow (argv_obstack, "-m32"); + else + obstack_ptr_grow (argv_obstack, "-m64"); obstack_ptr_grow (argv_obstack, NULL); char **argv =3D XOBFINISH (argv_obstack, char **); =20 @@ -355,6 +357,8 @@ generate_host_descr_file (const char *host_compiler) new_argv[new_argc++] =3D "-shared"; if (target_ilp32) new_argv[new_argc++] =3D "-m32"; + else + new_argv[new_argc++] =3D "-m64"; new_argv[new_argc++] =3D src_filename; new_argv[new_argc++] =3D "-o"; new_argv[new_argc++] =3D obj_filename; @@ -511,11 +515,11 @@ main (int argc, char **argv) unsigned new_argc =3D 0; const char *new_argv[9]; new_argv[new_argc++] =3D "ld"; + new_argv[new_argc++] =3D "-m"; if (target_ilp32) - { - new_argv[new_argc++] =3D "-m"; - new_argv[new_argc++] =3D "elf_i386"; - } + new_argv[new_argc++] =3D "elf_i386"; + else + new_argv[new_argc++] =3D "elf_x86_64"; new_argv[new_argc++] =3D "--relocatable"; new_argv[new_argc++] =3D host_descr_filename; new_argv[new_argc++] =3D target_so_filename; Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature Content-length: 472 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUrptaAAoJEPoxNhtoi6COH50H/iMl4iYJ3Ug8x7kNuyNmsKm9 fvxOr/htOkk6yqHhvNG7c+841u6WFVLins6C97bFIGacKRE233aLgtWAygn2kqts crS8Et6ohE6t2IN4QUdL4wbADTFQP3ovZaQLGhmaWb1hYXP3Cxc2FiLXOstG3me0 OVRQTloMcTFHfKH9EiGha5xXZ5yXhcobdyE7mpez0Y4q8R3g/TmWkDvsRLcwoziN xsBrZLl/Ky1gMIOAxE/DiNLmW9DrUUikOsEQTC3pVxIQrGUoKO9FqzbaIv+VALrk y2c89zR/K9BPmX+9t+KAkzwqo8BGoRdUu+ZgCaf3jN+Cy8hnrPsNa9rl3cGgf7E= =Lo3M -----END PGP SIGNATURE----- --=-=-=--