From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27441 invoked by alias); 23 Sep 2014 15:33:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 27431 invoked by uid 89); 23 Sep 2014 15:33:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 Sep 2014 15:33:24 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 23 Sep 2014 16:33:21 +0100 Received: from localhost ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 23 Sep 2014 16:33:19 +0100 From: Richard Sandiford To: Segher Boessenkool Mail-Followup-To: Segher Boessenkool ,Jakub Jelinek , Bernd Schmidt , Andrew MacLeod , gcc-patches , richard.sandiford@arm.com Cc: Jakub Jelinek , Bernd Schmidt , Andrew MacLeod , gcc-patches Subject: Re: parallel check output changes? References: <541AD692.4030907@redhat.com> <20140918130109.GH17454@tucnak.redhat.com> <541AD880.7080703@redhat.com> <541AF451.3070406@redhat.com> <541B1710.8060809@codesourcery.com> <20140918173609.GM17454@tucnak.redhat.com> <20140918184455.GB28595@gate.crashing.org> <20140919093723.GA26414@gate.crashing.org> Date: Tue, 23 Sep 2014 15:33:00 -0000 In-Reply-To: <20140919093723.GA26414@gate.crashing.org> (Segher Boessenkool's message of "Fri, 19 Sep 2014 04:37:23 -0500") Message-ID: <87iokel5c0.fsf@e105548-lin.cambridge.arm.com> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-MC-Unique: 114092316332101601 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2014-09/txt/msg01989.txt.bz2 Segher Boessenkool writes: > On Thu, Sep 18, 2014 at 01:44:55PM -0500, Segher Boessenkool wrote: >> I am testing a patch that is just >>=20 >>=20 >> diff --git a/contrib/dg-extract-results.py b/contrib/dg-extract-results.= py >> index cccbfd3..3781423 100644 >> --- a/contrib/dg-extract-results.py >> +++ b/contrib/dg-extract-results.py >> @@ -117,7 +117,7 @@ class Prog: >> self.tool_re =3D re.compile (r'^\t\t=3D=3D=3D (.*) tests =3D=3D= =3D$') >> self.result_re =3D re.compile (r'^(PASS|XPASS|FAIL|XFAIL|UNRESO= LVED' >> r'|WARNING|ERROR|UNSUPPORTED|UNTES= TED' >> - r'|KFAIL):\s*(\S+)') >> + r'|KFAIL):\s*(.+)') >> self.completed_re =3D re.compile (r'.* completed at (.*)') >> # Pieces of text to write at the head of the output. >> # start_line is a pair in which the first element is a datetime > > Tested that with four runs on powerpc64-linux, four configs each time; > test-summary > shows the same in all cases. Many lines have moved compared to without > the patch, but that cannot be helped. Okay for mainline? > > > 2014-09-19 Segher Boessenkool > > contrib/ > * dg-extract-results.py (Prog.result_re): Include options in test name. FWIW, the \S+ thing was deliberate. When one test is run multiple times with different options, those options aren't necessarily tried in alphabetical order. The old sh/awk script therefore used just the test name as the key and kept tests with the same name in the order that they were encountered: /^(PASS|XPASS|FAIL|XFAIL|UNRESOLVED|WARNING|ERROR|UNSUPPORTED|UNTESTED|KFAI= L):/ { testname=3D\$2 # Ugly hack for gfortran.dg/dg.exp if ("$TOOL" =3D=3D "gfortran" && testname ~ /^gfortran.dg\/g77\//) testname=3D"h"testname } (note the "$2"). This means that the output of the script is in the same order as it would be for non-parallel runs. I was following (or trying to follow) that behaviour in the python script. Your patch instead sorts based on the full test name, including options, which means that the output no longer matches what you'd get from a non-parallel run. AFAICT, it also no longer matches what you'd get from the .sh version. That might be OK, just thought I'd mention it. Thanks, Richard