public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Marc Poulhiès" <poulhies@adacore.com>
To: Yujie Yang <yangyujie@loongson.cn>
Cc: gcc-patches@gcc.gnu.org, charlet@adacore.com,
	ebotcazou@libertysurf.fr, derodat@adacore.com,
	xuchenghua@loongson.cn, chenglulu@loongson.cn
Subject: Re: [PING][PATCH] LoongArch: initial ada support on linux
Date: Tue, 05 Sep 2023 13:23:15 +0200	[thread overview]
Message-ID: <87jzt450bt.fsf@adacore.com> (raw)
In-Reply-To: <kppgn42dpzsuwdwpkaifowkolum3o432ljvj4bkzd6ay7st42d@r2nfepezhqsq>


Yujie Yang <yangyujie@loongson.cn> writes:
> Hi Marc,
>
> Thank you for the review!
>
> We added -gnatea and -gnatez to CC1_SPECS for correct multilib handling,
> and I believe this is currently specific to LoongArch.
>
> LoongArch relies on the GCC driver (via self_specs rules) to generate a
> canonicalized tuple of parameters that identifies the current target (ISA/ABI)
> configuration, including the "-mabi=" option that corresponds to the selected
> multilib variant.  Even if "-mabi=" itself is not given explicitly to gcc, it
> may be fed to the compiler propers with values other than the default ABI.
>
> For GNAT on LoongArch, it is necessary that -mabi= generated by driver
> self-specs gets stored in the .ali file, otherwise the linker might
> hit the wrong multilib variant by assuming the default ABI.  Using
> -gnatea/-gnatez can mark the driver-generated "-mabi=" as "explicit",
> so it is sure to be found in "A"-records of the generated *.ali file.

Hello Yujie,

Thanks for the explanation!

Marc

  reply	other threads:[~2023-09-05 11:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25  4:46 Yang Yujie
2023-08-25  5:55 ` Yujie Yang
2023-08-31  3:31   ` chenglulu
2023-08-31 13:09 ` Marc Poulhiès
2023-09-01  2:05   ` Yujie Yang
2023-09-05 11:23     ` Marc Poulhiès [this message]
2023-09-01 13:52 ` Arnaud Charlet
2023-09-04  2:19   ` Yang Yujie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzt450bt.fsf@adacore.com \
    --to=poulhies@adacore.com \
    --cc=charlet@adacore.com \
    --cc=chenglulu@loongson.cn \
    --cc=derodat@adacore.com \
    --cc=ebotcazou@libertysurf.fr \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=xuchenghua@loongson.cn \
    --cc=yangyujie@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).