From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 92A593858D32 for ; Tue, 5 Sep 2023 11:25:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 92A593858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-31c73c21113so2001168f8f.1 for ; Tue, 05 Sep 2023 04:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1693913113; x=1694517913; darn=gcc.gnu.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=jn8A1MTA35Rhp+yjsLQA+atVXezlPN4nKbeHV2ytxqY=; b=BdzuJZkUtB0g2R6g5Wqnp0FFuyeqFwVKkNik/Hi6HUVf8ws20L1xDl4zocpNfJrtKx MiLatV9n53j/rNirOuPJlRkL1i9ldOn0Fi/XG1NmgPUF7Owbe1qtNDm4KmQ50Bhtc056 TPuaNdcDb+UrMdx3x+CMCrypA7buRPCRjJmlHMWRFul9peaP3VzuaE+svEXy5vNmAQ86 8chNOp/c/U9Hb7gbzfVfRWjA2tLVHmIcuVop+TwrqXXSo1G6PsxpTwWFiM1Bhf5v/HmL iVHM0/OBmkG3hY/BP4xJIzYoIjUpxdQ8hjibFQD5UwrSTKXG+PK3CzHk/BzHBCCdyAJG xEeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693913113; x=1694517913; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jn8A1MTA35Rhp+yjsLQA+atVXezlPN4nKbeHV2ytxqY=; b=QaiAwhjqw4lfr+GEa0CBP2VRZkY0KW1ViN5puPVXmi4jYMa17PFkAy8zczh3P6AL18 TfC5c0Esvnzao1jr17Iw7nlNLfliNMSAZYRzCRY0jc5giUh95Lp5flV26ENxlBzWO8r8 MQ5B3hv5zi3ilzf5IA+UA8sbQnzhgJIqxQ2/ZfdK1Mu2BctpUauXEKz6lTaz6FnN0QdW unludBr0QJwb492KnRYE/UTLsgRx+jDhgLlYq0krqK3R6P48zuCMmgIEk2GAvLGfJLb0 66AL1WN2/aeGAzoh54ozu5QjpnLnng+EHZxG4FYtKkO479TTIiHFMpMZsouKhNTms1v+ UuZA== X-Gm-Message-State: AOJu0YzrHY56zzwOtgfShKUnDo94sVqQzo7ZXbLGJ/XW2s4R+gyYEhhF oc5JnFciI25iCRqcVjbwQHLV/Om0v16e54tED3GFKw== X-Google-Smtp-Source: AGHT+IHsypyax3vmSg6HUjLfn2/NQp5KxOjF1/NJKoiRWn6y6q0LxGXG4jmAeI8WFgCk0YnmRlKX4w== X-Received: by 2002:adf:e5c7:0:b0:317:650e:9030 with SMTP id a7-20020adfe5c7000000b00317650e9030mr9212461wrn.57.1693913112665; Tue, 05 Sep 2023 04:25:12 -0700 (PDT) Received: from poulhies-Precision-5550 ([2001:861:3382:1a90:20fc:79e4:455c:1075]) by smtp.gmail.com with ESMTPSA id n4-20020adffe04000000b0031779a6b451sm17289111wrr.83.2023.09.05.04.25.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 04:25:11 -0700 (PDT) References: <20230825044712.348608-1-yangyujie@loongson.cn> <87o7in49w5.fsf@adacore.com> User-agent: mu4e 1.10.1; emacs 28.1 From: Marc =?utf-8?Q?Poulhi=C3=A8s?= To: Yujie Yang Cc: gcc-patches@gcc.gnu.org, charlet@adacore.com, ebotcazou@libertysurf.fr, derodat@adacore.com, xuchenghua@loongson.cn, chenglulu@loongson.cn Subject: Re: [PING][PATCH] LoongArch: initial ada support on linux Date: Tue, 05 Sep 2023 13:23:15 +0200 In-reply-to: Message-ID: <87jzt450bt.fsf@adacore.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Yujie Yang writes: > Hi Marc, > > Thank you for the review! > > We added -gnatea and -gnatez to CC1_SPECS for correct multilib handling, > and I believe this is currently specific to LoongArch. > > LoongArch relies on the GCC driver (via self_specs rules) to generate a > canonicalized tuple of parameters that identifies the current target (ISA/ABI) > configuration, including the "-mabi=" option that corresponds to the selected > multilib variant. Even if "-mabi=" itself is not given explicitly to gcc, it > may be fed to the compiler propers with values other than the default ABI. > > For GNAT on LoongArch, it is necessary that -mabi= generated by driver > self-specs gets stored in the .ali file, otherwise the linker might > hit the wrong multilib variant by assuming the default ABI. Using > -gnatea/-gnatez can mark the driver-generated "-mabi=" as "explicit", > so it is sure to be found in "A"-records of the generated *.ali file. Hello Yujie, Thanks for the explanation! Marc