From: Andreas Schwab <schwab@linux-m68k.org>
To: Andrew Pinski via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Andrew Pinski <apinski@marvell.com>
Subject: Re: [PATCH 1/2] Fix PR 110066: crash with -pg -static on riscv
Date: Sun, 23 Jul 2023 08:46:27 +0200 [thread overview]
Message-ID: <87jzurjfb0.fsf@linux-m68k.org> (raw)
In-Reply-To: <20230723010645.1622083-1-apinski@marvell.com> (Andrew Pinski via Gcc-patches's message of "Sat, 22 Jul 2023 18:06:44 -0700")
On Jul 22 2023, Andrew Pinski via Gcc-patches wrote:
> The problem -fasynchronous-unwind-tables is on by default for riscv linux
> We need turn it off for crt*.o because it would make __EH_FRAME_BEGIN__ point
> to .eh_frame data from crtbeginT.o instead of the user-defined object
> during static linking.
>
> This turns it off.
Since this is a recurring problem, and difficult to notice (see how long
the aarch64 case went unnoticed), it should be fixed generically,
instead of having to patch every case separately.
> diff --git a/libgcc/config/riscv/t-crtstuff b/libgcc/config/riscv/t-crtstuff
> new file mode 100644
> index 00000000000..685d11b3e66
> --- /dev/null
> +++ b/libgcc/config/riscv/t-crtstuff
> @@ -0,0 +1,5 @@
> +# -fasynchronous-unwind-tables -funwind-tables is on by default for riscv linux
> +# We turn it off for crt*.o because it would make __EH_FRAME_BEGIN__ point
> +# to .eh_frame data from crtbeginT.o instead of the user-defined object
> +# during static linking.
> +CRTSTUFF_T_CFLAGS += -fno-asynchronous-unwind-tables -fno-unwind-tables
What about CRTSTUFF_T_CFLAGS_S?
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
prev parent reply other threads:[~2023-07-23 6:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 1:06 Andrew Pinski
2023-07-23 1:06 ` [PATCH 2/2] AARCH64: Turn off unwind tables for crtbeginT.o Andrew Pinski
2023-07-24 15:55 ` Richard Sandiford
2023-07-25 7:06 ` Richard Biener
2023-07-23 3:35 ` [PATCH 1/2] Fix PR 110066: crash with -pg -static on riscv Kito Cheng
2024-05-08 16:07 ` Andrew Pinski
2023-07-23 6:46 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzurjfb0.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).