From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2052.outbound.protection.outlook.com [40.107.22.52]) by sourceware.org (Postfix) with ESMTPS id 1425E3858D28 for ; Wed, 24 May 2023 20:34:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1425E3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=siemens.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YntjIPS0Gelx6OneGFDSUrVy4R7mLVmuBNNp34+HsDs4iI2ctMWj8mAHmA/zDy4D82BE6pGjsGF5/UePxw5pXzYKc9QZW+5bzSqKVApflT9wrVMJgUL9TixQsM6Vibh/9yfhzAibAIWWLrDutuB0UpUt86doKkYc7hsqJqsrANJCOJ0c1WUqECCjf9Bh20O6GGqwAPhCBuwiLpySqa5QdIpFKlZmKEikXLxN1AXy/K9M02sRAfhjeMIu9FA9Xc2aOPdq+q5jk8X1pi63flu/g0fUJ3jDlhpafuNGst/BKaInx/8OKM1gfpALKLKBjRCzP93qQl/+zIJthBHGJpJXcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Mh5fuIlCb6uVcAtUu4chhbN21GqgclGo3o7rCPQX4Y=; b=PROxE07IA/RCq3FkDbJ3LOjO9T09IzYHk+yf+YWSyzcrLejF765JMfzUZU4bY5CXIBL7Ws74GsPoBVwXl7zQ37bxU+k9C4O0DDR4BAuJc33L4rjxYK07PXBxZA/ZAXxmZCGNMSXoGqqitXESzZeDeVxHJuJMjt0/2Zvr6gFlzsE857tRNqU93UGSMvGZTFpzvugFA6IzXmugJr9qMMtzBwnXKafua3qyrGJKvdtm/OS850WlqFOX/xeGFS4js+Vg8I02Yc+62Qz3cy7JzzRUboQgGePqRQYO0d5+twHueEmLw7Kfh42dFc+/XLQ7bujsotRQzIVB1YFigOCMwEaYWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Mh5fuIlCb6uVcAtUu4chhbN21GqgclGo3o7rCPQX4Y=; b=uGecFVJgzXD1pst7vRtSVayrCcr516oWr1l6a4gxwOUyRlSNR56ylmW15nvFb80H89ieVGypDqYh3UtjgEi9/GGxsWNlLpCLC25Ft1Z66gULC+RmabC22TkPzjLukjJ8knJh96lAwVtJeEW9AqUivUBlKDeGLXBV6LEvGjovPkC+by70rwT+Y1Pb+VfAmzgCup1LEyNNFIo4KBXyfRQcXSAXfu7GB9oaYa+RVYFG5JAM/7gXGUr4WtwEoLInafEQgDQh/nYfszZ62TJNewyw8eWVy7VJQ2Vo2TKWrC+t7Ws4mByvthSwGUPka5IfjZ/vGcz3HEuqpVKkyzq/gZ+gBg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from DU0PR10MB5583.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:31b::22) by DB9PR10MB5620.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:30f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.16; Wed, 24 May 2023 20:34:24 +0000 Received: from DU0PR10MB5583.EURPRD10.PROD.OUTLOOK.COM ([fe80::ed0:d9f:8d5d:5e22]) by DU0PR10MB5583.EURPRD10.PROD.OUTLOOK.COM ([fe80::ed0:d9f:8d5d:5e22%3]) with mapi id 15.20.6411.029; Wed, 24 May 2023 20:34:23 +0000 From: Thomas Schwinge To: Vineet Gupta , Kito Cheng Cc: gcc-patches@gcc.gnu.org, kito.cheng@gmail.com, patrick@rivosinc.com, jlaw@ventanamicro.com, "Maciej W . Rozycki" Subject: Re: [PATCH] RISC-V: Add missing torture-init and torture-finish for rvv.exp In-Reply-To: References: <20230522064138.74056-1-kito.cheng@sifive.com> User-Agent: Notmuch/0.29.1+93~g67ed7df (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Wed, 24 May 2023 22:34:16 +0200 Message-ID: <87jzwxsc3b.fsf@dem-tschwing-1.ger.mentorg.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::9) To DU0PR10MB5583.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:31b::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR10MB5583:EE_|DB9PR10MB5620:EE_ X-MS-Office365-Filtering-Correlation-Id: fc1c7a7b-75a4-43aa-7f1e-08db5c9641df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nARpCOJdk0fWouT0np2FVP2bcOb2mXqA5Fo5PWcJgYmne34bX10MdTEiI7eRTsENtHCxR/uOuSY9I4HUJVFuMHI0LW9Mmq3fQcUtCbFGQCTCc8NZC8VM3hetWFmB/pdol4remuY3avaPgekwMv5fNswMfRuDqAApXtxpb6A42eYQQAZw0orqSS3/pnu1wsXGNgxpIquB7SwrNvuFAvpEOlN37ht1/aC+OeHXtzePox8ukQ1/E2wVIYy9p+cbkc5vz3xBaTB6GGu+Dj/LuuchTj1qJUhd5lh88M1s6eUZ30nhV2pinH4JPbZOQWAO++rwbCS+sxS9tcCgugiqVwCMuFm1H81+mqG9GI5j8ncsWUCC9WdeqNK7NI6PTxiffQ5dBrJXzK5hesAdofh9IQ1mXcQ6hybHek/3MEPiWxTn3Mca2336U0K9v/4pwmYonois1nD2vkELCbIhYGa0/9f4oJsvTM8aD9qXuhsxkOXfiPFDA7CuLtdNGpn2GNL7t8RUdg3Ab+BbM9FkZHH67B7g3fGbjR1zijM9CCWahEjatuqyTTevOq/kAXS/LibXqjKahzY7bNPCbQBWL9uQkh6fZA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR10MB5583.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(366004)(376002)(346002)(39860400002)(396003)(451199021)(6512007)(186003)(6506007)(53546011)(9686003)(26005)(2906002)(83380400001)(6666004)(316002)(66946007)(66556008)(66476007)(4326008)(38100700002)(966005)(84970400001)(82960400001)(6486002)(41300700001)(86362001)(110136005)(478600001)(44832011)(5660300002)(8676002)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDFHSTQzR1hnVk1RZkNNTzFnT2psUnNac2crVjYrMVFNVXB2ak1TcyttZXFt?= =?utf-8?B?bk55bEE1cEx3Wjc3R1dIZHhHUFJ4TVVUZUdKT00vbmNTYjlkWmpnS2FpYkpJ?= =?utf-8?B?TG5jN0FSS3ZsYUt1cTZnWHJJdllxUUhQM1Q3aElMaXZiK0lDQXlwZmRZU2ZT?= =?utf-8?B?NzlreDRNSC9qR1dadGVKUUQvYlJOTHZ6Z0VGK1pmQTJkckU4RDUySks1bm1i?= =?utf-8?B?N3FzeDI2WWY4RVJaanlNbzdidzBqYzh0eERuNWNGYXRmQXEvb0RRTnQrbU9Y?= =?utf-8?B?NVBlUWl5SjZnUkRQdEtEV21aNi9jQmJERm4wUzJBbWNpZngzbSt3eENxVHMz?= =?utf-8?B?Q2ZWWSszMzJtb2lEcitnYmN5YXA5YnViWVRjbWlOdHlqY1JlTnZBT0hSYU1Z?= =?utf-8?B?UmJwNUNVaU5KTDF6Q3RxSEt1cWpsZlQ2cFcvZCtDVzdyUVlrcEN1ZTYzOVcr?= =?utf-8?B?VlVLK3YvdnhHc0k1aWxxcGlwbGRObTN5cm1jZ1d2a0J0TE5ZRUJMblUxamhL?= =?utf-8?B?Wll0UCt2b0drMkFxMk80b0F3NVMwWW0wU0xJNjNod3Jtb1BQUHNNZDZrK1Nr?= =?utf-8?B?UEJrYm5VUG1IanZ6RzhpeFR6dDR6d1AxOG90UHNodmJyQy9GdkJ5K1hacHBO?= =?utf-8?B?Q3d0MUYvVWhDcjJ4SHZyVHZRMHJPNGRiZmgxT21JWWZZK0N6RytHMmNoeWE0?= =?utf-8?B?ck8vcXJBSS93WmFDeXQyeVkwUXRncCswc3MzZ3U3ZU9nR3BLZUc1TDBNQTZJ?= =?utf-8?B?eTY0UStZVWFqbGx1OXR3VUF6NmM3cVY3WTIzS2lTSmE1YmphZE1URW1Eb3lu?= =?utf-8?B?M3Q5dndKYmsxd3JXVlN3SEQ2VjBBWmVOeC9QUzQ4ZG9CVEs2akVjUDFVOE0z?= =?utf-8?B?N0w3eG1xQjgwTVVwVkJoWmg0Z1lLT3orcHBadklMRFV0bDlFTU1UZFNtYklz?= =?utf-8?B?TXN5Z3ZHaU55ZVhZZkRET2JSMmNCT2NQRklpT3dOMHc2c3hUWVhmcTAvYVBq?= =?utf-8?B?ZmNCS290bWVta3BFd0Nta3BLemZ3aTBGRGVHT3hMbkFqa0NpZTFieDFBYVVN?= =?utf-8?B?cTRxZ0Q5Q0pxQ0tMU1VIR3lWd2kyb3JRbWlMbDNBRzA5V3l5dnpkRDcwVGts?= =?utf-8?B?RzJxaE42RW0zdWRpU1pPK3dUQmpDVUdWN25IWjRIWXROS1JFU3ozSVAvRGVS?= =?utf-8?B?R0ozYzBEL2xHM3NDeTh2N3BGQXEvWW1VRXVyaCtQdExhRjJER2NRL29nV2Jj?= =?utf-8?B?Rjl2RnZYVGkyeGNaWW1Ea29OV0I0aElGVytSMEt1ZmhLNmdOa0NLODBvMG5t?= =?utf-8?B?MVptWUxYTll0Q24wSE8wQlJEL2dLV1h5K3htdDRRb0tIdlZNNFpZdjZEVDFu?= =?utf-8?B?alpaQS95dW0vOFE5cXdzcEZ0YU1CUndaR01XOXdxN0hHNTVaMEdQdkRoMTF0?= =?utf-8?B?ZVFOcnNKSVdiV1gybEFDNER4ZlRDSmxmVzVMelZ5SWl0WnN5UGQvMGJObnl4?= =?utf-8?B?TTVubGZuZGpDN2t6VkhmK2VwRS9SUnR6Sm5TWi9ReUZOd1JJQzNVWDNERGlK?= =?utf-8?B?RGkvU2w0UG4zd2JOV0dhM0ZPS0ZvZm1QS1UzTHh3cHpZWGV1VXZPWnYwTWhm?= =?utf-8?B?Mkg0Q2ZvZnFkVGhnYWsxc0dVY2V4c0FFYXpzaTg0RzVYR0hJY0ExUHZYaTJV?= =?utf-8?B?c3pQOEQxQlJmM1dSdDdGZ3prWkxXT3pueS9aSW55aGFyb3VzL1pHVDIrNlYr?= =?utf-8?B?bXM4bnlBVDlMeVFCQjdTS0IvemsvdEcvZzdQaEF2NDJGZmJHS0NRZjZGcjhr?= =?utf-8?B?dlJ0b3Y3WGgwNE8ydHpLaHQ5VWgwQ2Q0ckluRnRBRjRsektQcWc5dWp0SHlE?= =?utf-8?B?b2FXQkpBRFI5YlJqbEpQUTcwQ2YwYjd4Y2I4OTJhZ2JuQXdpaU9EV0RCZHY3?= =?utf-8?B?Q2k1VFpYa3ZXMnhtK0g2eHZMVmFFN3hVOC9YU05Pd1E4WUNQdzF6Z1F2UFZG?= =?utf-8?B?UVJnWTNQdnhEVVNPUjRkaEcvcS85V0ppVmthZUY0K09TbjVyQ1lTSFlyZ2VX?= =?utf-8?B?WDR1R1ZaU0s3RGdidXR5ZXhjZkdmc3RPTTZlczh0RktBOXI5bTR0QTJLYUtE?= =?utf-8?B?TGJ3d3VOZUQwNWRsQXg4VUVDeGlKbDg2aDdsOUtVeVZNMnJNL2FjSnBYMGRa?= =?utf-8?B?MkE9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc1c7a7b-75a4-43aa-7f1e-08db5c9641df X-MS-Exchange-CrossTenant-AuthSource: DU0PR10MB5583.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 20:34:22.6481 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PyXQYlM0lflmqJcNZPZQVtBH7aMRt4yJsMQcSt3iL5Tea5RTLTtyI/Hn7Tq7Zh9XkJc/NINFLJgINJc5wwpIQx5Q2jGw0NS6043ViGlogeI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR10MB5620 X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,GIT_PATCH_0,KAM_SHORT,LIKELY_SPAM_BODY,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On 2023-05-24T11:18:35-0700, Vineet Gupta wrote: > On 5/22/23 20:52, Vineet Gupta wrote: >> On 5/22/23 02:17, Kito Cheng wrote: >>> Ooops, seems still some issue around here, >> >> Yep still 5000 fails :-( >> >>> =C2=A0 but I found something might >>> related this issue: >>> >>> https://github.com/gcc-mirror/gcc/commit/d6654a4be3ba44c0d57be7c8a51d76= d9721345e1=20 >>> >>> https://github.com/gcc-mirror/gcc/commit/23c49bb8d09bc3bfce9a08be637cf3= 2ac014de56=20 >>> >> >> It seems both of these patches are essentially doing what yours did.=20 >> So something else is amiss still. Yeah, at this point I'm not sure whether my recent changes really are related/relevant here. > Apparently in addition to Kito's patch below, If I comment out the=20 > additional torture options, failures go down drastically. Meaning that *all* those ERRORs disappear? > diff --git a/gcc/testsuite/gcc.target/riscv/riscv.exp=20 > b/gcc/testsuite/gcc.target/riscv/riscv.exp > > -lappend ADDITIONAL_TORTURE_OPTIONS {-Og -g} {-Oz} > +#lappend ADDITIONAL_TORTURE_OPTIONS {-Og -g} {-Oz} > > @Thomas, do you have some thoughts on how to fix riscv.exp properly in=20 > light of recent changes to exp files. I'm trying to understand this, but so far don't. Can I please see a complete 'gcc.log' file where the ERRORs are visible? Gr=C3=BC=C3=9Fe Thomas >>> On Mon, May 22, 2023 at 2:42=E2=80=AFPM Kito Cheng =20 >>> wrote: >>>> Hi Vineet: >>>> >>>> Could you help to test this patch, this could resolve that issue on ou= r >>>> machine, but I would like to also work for other env. >>>> >>>> Thanks :) >>>> >>>> --- >>>> >>>> We got bunch of following error message for multi-lib run: >>>> >>>> ERROR: torture-init: torture_without_loops is not empty as expected >>>> ERROR: tcl error code NONE >>>> >>>> And seems we need torture-init and torture-finish around the test >>>> loop. >>>> >>>> gcc/testsuite/ChangeLog: >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * gcc.target/riscv/rv= v/rvv.exp: Add torture-init and >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 torture-finish. >>>> --- >>>> =C2=A0 gcc/testsuite/gcc.target/riscv/rvv/rvv.exp | 3 +++ >>>> =C2=A0 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp=20 >>>> b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp >>>> index bc99cc0c3cf4..19179564361a 100644 >>>> --- a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp >>>> +++ b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp >>>> @@ -39,6 +39,7 @@ if [istarget riscv32-*-*] then { >>>> >>>> =C2=A0 # Initialize `dg'. >>>> =C2=A0 dg-init >>>> +torture-init >>>> >>>> =C2=A0 # Main loop. >>>> =C2=A0 set CFLAGS "$DEFAULT_CFLAGS -march=3D$gcc_march -mabi=3D$gcc_ma= bi -O3" >>>> @@ -69,5 +70,7 @@ foreach op $AUTOVEC_TEST_OPTS { >>>> =C2=A0 dg-runtest [lsort [glob -nocomplain=20 >>>> $srcdir/$subdir/autovec/vls-vlmax/*.\[cS\]]] \ >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "-std=3Dc99 -O3 -ftre= e-vectorize --param=20 >>>> riscv-autovec-preference=3Dfixed-vlmax" $CFLAGS >>>> >>>> +torture-finish >>>> + >>>> =C2=A0 # All done. >>>> =C2=A0 dg-finish >>>> --=20 >>>> 2.40.1 >>>> >>