From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 4E9593858D35 for ; Sat, 7 Jan 2023 17:35:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4E9593858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x42a.google.com with SMTP id s9so4038348wru.13 for ; Sat, 07 Jan 2023 09:35:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=//th8r1VpCiCy04ZWAmtuQAGTFx+vm2y6LVx5PWerwY=; b=GXUbX7CCcZ1EOmOJCV6CG9UO8NuTvqNsGQFns5StH1zh+pU/Mlej9iUVwZoGHsvlEx 5Wu4zFald7VLqcaRmA4qvGVg+YWSxGfcAsmGPPr/zi7MB+6WyxvakLdwniFqy33B0TIp dCvBJik5nYiCaYFbTBPOC5nRUt9ZCwADJOsoDFy3pa+WX6K83Xv1AV0APwdkIRbG2Uuo +4ziNoB8pIX3NP4PH3ykYqMRuwL3Il4zzs7J5nCTxtQ+tScYv41oLjPVhKdqTSdQi0Hw 8T+PvfEaxYWYdecU0wbCXvwhr5vX6M/S2qYjSfHKUX8LiSMIoXJliiXQDhSx3tNQTKNP 1/Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=//th8r1VpCiCy04ZWAmtuQAGTFx+vm2y6LVx5PWerwY=; b=lQ404kDJ/5waUTjNuuzxpTx+FMM6ebh+XlrQ9CirMSLhHJxX4JTfhOGijd8xBDtB5u MXAa81ChNcv8//DishATG7ZHqBVNcSvRlo5g9SGfdtLIJpVWm+fdSZsVc9i2ZP0lDUl2 DqLdfSAF7PnZfd02htUXiculYac0nk5c76ahd2/x8qKGeDMHFUcoO5PIbZ/cvsCVAKgv rlgO2vI7EvduuK+Y2wBBsfiun7x/MZ94UIiQIcaFd66rALBOK2jtJlYgO3nVkVwjQj7i 5RW0i1bf9wi8M2YnSC80GYItaDKunD6OWxrk9eL7x0IK/lki7WxMrF5OsqJx+U/o/cJi CSCw== X-Gm-Message-State: AFqh2koNJtRwnkyzqnzXWiN6Syas28cmpCtPYt7GWlparGg//5tdD7kb //hNoCe01SVRtDoTDrBXIfOrC1hPAmI= X-Google-Smtp-Source: AMrXdXsmOTfuSxNlVBLY7Zd+hoXUdNUkUVEyKM8n+D4GkbCyggJoE6JQsaKl86MdsjCXcJGNr8jDSg== X-Received: by 2002:adf:e941:0:b0:2bb:d927:eb7a with SMTP id m1-20020adfe941000000b002bbd927eb7amr1088750wrn.30.1673112898813; Sat, 07 Jan 2023 09:34:58 -0800 (PST) Received: from lancelot ([195.147.220.46]) by smtp.gmail.com with ESMTPSA id o18-20020a5d4752000000b0024165454262sm4268900wrs.11.2023.01.07.09.34.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Jan 2023 09:34:58 -0800 (PST) Received: from gaius by lancelot with local (Exim 4.94.2) (envelope-from ) id 1pED5s-007M5f-WB; Sat, 07 Jan 2023 17:34:57 +0000 From: Gaius Mulley To: Iain Sandoe Cc: gcc-patches@gcc.gnu.org, iain@sandoe.co.uk Subject: Re: [PATCH] modula-2, libm2min: Declare abort and exit as expected. References: <20230107154545.93295-1-iain@sandoe.co.uk> Date: Sat, 07 Jan 2023 17:34:56 +0000 In-Reply-To: <20230107154545.93295-1-iain@sandoe.co.uk> (Iain Sandoe's message of "Sat, 7 Jan 2023 15:45:45 +0000") Message-ID: <87k01yckov.fsf@debian> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Iain Sandoe writes: > Tested with a build on x86_64-darwin21, the build warnings are gone and > the build completed as normal. > OK for master? > thanks > Iain > > --- 8< --- > > The build is currently emitting a warning that abort() is declared differently > from the built-in. This updates the declaration to match expectations. > > Signed-off-by: Iain Sandoe > > gcc/m2/ChangeLog: > > * gm2-libs-min/libc.c (abort): Update declaration to match the > expected form, add no-return attribute. > (exit): Add no-return attribute. > --- > gcc/m2/gm2-libs-min/libc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gcc/m2/gm2-libs-min/libc.c b/gcc/m2/gm2-libs-min/libc.c > index b39bfffb65c..8cddb5dd7b4 100644 > --- a/gcc/m2/gm2-libs-min/libc.c > +++ b/gcc/m2/gm2-libs-min/libc.c > @@ -24,10 +24,10 @@ a copy of the GCC Runtime Library Exception along with this program; > see the files COPYING3 and COPYING.RUNTIME respectively. If not, see > . */ > > -void abort (int); > -void exit (int); > +extern void abort (void) __attribute__ ((__noreturn__)); > +extern void exit (int) __attribute__ ((__noreturn__)); > > -void abort (int i) > +void abort (void) > { > while (1) > ; yes LGTM, thanks! regards, Gaius