From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5551 invoked by alias); 9 Aug 2014 10:16:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 5541 invoked by uid 89); 9 Aug 2014 10:16:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-we0-f177.google.com Received: from mail-we0-f177.google.com (HELO mail-we0-f177.google.com) (74.125.82.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 09 Aug 2014 10:16:22 +0000 Received: by mail-we0-f177.google.com with SMTP id w62so6470309wes.8 for ; Sat, 09 Aug 2014 03:16:19 -0700 (PDT) X-Received: by 10.180.87.231 with SMTP id bb7mr10193434wib.63.1407579379419; Sat, 09 Aug 2014 03:16:19 -0700 (PDT) Received: from localhost ([95.144.14.171]) by mx.google.com with ESMTPSA id je17sm17346489wic.22.2014.08.09.03.16.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Aug 2014 03:16:18 -0700 (PDT) From: Richard Sandiford To: Richard Henderson Mail-Followup-To: Richard Henderson ,gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 01/50] Add rtl-iter.h References: <87y4v5d77q.fsf@googlemail.com> <87tx5td75d.fsf@googlemail.com> <53E15866.2070205@redhat.com> Date: Sat, 09 Aug 2014 10:16:00 -0000 In-Reply-To: <53E15866.2070205@redhat.com> (Richard Henderson's message of "Tue, 05 Aug 2014 12:19:18 -1000") Message-ID: <87k36iq87h.fsf@googlemail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-08/txt/msg00945.txt.bz2 Richard Henderson writes: > On 08/03/2014 03:39 AM, Richard Sandiford wrote: >> +struct rtx_subrtx_bound_info { >> + unsigned char start; >> + unsigned char count; >> +}; > > Given this structure is only two bytes... > >> + /* The bounds to use for iterating over subrtxes. */ >> + const rtx_subrtx_bound_info *m_bounds; > > ... wouldn't it be better to pass by value instead of by reference? This shows I should expand the comment, but m_bounds is an array indexed by rtx code. Thanks, Richard