public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Samuel Bronson <naesten@gmail.com>
To: Tom Tromey <tromey@redhat.com>
Cc: libstdc++@gcc.gnu.org,  GCC Patches <gcc-patches@gcc.gnu.org>,
	 Jonathan Wakely <jwakely@redhat.com>,
	 GDB Patches <gdb-patches@sourceware.org>,
	 Matthias Klose <doko@ubuntu.com>
Subject: Re: [PATCH v3 3/3] Port libstdc++ pretty-printers to Python 2 + Python 3
Date: Sat, 26 Jul 2014 06:33:00 -0000	[thread overview]
Message-ID: <87k370685j.fsf@naesten.mooo.com> (raw)
In-Reply-To: <87tx6asm4y.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon,	21 Jul 2014 10:38:05 -0600")

Tom Tromey <tromey@redhat.com> writes:

>>>>>> "Samuel" == Samuel Bronson <naesten@gmail.com> writes:
>
> Samuel> +# FIXME: The handling of e.g. std::basic_string (at least on char)
> Samuel> +# probably needs updating to work with Python 3's new string rules.
> Samuel> +#
> Samuel> +# In particular, Python 3 has a separate type (called byte) for
> Samuel> +# bytestrings, and a special b"" syntax for the byte literals; the old
> Samuel> +# str() type has been redefined to always store Unicode text.
> Samuel> +#
> Samuel> +# We probably can't do much about this until GDB get their act
> Samuel> +# together: <https://sourceware.org/bugzilla/show_bug.cgi?id=17138>
>
> I don't think this comment is applicable.
> The libstdc++ pretty-printers use gdb.Value.lazy_string, not the
> built-in Python types.

Hmm, doesn't that just make it a timebomb -- a value that will explode
if, at some point in the future, someone tries to treat it as a string?

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread!

  reply	other threads:[~2014-07-26  4:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1400701554-18062-1-git-send-email-naesten@gmail.com>
2014-07-11  2:48 ` [PATCH v2 0/3] Port libstdc++ pretty printers to " Samuel Bronson
2014-07-11  2:49   ` [PATCH v2 1/3] Make libstdc++ testsuite work with pre-color GCC versions again Samuel Bronson
2014-07-11 15:33     ` Jonathan Wakely
2014-07-11  3:00   ` [PATCH v2 2/3] libstdc++ testsuite: Turn off GDB's auto-load, list loaded libs Samuel Bronson
2014-07-11 15:33     ` Jonathan Wakely
2014-07-11  3:22   ` [PATCH v2 3/3] Port libstdc++ pretty-printers to Python 2 + Python 3 Samuel Bronson
2014-07-11  3:45     ` [PATCH v3 " Samuel Bronson
2014-07-11 13:49       ` Jonathan Wakely
2014-07-21 17:06       ` Tom Tromey
2014-07-26  6:33         ` Samuel Bronson [this message]
2014-07-30 14:20           ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k370685j.fsf@naesten.mooo.com \
    --to=naesten@gmail.com \
    --cc=doko@ubuntu.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jwakely@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).