From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21481 invoked by alias); 3 Jul 2014 19:43:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21448 invoked by uid 89); 3 Jul 2014 19:43:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 03 Jul 2014 19:43:32 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s63JhUbY030765 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Jul 2014 15:43:30 -0400 Received: from barimba (ovpn-113-95.phx2.redhat.com [10.3.113.95]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s63JhRcJ013773 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 3 Jul 2014 15:43:27 -0400 From: Tom Tromey To: Mark Wielaard Cc: Jakub Jelinek , gcc-patches@gcc.gnu.org, Jason Merrill , Cary Coutant , Alexandre Oliva Subject: Re: [PATCH] Add guality [p]type test. References: <1403265071.6147.5.camel@bordewijk.wildebeest.org> <1404381209-11280-1-git-send-email-mjw@redhat.com> <20140703100516.GC31640@tucnak.redhat.com> <1404386141.3766.52.camel@bordewijk.wildebeest.org> Date: Thu, 03 Jul 2014 19:43:00 -0000 In-Reply-To: <1404386141.3766.52.camel@bordewijk.wildebeest.org> (Mark Wielaard's message of "Thu, 03 Jul 2014 13:15:41 +0200") Message-ID: <87k37umdnl.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-07/txt/msg00257.txt.bz2 >> Is what gdb prints for ptype stable across different gdb versions (except >> for whitespace that you canonicalize)? If yes, this looks good to me. Mark> Yes, I believe it is (I tested against gdb git master and gdb 7.6.50). Mark> It tries to print the expression as a canonical C type, so it should be Mark> stable. GDB itself contains similar tests, but for pregenerated .S files Mark> or synthetic generated DWARF. This just extends it to make sure gcc and Mark> gdb agree on the produced/consumed debuginfo. I think it should be reasonably reliable. Something like this (but for value-printing) is already done in the libstdc++ test suite. Tom