From: Richard Sandiford <rdsandiford@googlemail.com>
To: Vladimir Makarov <vmakarov@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: patch to fix PR57559 for s390
Date: Wed, 19 Jun 2013 18:31:00 -0000 [thread overview]
Message-ID: <87k3lqlzpr.fsf@talisman.default> (raw)
In-Reply-To: <87zjuv3t9m.fsf@talisman.default> (Richard Sandiford's message of "Wed, 12 Jun 2013 22:37:25 +0100")
Richard Sandiford <rdsandiford@googlemail.com> writes:
> Vladimir Makarov <vmakarov@redhat.com> writes:
>> Index: lra.c
>> ===================================================================
>> --- lra.c (revision 199753)
>> +++ lra.c (working copy)
>> @@ -306,11 +306,11 @@ lra_emit_add (rtx x, rtx y, rtx z)
>> || (disp != NULL_RTX && ! CONSTANT_P (disp))
>> || (scale != NULL_RTX && ! CONSTANT_P (scale)))
>> {
>> - /* Its is not an address generation. Probably we have no 3 op
>> + /* It is not an address generation. Probably we have no 3 op
>> add. Last chance is to use 2-op add insn. */
>> lra_assert (x != y && x != z);
>> - emit_move_insn (x, z);
>> - insn = gen_add2_insn (x, y);
>> + emit_move_insn (x, y);
>> + insn = gen_add2_insn (x, z);
>> emit_insn (insn);
>> }
>> else
>
> Could you add a comment to lra_emit_add saying why it has to be this
> way round (move y, add z)?
Ping.
next prev parent reply other threads:[~2013-06-19 18:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-08 18:38 Vladimir Makarov
2013-06-12 21:37 ` Richard Sandiford
2013-06-19 18:31 ` Richard Sandiford [this message]
2013-06-19 18:51 ` Vladimir Makarov
2013-06-19 19:46 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3lqlzpr.fsf@talisman.default \
--to=rdsandiford@googlemail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).