From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-343940-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 17408 invoked by alias); 19 Jun 2013 18:31:21 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 17386 invoked by uid 89); 19 Jun 2013 18:31:18 -0000
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1
Received: from mail-wi0-f181.google.com (HELO mail-wi0-f181.google.com) (209.85.212.181)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 19 Jun 2013 18:31:17 +0000
Received: by mail-wi0-f181.google.com with SMTP id hq4so951687wib.14        for <gcc-patches@gcc.gnu.org>; Wed, 19 Jun 2013 11:31:15 -0700 (PDT)
X-Received: by 10.180.107.163 with SMTP id hd3mr10952411wib.13.1371666675475;        Wed, 19 Jun 2013 11:31:15 -0700 (PDT)
Received: from localhost ([2.26.204.199])        by mx.google.com with ESMTPSA id k10sm11109517wia.4.2013.06.19.11.31.14        for <multiple recipients>        (version=TLSv1.2 cipher=RC4-SHA bits=128/128);        Wed, 19 Jun 2013 11:31:14 -0700 (PDT)
From: Richard Sandiford <rdsandiford@googlemail.com>
To: Vladimir Makarov <vmakarov@redhat.com>
Mail-Followup-To: Vladimir Makarov <vmakarov@redhat.com>,GCC Patches <gcc-patches@gcc.gnu.org>, rdsandiford@googlemail.com
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: patch to fix PR57559 for s390
References: <51B37A3F.1060705@redhat.com> <87zjuv3t9m.fsf@talisman.default>
Date: Wed, 19 Jun 2013 18:31:00 -0000
In-Reply-To: <87zjuv3t9m.fsf@talisman.default> (Richard Sandiford's message of	"Wed, 12 Jun 2013 22:37:25 +0100")
Message-ID: <87k3lqlzpr.fsf@talisman.default>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-06/txt/msg01152.txt.bz2

Richard Sandiford <rdsandiford@googlemail.com> writes:
> Vladimir Makarov <vmakarov@redhat.com> writes:
>> Index: lra.c
>> ===================================================================
>> --- lra.c	(revision 199753)
>> +++ lra.c	(working copy)
>> @@ -306,11 +306,11 @@ lra_emit_add (rtx x, rtx y, rtx z)
>>  	  || (disp != NULL_RTX && ! CONSTANT_P (disp))
>>  	  || (scale != NULL_RTX && ! CONSTANT_P (scale)))
>>  	{
>> -	  /* Its is not an address generation.	Probably we have no 3 op
>> +	  /* It is not an address generation.	Probably we have no 3 op
>>  	     add.  Last chance is to use 2-op add insn.	 */
>>  	  lra_assert (x != y && x != z);
>> -	  emit_move_insn (x, z);
>> -	  insn = gen_add2_insn (x, y);
>> +	  emit_move_insn (x, y);
>> +	  insn = gen_add2_insn (x, z);
>>  	  emit_insn (insn);
>>  	}
>>        else
>
> Could you add a comment to lra_emit_add saying why it has to be this
> way round (move y, add z)?

Ping.