From: Gabriel Dos Reis <gdr@cs.tamu.edu>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Count -Werror promoted warnings separately (PR middle-end/48087)
Date: Thu, 21 Mar 2013 15:47:00 -0000 [thread overview]
Message-ID: <87k3p021rc.fsf@gauss.cs.tamu.edu> (raw)
In-Reply-To: <20130321125235.GS12913@tucnak.redhat.com> (Jakub Jelinek's message of "Thu, 21 Mar 2013 13:52:35 +0100")
Jakub Jelinek <jakub@redhat.com> writes:
| Hi!
|
| This is a patch I had written two months ago, but concluded it to be too
| risky for 4.8 at that point.
|
| The issue this patch attempts to solve is that compiler behaves differently
| in some cases depending on if we've just warned about something or if
| -Werror has been in effect and that warning has been promoted to error.
| Of course the difference should be the exit code from the compiler and
| the wording of the warning resp. error, but various bits of code e.g. in the
| frontends check whether any errors have been reported already (or reported
| while parsing some construct etc.), and if they have been, act differently
| from the case when there haven't been any errors.
|
| The patch just counts the warnings promoted to errors in a different
| counter, werrorcount, and thus each place can actually decide if it wants to
| treat warnings promoted to errors as warnings, or as errors, or something
| else for its purposes.
|
| Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
It makes sense; patch OK. Thanks!
-- Gaby
prev parent reply other threads:[~2013-03-21 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 12:52 Jakub Jelinek
2013-03-21 15:47 ` Gabriel Dos Reis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3p021rc.fsf@gauss.cs.tamu.edu \
--to=gdr@cs.tamu.edu \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).