From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id DA5653858D20 for ; Thu, 11 Apr 2024 18:51:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA5653858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=baylibre.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DA5653858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712861523; cv=none; b=i1wntSLoL897AJpnhSa+cENm9zIIWFr9V5AB817TxJbNdhF5pY0/xIrLwamVOEMqHlyaJcwhr52wnwAA5xdgniEH+VfnYkRiTZkm8J7vqjdLgb0CmCU+tx8wDd0WqocYWkLkaGwW58K53jrqkCWSlGmCM7s8IYU9kD4b+6/Yeas= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712861523; c=relaxed/simple; bh=cuSICama7KSj7hw3Noq3jruSOHY/olw0RlZvbwrRsf8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=df+30ZXCBTRXYIVIK22ew/0cIzSy+pNAGb4CsgOCoS9yOmWUnGp2ntzjoWU9U/2mR7ZW00teWgugSB0+xKmcP8A1fgq/giAvzSdE1QMU8vqJyZ1zZxOFPERvBOwpcDFgeeOXCM8yB+0FFm230QLOyAkeE59shQBM3zsKHk5OPUI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-417db45fe01so1167355e9.1 for ; Thu, 11 Apr 2024 11:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1712861517; x=1713466317; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LhNhv3OpCXt6Ftozv5m+Ovq8Q7fXBbO95aypkBxWyzo=; b=K0R8ACe7UPQaSyvE8xpD/bX19niv5u+ZjJK1ZT+4YIen97kZlD1mYKY3a7MqChlZMy 7P3uIifM+Q8ufdtM/GZHRpgANhnnekJX6yYaZrOlKF0tIGgZndkqObCPWZ4mHWfdAva4 SVASY8/0tc6/azrqy7FmW6DSwJgT8WFsNUYqX7LT+kFXDzeiJcajGgMolGqwAH1qPkD6 J3uHVZ6FOkkD2VcqOZxhd+edQc4va3EptMvuLoDh+LpT58Hv42+NzljqUzDn668cyIB2 FXi255E6Sm/KavvnIqnW2NCjTHLMV9EYFmkba8RqHEQabIqdkQFpq3TBE7Md4Jrbvl5N BkKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712861517; x=1713466317; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LhNhv3OpCXt6Ftozv5m+Ovq8Q7fXBbO95aypkBxWyzo=; b=kRNlzAVz9Gddl8RIoUVgwhcCG9phZ7dLUDuPXZvZoJOwp/h/8M7Yo4jghhde65sgeu Gn1yf+pg6K+Ec2BfRloe4qxwgm8KNXvxfsNR/wYCJq9r0PXWUbfu9tvnuvMqKjGnLPgK 3YlqAle2pAhNr0PimeKxlH5C0DHbUpov49OWqVYMWbA8Wh/S2LHJpdwkslkeZa46CdEE nY4h/rIPc7iosExdIYDFV9e6I0Hyhrr4H6w9v/ekhmht+BaWHCg481l8bsp+Z6+N1VHI 4abU90po+74Ug+OHMvzp7zPRAmHYXOVgkQx2qHkuYRGv5azfB1cxvc2eEOuc37A/+kHn HTSw== X-Forwarded-Encrypted: i=1; AJvYcCWQWAU3w6AXAu6i3Jn7n7TyfdRQVyUYhLEDtUdyxQtfrOIhRQWXxUROMuuF3f6EK2+7IRNCEll3O7I3t9uLRvBhbBPRnjzEKg== X-Gm-Message-State: AOJu0YxI9gP6OGMGRiVrZc417gChaOX9IJ3b5HwbOWjsmmV3tzUpuVvV bhH7AYWG9WNUt9++w+d8ly6TiDA+0l3cnyZ2E+hCzgM7VuXglIce8bw/WvCBCvo= X-Google-Smtp-Source: AGHT+IH0R8ViItrsTZ9sTCubtqMnjQd3Cr8ikSndJIIefXXEwZuTs3QFgfGFBvDCXSr+ieBdyYbP9w== X-Received: by 2002:a05:600c:c13:b0:416:baf1:dd6a with SMTP id fm19-20020a05600c0c1300b00416baf1dd6amr510097wmb.12.1712861517416; Thu, 11 Apr 2024 11:51:57 -0700 (PDT) Received: from euler.schwinge.homeip.net (p200300c8b70ce600fbf8323f8abe0da4.dip0.t-ipconnect.de. [2003:c8:b70c:e600:fbf8:323f:8abe:da4]) by smtp.gmail.com with ESMTPSA id bg25-20020a05600c3c9900b004162d06768bsm6363294wmb.21.2024.04.11.11.51.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 11:51:57 -0700 (PDT) From: Thomas Schwinge To: Martin Jambor , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] contrib/check-params-in-docs.py: Ignore gcn-preferred-vectorization-factor In-Reply-To: References: <87ttkbmwx1.fsf@euler.schwinge.ddns.net> User-Agent: Notmuch/0.30+8~g47a4bad (https://notmuchmail.org) Emacs/29.2 (x86_64-pc-linux-gnu) Date: Thu, 11 Apr 2024 20:51:55 +0200 Message-ID: <87le5jenqs.fsf@euler.schwinge.ddns.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On 2024-04-11T19:52:51+0200, Martin Jambor wrote: > contrib/check-params-in-docs.py is a script that checks that all > options reported with ./gcc/xgcc -Bgcc --help=3Dparam are in > gcc/doc/invoke.texi and vice versa. Eh, first time I'm hearing about this one! (a) Shouldn't this be running as part of the GCC build process? > gcn-preferred-vectorization-factor is in the manual but normally not > reported by --help, probably because I do not have gcn offload > configured. No, because you've not been building GCC for GCN target. ;-P > This patch makes the script silently about this particular > fact. (b) Shouldn't we instead ignore any '--param's with "gcn" prefix, similar to how that's done for "skip aarch64 params"? (c) ..., and shouldn't we likewise skip any "x86" ones? (d) ..., or in fact any target specific ones, following after the generic section? (Easily achieved with a special marker in 'gcc/doc/invoke.texi', just before: The following choices of @var{name} are available on AArch64 targets: ..., and adjusting the 'takewhile' in 'contrib/check-params-in-docs.py' accordingly? Gr=C3=BC=C3=9Fe Thomas > I'll push the patch as obvious momentarily. > > Martin > > > contrib/ChangeLog: > > 2024-04-11 Martin Jambor > > * check-params-in-docs.py (ignored): Add > gcn-preferred-vectorization-factor. > --- > contrib/check-params-in-docs.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/check-params-in-docs.py b/contrib/check-params-in-do= cs.py > index 623c82284e2..f7879dd8e08 100755 > --- a/contrib/check-params-in-docs.py > +++ b/contrib/check-params-in-docs.py > @@ -45,7 +45,7 @@ parser.add_argument('params_output') >=20=20 > args =3D parser.parse_args() >=20=20 > -ignored =3D {'logical-op-non-short-circuit'} > +ignored =3D {'logical-op-non-short-circuit', 'gcn-preferred-vectorizatio= n-factor'} > params =3D {} >=20=20 > for line in open(args.params_output).readlines(): > --=20 > 2.44.0