From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 066053858C2C for ; Fri, 1 Dec 2023 16:24:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 066053858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 066053858C2C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::331 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701447851; cv=none; b=RVFXvOGVNNQylltx5tPSraS4uhV4sGrDV96v/3j3sMrVNn5zfB/7h4K+uUMMi38JdnOteZERb3P6zgiSBjt5dV80OyU8w0bToaKG2XtOMmyIDpxc5bE31MIdPI/ilUGHqvfNVMb4OApVwsEHH9SEhxggILnYe8nDqm97KdP7XiY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701447851; c=relaxed/simple; bh=3/XTIOViBN5i/ApsonuiDY6N1eu996Tp5SYqbVCAlNQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=csTrLnaDeVX7xmPaW0K6tQ0g8Gd5uOyjfXz4zkHqYML6iGyYAgVepxv2idhxUo4dV8klt9QqDaiTdVPB6/mmQuUrMYYY3jHQv3YX/pO0XATB833AGdAlvYp4G3Dr+nkhfk9nDP72RS38dxBj5hdJv9gzceRTc0ILHk6QFVojG5E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-409299277bbso21267665e9.2 for ; Fri, 01 Dec 2023 08:24:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1701447845; x=1702052645; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=EYB4Ze6QDEso//eQXjjaw1V91/iP96sOJuoGSvZOCu8=; b=aPBQzg7CMtcYwDHxQ0sB4y86bLMjjrQg7huIreF7ae21y8nMOKjuoKkopGJ1/nsP0v 0oPb/GVvanhT8Blokt1uLagzy1w1NM6me6MSiZetoRvCzL4S+uZMZM/gYsIf8DFapfrM Fs6YC3XWriJKZ+TtmUm0L8r4wMGR2w8eYe3pcrLqG/WTAF3aDHmsJk4mCDGnSBpBPvWf dOs9Dt0qfsAVxy/MEUiDB1C+Qx8VfSOVbbOqWfDaaTBNHTp5q+H36Bv4kbzgYyPAbXXd UK9fMwd3WTaksIWVJ1SARgISoeT2QmxjccwXoHg8EUJ6W7rBUapGCOc9t3DOryrwc1BQ U5SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701447845; x=1702052645; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EYB4Ze6QDEso//eQXjjaw1V91/iP96sOJuoGSvZOCu8=; b=muK5HoX4HeWFojLPSUvDPK/VWi5z76QAV0f6vu/r/2h72nUq/DjXpBVyjyy1Y4Fk7N c2m4WIiz4WU28PXj0NBxm1HIp/zSSmGkMWnTMTa0NXde5zh+nY5m57vBYck+nmeSLh2T asAO9wEvdOqwO8Vw3Fh6n5Qq7sUsBuHouyYmKSBJIY2I5yXVGTSLn1lpFnxhsas/iJKx 5cmPElJaiUOJDfezUd0zdoj3Oli5vJVPHlC5ysMR50n03I1ZDb6UKU52EYAaCPXNeUpe MfYFtISBx6VT/cAOwzmP42Mgdt5ui0mjWqUT1+DrSiKy9Zk9J3TU7J08sgwwm2HM71SO jP/g== X-Gm-Message-State: AOJu0Yym+ScaZ6isAIuQfaX2QawZbHxvNYyP6XSra61ANsdCt4o3U2na bjYMkrSYXAXA0oV35jkKL0oA65z6VAWZiDYp/IChig== X-Google-Smtp-Source: AGHT+IFsTjEXSHAwf1YlK0+NwnqNxUb/8wAQ5Pke48h4wDZ0FhNzbfiYiGwB86Vobgg2zFK4jKUiRA== X-Received: by 2002:a5d:518f:0:b0:332:e4ef:7ee8 with SMTP id k15-20020a5d518f000000b00332e4ef7ee8mr1015233wrv.61.1701447845496; Fri, 01 Dec 2023 08:24:05 -0800 (PST) Received: from poulhies-Precision-5550 ([2001:861:3382:1a90:e71c:33a3:592a:8794]) by smtp.gmail.com with ESMTPSA id z1-20020a5d4d01000000b00332ce0d7300sm4594787wrt.92.2023.12.01.08.24.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 08:24:05 -0800 (PST) References: <20231106110013.3862412-1-poulhies@adacore.com> User-agent: mu4e 1.10.1; emacs 28.1 From: Marc =?utf-8?Q?Poulhi=C3=A8s?= To: Marc =?utf-8?Q?Poulhi=C3=A8s?= Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] testsuite: require avx_runtime for some tests Date: Fri, 01 Dec 2023 17:23:53 +0100 In-reply-to: <20231106110013.3862412-1-poulhies@adacore.com> Message-ID: <87lead6gd7.fsf@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Marc Poulhi=C3=A8s writes: > These 3 tests fails parsing the 'vect' dump when not using -mavx. Make > the dependency explicit. > > gcc/testsuite/ChangeLog: > > * gcc.dg/vect/vect-ifcvt-18.c: Add dep on avx_runtime. > * gcc.dg/vect/vect-simd-clone-16f.c: Likewise. > * gcc.dg/vect/vect-simd-clone-18f.c: Likewise. > --- > Tested on x86_64-linux and x86_64-elf. > > Ok for master? > > gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c | 3 ++- > gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c | 4 ++-- > gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c | 4 ++-- > 3 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c b/gcc/testsuite/gc= c.dg/vect/vect-ifcvt-18.c > index c1d3c27d819..607194496e9 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c > @@ -1,6 +1,7 @@ > /* { dg-require-effective-target vect_condition } */ > /* { dg-require-effective-target vect_float } */ > -/* { dg-additional-options "-Ofast -mavx" { target avx_runtime } } */ > +/* { dg-require-effective-target avx_runtime } */ > +/* { dg-additional-options "-Ofast -mavx" } */ > > > int A0[4] =3D {36,39,42,45}; > diff --git a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c b/gcc/testsu= ite/gcc.dg/vect/vect-simd-clone-16f.c > index 7cd29e894d0..c6615dc626d 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c > @@ -1,6 +1,6 @@ > /* { dg-require-effective-target vect_simd_clones } */ > -/* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask= =3D0" } */ > -/* { dg-additional-options "-mavx" { target avx_runtime } } */ > +/* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask= =3D0 -mavx" } */ > +/* { dg-require-effective-target avx_runtime } */ > /* { dg-additional-options "-mno-avx512f" { target { { i?86*-*-* x86_64-= *-* } && { ! lp64 } } } } */ > > #define TYPE __INT64_TYPE__ > diff --git a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c b/gcc/testsu= ite/gcc.dg/vect/vect-simd-clone-18f.c > index 4dd51381d73..787b918d0c4 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c > @@ -1,6 +1,6 @@ > /* { dg-require-effective-target vect_simd_clones } */ > -/* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask= =3D0" } */ > -/* { dg-additional-options "-mavx" { target avx_runtime } } */ > +/* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask= =3D0 -mavx" } */ > +/* { dg-require-effective-target avx_runtime } */ > /* { dg-additional-options "-mno-avx512f" { target { { i?86*-*-* x86_64-= *-* } && { ! lp64 } } } } */ > > #define TYPE __INT64_TYPE__ Ping. Thanks, Marc