* [PATCH] testsuite: require avx_runtime for some tests
@ 2023-11-06 10:59 Marc Poulhiès
2023-12-01 16:23 ` Marc Poulhiès
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Marc Poulhiès @ 2023-11-06 10:59 UTC (permalink / raw)
To: gcc-patches; +Cc: Marc Poulhiès
These 3 tests fails parsing the 'vect' dump when not using -mavx. Make
the dependency explicit.
gcc/testsuite/ChangeLog:
* gcc.dg/vect/vect-ifcvt-18.c: Add dep on avx_runtime.
* gcc.dg/vect/vect-simd-clone-16f.c: Likewise.
* gcc.dg/vect/vect-simd-clone-18f.c: Likewise.
---
Tested on x86_64-linux and x86_64-elf.
Ok for master?
gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c | 3 ++-
gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c | 4 ++--
gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c | 4 ++--
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c b/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c
index c1d3c27d819..607194496e9 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c
@@ -1,6 +1,7 @@
/* { dg-require-effective-target vect_condition } */
/* { dg-require-effective-target vect_float } */
-/* { dg-additional-options "-Ofast -mavx" { target avx_runtime } } */
+/* { dg-require-effective-target avx_runtime } */
+/* { dg-additional-options "-Ofast -mavx" } */
int A0[4] = {36,39,42,45};
diff --git a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c
index 7cd29e894d0..c6615dc626d 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c
@@ -1,6 +1,6 @@
/* { dg-require-effective-target vect_simd_clones } */
-/* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0" } */
-/* { dg-additional-options "-mavx" { target avx_runtime } } */
+/* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0 -mavx" } */
+/* { dg-require-effective-target avx_runtime } */
/* { dg-additional-options "-mno-avx512f" { target { { i?86*-*-* x86_64-*-* } && { ! lp64 } } } } */
#define TYPE __INT64_TYPE__
diff --git a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c
index 4dd51381d73..787b918d0c4 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c
@@ -1,6 +1,6 @@
/* { dg-require-effective-target vect_simd_clones } */
-/* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0" } */
-/* { dg-additional-options "-mavx" { target avx_runtime } } */
+/* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0 -mavx" } */
+/* { dg-require-effective-target avx_runtime } */
/* { dg-additional-options "-mno-avx512f" { target { { i?86*-*-* x86_64-*-* } && { ! lp64 } } } } */
#define TYPE __INT64_TYPE__
--
2.42.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] testsuite: require avx_runtime for some tests
2023-11-06 10:59 [PATCH] testsuite: require avx_runtime for some tests Marc Poulhiès
@ 2023-12-01 16:23 ` Marc Poulhiès
2023-12-01 17:35 ` Mike Stump
2023-12-08 9:07 ` Thomas Schwinge
2 siblings, 0 replies; 5+ messages in thread
From: Marc Poulhiès @ 2023-12-01 16:23 UTC (permalink / raw)
To: Marc Poulhiès; +Cc: gcc-patches
Marc Poulhiès <poulhies@adacore.com> writes:
> These 3 tests fails parsing the 'vect' dump when not using -mavx. Make
> the dependency explicit.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/vect/vect-ifcvt-18.c: Add dep on avx_runtime.
> * gcc.dg/vect/vect-simd-clone-16f.c: Likewise.
> * gcc.dg/vect/vect-simd-clone-18f.c: Likewise.
> ---
> Tested on x86_64-linux and x86_64-elf.
>
> Ok for master?
>
> gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c | 3 ++-
> gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c | 4 ++--
> gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c | 4 ++--
> 3 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c b/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c
> index c1d3c27d819..607194496e9 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c
> @@ -1,6 +1,7 @@
> /* { dg-require-effective-target vect_condition } */
> /* { dg-require-effective-target vect_float } */
> -/* { dg-additional-options "-Ofast -mavx" { target avx_runtime } } */
> +/* { dg-require-effective-target avx_runtime } */
> +/* { dg-additional-options "-Ofast -mavx" } */
>
>
> int A0[4] = {36,39,42,45};
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c
> index 7cd29e894d0..c6615dc626d 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c
> @@ -1,6 +1,6 @@
> /* { dg-require-effective-target vect_simd_clones } */
> -/* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0" } */
> -/* { dg-additional-options "-mavx" { target avx_runtime } } */
> +/* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0 -mavx" } */
> +/* { dg-require-effective-target avx_runtime } */
> /* { dg-additional-options "-mno-avx512f" { target { { i?86*-*-* x86_64-*-* } && { ! lp64 } } } } */
>
> #define TYPE __INT64_TYPE__
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c
> index 4dd51381d73..787b918d0c4 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c
> @@ -1,6 +1,6 @@
> /* { dg-require-effective-target vect_simd_clones } */
> -/* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0" } */
> -/* { dg-additional-options "-mavx" { target avx_runtime } } */
> +/* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0 -mavx" } */
> +/* { dg-require-effective-target avx_runtime } */
> /* { dg-additional-options "-mno-avx512f" { target { { i?86*-*-* x86_64-*-* } && { ! lp64 } } } } */
>
> #define TYPE __INT64_TYPE__
Ping.
Thanks,
Marc
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] testsuite: require avx_runtime for some tests
2023-11-06 10:59 [PATCH] testsuite: require avx_runtime for some tests Marc Poulhiès
2023-12-01 16:23 ` Marc Poulhiès
@ 2023-12-01 17:35 ` Mike Stump
2023-12-08 9:07 ` Thomas Schwinge
2 siblings, 0 replies; 5+ messages in thread
From: Mike Stump @ 2023-12-01 17:35 UTC (permalink / raw)
To: Marc Poulhiès; +Cc: gcc-patches
On Nov 6, 2023, at 2:59 AM, Marc Poulhiès <poulhies@adacore.com> wrote:
>
> These 3 tests fails parsing the 'vect' dump when not using -mavx. Make
> the dependency explicit.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/vect/vect-ifcvt-18.c: Add dep on avx_runtime.
> * gcc.dg/vect/vect-simd-clone-16f.c: Likewise.
> * gcc.dg/vect/vect-simd-clone-18f.c: Likewise.
> ---
> Tested on x86_64-linux and x86_64-elf.
>
> Ok for master?
Ok.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] testsuite: require avx_runtime for some tests
2023-11-06 10:59 [PATCH] testsuite: require avx_runtime for some tests Marc Poulhiès
2023-12-01 16:23 ` Marc Poulhiès
2023-12-01 17:35 ` Mike Stump
@ 2023-12-08 9:07 ` Thomas Schwinge
2023-12-08 9:08 ` Marc Poulhiès
2 siblings, 1 reply; 5+ messages in thread
From: Thomas Schwinge @ 2023-12-08 9:07 UTC (permalink / raw)
To: Marc Poulhiès
Cc: gcc-patches, Mike Stump, Andrew Stubbs, Julian Brown, Richard Biener
Hi Marc!
On 2023-11-06T11:59:18+0100, Marc Poulhiès <poulhies@adacore.com> wrote:
> These 3 tests fails parsing the 'vect' dump when not using -mavx. Make
> the dependency explicit.
But that means that the tests are now enabled *only* for
effective-target 'avx_runtime', so, for example, on GCN I see:
-PASS: gcc.dg/vect/vect-ifcvt-18.c (test for excess errors)
-PASS: gcc.dg/vect/vect-ifcvt-18.c execution test
+UNSUPPORTED: gcc.dg/vect/vect-ifcvt-18.c
-PASS: gcc.dg/vect/vect-simd-clone-16f.c (test for excess errors)
-PASS: gcc.dg/vect/vect-simd-clone-16f.c execution test
-PASS: gcc.dg/vect/vect-simd-clone-16f.c scan-tree-dump-times vect "[\\n\\r] [^\\n]* = foo\\.simdclone" 2
+UNSUPPORTED: gcc.dg/vect/vect-simd-clone-16f.c
-PASS: gcc.dg/vect/vect-simd-clone-18f.c (test for excess errors)
-PASS: gcc.dg/vect/vect-simd-clone-18f.c execution test
-PASS: gcc.dg/vect/vect-simd-clone-18f.c scan-tree-dump-times vect "[\\n\\r] [^\\n]* = foo\\.simdclone" 2
+UNSUPPORTED: gcc.dg/vect/vect-simd-clone-18f.c
..., which was not the intention, I suppose?
Grüße
Thomas
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/vect/vect-ifcvt-18.c: Add dep on avx_runtime.
> * gcc.dg/vect/vect-simd-clone-16f.c: Likewise.
> * gcc.dg/vect/vect-simd-clone-18f.c: Likewise.
> ---
> Tested on x86_64-linux and x86_64-elf.
>
> Ok for master?
>
> gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c | 3 ++-
> gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c | 4 ++--
> gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c | 4 ++--
> 3 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c b/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c
> index c1d3c27d819..607194496e9 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-ifcvt-18.c
> @@ -1,6 +1,7 @@
> /* { dg-require-effective-target vect_condition } */
> /* { dg-require-effective-target vect_float } */
> -/* { dg-additional-options "-Ofast -mavx" { target avx_runtime } } */
> +/* { dg-require-effective-target avx_runtime } */
> +/* { dg-additional-options "-Ofast -mavx" } */
>
>
> int A0[4] = {36,39,42,45};
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c
> index 7cd29e894d0..c6615dc626d 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c
> @@ -1,6 +1,6 @@
> /* { dg-require-effective-target vect_simd_clones } */
> -/* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0" } */
> -/* { dg-additional-options "-mavx" { target avx_runtime } } */
> +/* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0 -mavx" } */
> +/* { dg-require-effective-target avx_runtime } */
> /* { dg-additional-options "-mno-avx512f" { target { { i?86*-*-* x86_64-*-* } && { ! lp64 } } } } */
>
> #define TYPE __INT64_TYPE__
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c
> index 4dd51381d73..787b918d0c4 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c
> @@ -1,6 +1,6 @@
> /* { dg-require-effective-target vect_simd_clones } */
> -/* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0" } */
> -/* { dg-additional-options "-mavx" { target avx_runtime } } */
> +/* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0 -mavx" } */
> +/* { dg-require-effective-target avx_runtime } */
> /* { dg-additional-options "-mno-avx512f" { target { { i?86*-*-* x86_64-*-* } && { ! lp64 } } } } */
>
> #define TYPE __INT64_TYPE__
> --
> 2.42.0
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] testsuite: require avx_runtime for some tests
2023-12-08 9:07 ` Thomas Schwinge
@ 2023-12-08 9:08 ` Marc Poulhiès
0 siblings, 0 replies; 5+ messages in thread
From: Marc Poulhiès @ 2023-12-08 9:08 UTC (permalink / raw)
To: Thomas Schwinge
Cc: gcc-patches, Mike Stump, Andrew Stubbs, Julian Brown, Richard Biener
Thomas Schwinge <thomas@codesourcery.com> writes:
> Hi Marc!
>
> On 2023-11-06T11:59:18+0100, Marc Poulhiès <poulhies@adacore.com> wrote:
>> These 3 tests fails parsing the 'vect' dump when not using -mavx. Make
>> the dependency explicit.
>
> But that means that the tests are now enabled *only* for
> effective-target 'avx_runtime', so, for example, on GCN I see:
>
> -PASS: gcc.dg/vect/vect-ifcvt-18.c (test for excess errors)
> -PASS: gcc.dg/vect/vect-ifcvt-18.c execution test
> +UNSUPPORTED: gcc.dg/vect/vect-ifcvt-18.c
>
> -PASS: gcc.dg/vect/vect-simd-clone-16f.c (test for excess errors)
> -PASS: gcc.dg/vect/vect-simd-clone-16f.c execution test
> -PASS: gcc.dg/vect/vect-simd-clone-16f.c scan-tree-dump-times vect "[\\n\\r] [^\\n]* = foo\\.simdclone" 2
> +UNSUPPORTED: gcc.dg/vect/vect-simd-clone-16f.c
>
> -PASS: gcc.dg/vect/vect-simd-clone-18f.c (test for excess errors)
> -PASS: gcc.dg/vect/vect-simd-clone-18f.c execution test
> -PASS: gcc.dg/vect/vect-simd-clone-18f.c scan-tree-dump-times vect "[\\n\\r] [^\\n]* = foo\\.simdclone" 2
> +UNSUPPORTED: gcc.dg/vect/vect-simd-clone-18f.c
>
> ..., which was not the intention, I suppose?
Hello Thomas,
No, that was an oversight, Jakub also spotted that in another patch.
I'll revert it now.
Sorry for the inconvenience,
Marc
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-12-08 9:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-06 10:59 [PATCH] testsuite: require avx_runtime for some tests Marc Poulhiès
2023-12-01 16:23 ` Marc Poulhiès
2023-12-01 17:35 ` Mike Stump
2023-12-08 9:07 ` Thomas Schwinge
2023-12-08 9:08 ` Marc Poulhiès
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).