From: Gaius Mulley <gaiusmod2@gmail.com>
To: Iain Sandoe <iains.gcc@gmail.com>
Cc: gcc-patches@gcc.gnu.org, iain@sandoe.co.uk
Subject: Re: [PATCH] Modula-2, testsuite: Remove use of concatenated paths.
Date: Sun, 22 Jan 2023 16:28:11 +0000 [thread overview]
Message-ID: <87lelu355w.fsf@debian> (raw)
In-Reply-To: <20230122161059.96036-1-iain@sandoe.co.uk> (Iain Sandoe's message of "Sun, 22 Jan 2023 16:10:59 +0000")
Iain Sandoe <iains.gcc@gmail.com> writes:
> tested on x86_64-darwin21 with an updated compiler that does not support
> the path concatentation and on an unpatched trunk.
> OK for trunk?
> thanks
> Iain
>
> --- 8< ---
>
> The original implementation for Modula-2 search paths allows things like
> '-I/path/a:/path/b'. Such paths are not compatible with the rest of the
> compiler (in particular, the preprocessor, which Modula-2 uses). In
> preparation for removing that idiom, this patch rewrites the cases in the
> testsuite and removes string processing where possible from lists of paths.
>
> TODO: There are some apparent discrepancies and/or extraneous insertions
> of partial include paths (especially in gm2_init_log, gm2_init_iso and
> gm2_init_pim) - to be handled in some future patch.
>
> Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
>
> gcc/testsuite/ChangeLog:
>
> * gm2/case/pass/case-pass.exp: Update for removal of concatenated
> paths.
> * gm2/complex/pass/complex-pass.exp: Likewise.
> * gm2/coroutines/pim/run/pass/coroutines-pim-run-pass.exp: Likewise.
> * gm2/iso/analysis/fail/iso-analysis-fail.xp: Likewise.
> * gm2/iso/check/fail/iso-check-fail.exp: Likewise.
> * gm2/iso/fail/iso-fail.exp: Likewise.
> * gm2/iso/pass/iso-pass.exp: Likewise.
> * gm2/isolib/run/pass/isolib-run-pass.exp: Likewise.
> * gm2/pim/fail/pim-fail.exp: Likewise.
> * gm2/pim/pass/pim-pass.exp: Likewise.
> * gm2/pimlib/logitech/run/pass/pimlib-logitech-run-pass.exp: Likewise.
> * gm2/pimlib/pass/pimlib-pass.exp: Likewise.
> * gm2/pimlib/run/pass/pimlib-run-pass.exp: Likewise.
> * gm2/projects/iso/run/pass/halma/projects-iso-run-pass-halma.exp: Likewise.
> * gm2/projects/iso/run/pass/hello/projects-iso-run-pass-hello.exp: Likewise.
> * gm2/projects/log/run/pass/hello/projects-log-run-pass-hello.exp: Likewise.
> * gm2/projects/pim/run/pass/hello/projects-pim-run-pass-hello.exp: Likewise.
> * gm2/recover/pass/recover-pass.exp: Likewise.
> * gm2/switches/makeall/fail/switches-makeall-fail.exp: Likewise.
> * gm2/switches/makeall/pass/switches-makeall-pass.exp: Likewise.
> * gm2/switches/none/run/pass/gm2-none.exp: Likewise.
> * gm2/switches/pim2/run/pass/switches-pim2-run-pass.exp: Likewise.
> * gm2/ulmlib/pass/ulmlib-pass.exp: Likewise.
> * gm2/ulmlib/std/pass/ulmlib-std-pass.exp: Likewise.
> * gm2/ulmlib/sys/pass/ulmlib-sys-pass.exp: Likewise.
> * lib/gm2.exp: Make the paths list a mandatory entry for each gm2_init_xxx
> function. Remove the use of concatenated include and library paths.
> Remove string processing where possible.
LGTM - many thanks,
regards,
Gaius
prev parent reply other threads:[~2023-01-22 16:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-22 16:10 Iain Sandoe
2023-01-22 16:28 ` Gaius Mulley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lelu355w.fsf@debian \
--to=gaiusmod2@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
--cc=iains.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).