From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 636F83858D20 for ; Fri, 20 Jan 2023 16:32:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 636F83858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.97,232,1669104000"; d="scan'208,223";a="94208070" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 20 Jan 2023 08:32:06 -0800 IronPort-SDR: a3wU0kp3aWNRBeulubC8YEWBfqp9iTChrI7l4srjUAaJ5e///1pkY3eqkS8xTjghHiWY19xKAF HTfbQF6rlk+MTHQWH5WzT1C07FbaS2imPvhCtzCVD+7tYB1WWRUSNovFwj5Mi+/107umXovpVC HXRQtHjSpmGRyZauklID5NE+uvtSkeZH4FZUttdyg4sKCGeQsNCXn/uEmBWxF3Zbk8+aPVvh7B m4mHwPeXi3OkP3kCZMqZAlqpfKrP4NEw+7l4QPyNx7upsKS1Ufqcg9TC3/MOX2vm3lQ4OKFAfi 1u8= From: Thomas Schwinge To: Kwok Cheung Yeung , CC: Andrew Stubbs , Tobias Burnus Subject: [og12] Fix 'libgomp.c/simd-math-1.c' configuration, again (was: [og12] Fix 'libgomp.c/simd-math-1.c' configuration (was: [OG12] [committed] amdgcn: Enable SIMD vectorization of math library functions)) In-Reply-To: <87wn5h5m11.fsf@euler.schwinge.homeip.net> References: <87wn5h5m11.fsf@euler.schwinge.homeip.net> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Fri, 20 Jan 2023 17:31:58 +0100 Message-ID: <87lelxdv5t.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-13.mgc.mentorg.com (139.181.222.13) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi! On 2023-01-20T15:16:26+0100, I wrote: > On 2022-11-02T00:50:40+0000, Kwok Cheung Yeung wro= te: >> I have committed the following patches onto the devel/omp/gcc-12 >> development branch: >> >> 863579c4e30 amdgcn: Enable SIMD vectorization of math functions > > I've pushed to devel/omp/gcc-12 > commit e7d4bcb974915bfe95be6c385641fc66a4201581 > "Fix 'libgomp.c/simd-math-1.c' configuration", see attached. I've pushed to devel/omp/gcc-12 commit bbd4eb1772893ba99aa23a4eaf8950415624964e "Fix 'libgomp.c/simd-math-1.c' configuration, again", see attached. Thanks for the report, Tobias! Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename="0001-Fix-libgomp.c-simd-math-1.c-configuration-again.patch" >From bbd4eb1772893ba99aa23a4eaf8950415624964e Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Fri, 20 Jan 2023 17:17:21 +0100 Subject: [PATCH] Fix 'libgomp.c/simd-math-1.c' configuration, again Tobias pointed out that as of my recent og12 commit e7d4bcb974915bfe95be6c385641fc66a4201581 "Fix 'libgomp.c/simd-math-1.c' configuration", in GCC configurations without GCN offloading configured, we'd get: xgcc: error: GCC is not configured to support 'amdgcn-amdhsa' as '-foffload=' argument ("Interestingly", GCC doesn't complain for '-foffload-options=-lm' if there are no offload targets configured...) libgomp/ * testsuite/libgomp.c/simd-math-1.c: Fix configuration, again. --- libgomp/ChangeLog.omp | 2 ++ libgomp/testsuite/libgomp.c/simd-math-1.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libgomp/ChangeLog.omp b/libgomp/ChangeLog.omp index 0f8fca4e71c..134d450f44a 100644 --- a/libgomp/ChangeLog.omp +++ b/libgomp/ChangeLog.omp @@ -1,5 +1,7 @@ 2023-01-20 Thomas Schwinge + * testsuite/libgomp.c/simd-math-1.c: Fix configuration, again. + * testsuite/libgomp.oacc-c-c++-common/abort-3.c: Force '--param openacc-kernels=parloops'. diff --git a/libgomp/testsuite/libgomp.c/simd-math-1.c b/libgomp/testsuite/libgomp.c/simd-math-1.c index 1ebdccccfeb..ea629696e55 100644 --- a/libgomp/testsuite/libgomp.c/simd-math-1.c +++ b/libgomp/testsuite/libgomp.c/simd-math-1.c @@ -3,7 +3,7 @@ /* { dg-do run } */ /* { dg-options "-O2 -ftree-vectorize -fno-math-errno" } */ -/* { dg-additional-options -foffload-options=amdgcn-amdhsa=-mstack-size=3000000 } */ +/* { dg-additional-options -foffload-options=amdgcn-amdhsa=-mstack-size=3000000 { target offload_target_amdgcn } } */ /* { dg-additional-options -foffload-options=-lm } */ #undef PRINT_RESULT -- 2.25.1 --=-=-=--