From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id DDC5B388BC9F for ; Thu, 15 Dec 2022 10:14:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DDC5B388BC9F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BF2QkJa028723; Thu, 15 Dec 2022 10:14:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=vY+94dciskUCAig1FXkTdmLh8h0XNrDB5dlFALRSwZ4=; b=L2hVNhPFR2cdo/T7aJdUQN2sS9+F4i0wPyhlAzTxwKHI/RbC9eOKq6FPx2wkq9Uu2jQy 0GjJrj3EJRbbiqpobGOxKvq/kW1ZCtXkSDalivUK3WxM6ByGOgYHFPIxGO6QItu0G4S4 dx7M7TUlfxO/V7td2ZreX1hxmITR4MxP65MM1A/dxgrWR2ql0umzySk78m/+xTHyyvbi OAg/yJ6fanspReBBegZrKZQr3UJzEZM5Gh8mLpNEVpX43rvF3RnZEb0W5ARPJ+LnGwHU LYQrRyzSXt6QwJOQtmSqcPfx/P59OxC6GG3ar868R0uY5Ez8zt5jabuvLt6m8mEYOjp1 bg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3meyex4n2v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Dec 2022 10:14:33 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2BF9UMw7031135; Thu, 15 Dec 2022 10:14:32 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2172.outbound.protection.outlook.com [104.47.59.172]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3meyeqdq7r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Dec 2022 10:14:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A48S4D8kXWOrs6FHWAYNnL7F7xIjMjE/LakdlGqrljyc7jPFYvayhjIYmzwwoy1C/okuMwyGqL/tYAHD7C2ynu8ZuB0oeH4fO6eGBumEpxiN573wDnvm8kv9KztvCgQIBPlHQlrxLEjXS/RkvqjWwgYFyXPrhXYeiTroUnyVvwZJmDJ3SAMAER4GPKvle/a71Xhj0Y+IVbaC6r/kQ0Pm5z3kpf8KSfyAe5tH6J0A7wVuSXxUyUkFiTcU54Nm5o/JERRpGbdYc3wQITVaYvxV2k13lPT0ORF1XzP8CBGQ5RfEf5oWmAEiRRf0l+uZURGZUpDf1vImTDw9AbyWB+h5Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vY+94dciskUCAig1FXkTdmLh8h0XNrDB5dlFALRSwZ4=; b=XAi/U8/as9f8RyUlBX+wvmQZS+iDPkYvM9Sgw2q4LNtDeovPRgEuiCzKb7FahkDq/5I+Y55nLiIDv/00jkEZJwy7POh7WW2IIlZIdiqeHox/xqfLBaYPNMvBJ/GAmJSA1WMRBZQH+iWzldonXbWZWkIFx0zo7HFH12FhP/YVBqxn3fiWVaff+1s3U8P7fTgV4m+qnM7ggsfB2NDfYmyLbnvGTmkr2Q0hoGYrznrp3+kW6NwGuoTmpwsG3cH3N9Ja2wBnGRF1GgI46eesKm9ffTUPClAtVXgK8PZ0ovOI5UeNfd0Gzx+W6QCNYY24xlHR8pJb1SUyUxqQOiqxJz1v0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vY+94dciskUCAig1FXkTdmLh8h0XNrDB5dlFALRSwZ4=; b=FiGeCDzWrDGDnAJd3aW5YZQDnO0ST4uH0WDppYONTvMLIarspTURO61kehlCP/B3vhLSomRhsP9sWOkWuZPXCvBqMvYwZ8QqoAKEWKvNW6dYYwi61MCV9mxKMw2qFUWZI1XHsGcgYOGirhGumJ1IQBFTc3jUGDEahm7z1Dr6Em0= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by DS7PR10MB4896.namprd10.prod.outlook.com (2603:10b6:5:3a0::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.12; Thu, 15 Dec 2022 10:14:31 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::8681:5931:e558:2638]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::8681:5931:e558:2638%7]) with mapi id 15.20.5880.019; Thu, 15 Dec 2022 10:14:30 +0000 References: <20221202175225.2780-1-cupertino.miranda@oracle.com> <20221202175225.2780-3-cupertino.miranda@oracle.com> <795fde7f-5bde-d1a5-e790-b15774effd1c@gmail.com> <875yen5ib4.fsf@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: Jeff Law Cc: gcc-patches@gcc.gnu.org, jose.marchesi@oracle.com Subject: Re: [PATCH 2/2] Corrected pr25521.c target matching. In-reply-to: <875yen5ib4.fsf@oracle.com> Date: Thu, 15 Dec 2022 10:14:26 +0000 Message-ID: <87len92cu5.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0538.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:319::8) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|DS7PR10MB4896:EE_ X-MS-Office365-Filtering-Correlation-Id: af4885a4-540f-4971-bd41-08dade8527da X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KKOJ40KbMrEdmcJW77/9ZtMMEuhI26ABDbui9HmYTG+x9IidMRDKEjsxYCp3c9A0Dg8bnqoXqg/7O3tUZgg+wK6YIG6URCsJTuYVmr4qUygOJU4XONcmosQAoUHdpD5aE46TLrp1D/VtgbYztvzYu8MduW1m18ADRS4B1mKTU+XjcFrmuZx0hHMAiFe3N3B9R6f9bmayj64bf3GkudXmhhA5d8TVLvYQkvyEoq2G6jDGHn5H2zlIe/p/ceOgToRN/sRBR20aZqymHDpSuHPrTxa2y37ucBnBGtmIVIb5j1p48Ejhlxv+WrGur94Fr+sBVvfLmyipVtZRAgMpqUdBtfHX3D61L07cYScaKFNtakqUXkIqqS+utonZm8tGIpkIL/TpsED9KHiXfIVLkM2rljYEdGFPTiZEEo7vvz6+lWss+Qo166nLdvImNRNdjutcJ3o4uxoAiJCgWK7ILoNurCQtj0CzVFTX391zPJ8RR0LKca3GLdUYyVUdlOq5EfpDoa+zoj5Y9AWDGkcCGNGU1+NlLR6qKwKG4zETF1AFqALteg3B68Otx23czw0g6gdy+5j/wI9Jsmjv6XD4ueHLZ3Bk6oJGe74qjFVInuXStBItQyqs0haLWwHQFlNMT/nGKExvpPjo0TTACTcvMO7EUQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(136003)(366004)(39860400002)(346002)(451199015)(36756003)(316002)(6916009)(2906002)(478600001)(83380400001)(6486002)(86362001)(6506007)(6666004)(107886003)(2616005)(6512007)(186003)(53546011)(8936002)(38100700002)(44832011)(66476007)(66556008)(8676002)(66946007)(4326008)(41300700001)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tRl31h5JdhGU9ljwVRCdqZlHULfkjOePw28p2BWEkvRT3gt8WPubzuyhih2U?= =?us-ascii?Q?sFi2H3B+U0UCOcxl+/x9Cx9qcXlMoLRrYibVmASfkr2dKlowY65ihZIG4vbX?= =?us-ascii?Q?Aom5m1INGE/T3YkEz/Yd3xX6BEd+oNLe2j5wlm4Sm4IwI6q0UUbLlopbtkx7?= =?us-ascii?Q?QSasNHfr9B3WCZG0AIlRml5ERrCD3dsD8qWpaE3ZqEY4l59aluud8EuC3zlt?= =?us-ascii?Q?+X45O+ka3HwsaIkHmKVSnBD8K9K7UH0fEkF1gtVgBlTjwaWwQEBUx83SZa9C?= =?us-ascii?Q?nJMu55aykdvYa/T1zIixTts00O6d2m9OAkYJGk85tEzEakt90f41pWNiVzBy?= =?us-ascii?Q?id75z+NlZyjdPZ15nb0hcFjTsGTMyloaGGWqLleq7hnWXIDN8EY9xtBLL42q?= =?us-ascii?Q?Dvr7gJev5D3B+z22GVmY51dTCgMUKOHAyClFdmAKmkaPxGK5ZCRLsD/mciwl?= =?us-ascii?Q?n0yPQWM/GU26tRvIpOCSvkqm6wSELM2cs3ct/sGQATWk2Pyf8UfmjCenfgRU?= =?us-ascii?Q?7rtBPQLGVJtAm/4CAT+cJ0ebx2tlUKmT8ffT4Cx0KnhxXQCugHNVW9AvN9hX?= =?us-ascii?Q?Ai1FFnpyWXr2gYk74SN+Vpp4urGCc2x2WJATCWLB5mougFhoBNB30WUou/Bf?= =?us-ascii?Q?R4+2zF13VGt38BlLpdmuXaIRu0b7dn6auNB9d80fKyaIeEugdNL4eq2zDOYM?= =?us-ascii?Q?m41CfnHvBB4dny7vpDPC/ihizN6QqKNrGZ+dLL5W0TUoRL6QDCwJIRrocHoy?= =?us-ascii?Q?o905ZYjrbERNaYjKx6zca9yuPQ8uP9hd2vPvAyfzOrz1O+nOncv0cJZcdr4A?= =?us-ascii?Q?jRPjqkiNBm7CfFDU4k5jEJ+ekBljzWqmZFeTKL1e5dkVGqXUwYmp2729FCoH?= =?us-ascii?Q?Kl+7fxztbFBiM+DkrJ9ixELOhmtIniQ/mdIG1zY2Y2E6yMZyPU555yoAUgzO?= =?us-ascii?Q?gYPTs8q00e2PBLXl7fUbQFqp9pPRvreUZe9L+z1h37AIviTJrUf5b61akdr0?= =?us-ascii?Q?50K0nnDsX7Rq9cU/YXJ1hLmPCpINLTex5SlcEB7yy4Cv+gMaAm6cySdZspqm?= =?us-ascii?Q?gilSPpifs5x4Tq6A7RLWu1b4KCNjzZDGVW44MPYSNAjzWVkw9QLLTB061ARP?= =?us-ascii?Q?2jLwEoNjurhtkU3N4FO1oPD6aw/TR23zpTt6aKFze+H9u07i6T9Yk7q1UJf1?= =?us-ascii?Q?vDkg3TlcfCjlWP5L+b11ubbQhycFuZsnlNFvFK19HjFJ1mL2ByMgOpH5iVEg?= =?us-ascii?Q?OIlSvvhpUHelmsAZZRIxvq510FP4Ny6+oG51Wo0F4uwlJfjG8HQFgFIXukG0?= =?us-ascii?Q?9RnqMYXqS+ZJAikpOcoqUfsMDGpCRvKUigrfAPVFuE3mkKFZm5cL+GuWyYnQ?= =?us-ascii?Q?45JmD+SZF2qNVGXlaMvixKs2Lz6P0RS2JSpPQo4FzCI+6kalMb7+5dYZm4Lq?= =?us-ascii?Q?QusLHDk8RPmU3JXRjKE4AlLomuxuMrik9zhYHtl3n913/vcln64y5FrXTRxs?= =?us-ascii?Q?Pq2aJnxHbZ+WmxwcEsyCx8oqzQMmgp3w5C4s/CC9tDpkJg/5rrjD46sbZPBQ?= =?us-ascii?Q?zTHDtOWFO7wrgwuNwzt1oRZGpn+JayHrHkA7RaIoiH2aDcs7U2bAvM/C0Qfk?= =?us-ascii?Q?i5kYL/J1u2V/RgfN5vfIfr4=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: af4885a4-540f-4971-bd41-08dade8527da X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2022 10:14:30.8884 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ncNwK0gf/Rmv6TcewLqy1D6shKqnSTA5AxWK5xWagg4Lan1KnD97V4I+4LRk2QiQYX7PF5XRqOuSqb4r6qc23IjMeByme2poNcBcDxGbTXA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4896 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-15_05,2022-12-14_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212150080 X-Proofpoint-GUID: iLGYZFNnjm29ZlNm8-9AHDdFTqKdlUJ2 X-Proofpoint-ORIG-GUID: iLGYZFNnjm29ZlNm8-9AHDdFTqKdlUJ2 X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: gentle ping Cupertino Miranda writes: >> On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote: >>> This commit is a follow up of bugzilla #107181. >>> The commit /a0aafbc/ changed the default implementation of the >>> SELECT_SECTION hook in order to match clang/llvm behaviour w.r.t the >>> placement of `const volatile' objects. >>> However, the following targets use target-specific selection functions >>> and they choke on the testcase pr25521.c: >>> *rx - target sets its const variables as '.section C,"a",@progbits'. >> That's presumably a constant section. We should instead twiddle the test to >> recognize that section. > > Although @progbits is indeed a constant section, I believe it is > more interesting to detect if the `rx' starts selecting more > standard sections instead of the current @progbits. > That was the reason why I opted to XFAIL instead of PASSing it. > Can I keep it as such ? > >> >>> *powerpc - its 32bit version is eager to allocate globals in .sdata >>> sections. >>> Normally, one can expect for the variable to be allocated in .srodata, >>> however, in case of powerpc-*-* or powerpc64-*-* (with -m32) >>> 'targetm.have_srodata_section == false' and the code in >>> categorize_decl_for_section(varasm.cc), forces it to allocate in .sdata. >>> /* If the target uses small data sections, select it. */ >>> else if (targetm.in_small_data_p (decl)) >>> { >>> if (ret == SECCAT_BSS) >>> ret = SECCAT_SBSS; >>> else if targetm.have_srodata_section && ret == SECCAT_RODATA) >>> ret = SECCAT_SRODATA; >>> else >>> ret = SECCAT_SDATA; >>> } >> I'd just skip the test for 32bit ppc. There should be suitable effective-target >> tests you can use. >> >> jeff