From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 72FC8385455E for ; Thu, 24 Nov 2022 10:53:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 72FC8385455E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669287227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=opVD+drda+0FPxI4C40/bndlDMidOKy7T1/qmolFx30=; b=MdsQQPa605BJj5JVwjdhhd37v7wpmSMgblJO6cLVWgBBpjjf2Y07Z7Qjh9w+1DeRT1htyG 63FbD8fR2SQ3GKEWS17eyJomNbLm9DgSua5Xs2vHGU6HbDJ+rJ9FpuEQ5wI76bGGfLqB7b tUkpikv6ZqMEdCqZc8XG1FpZfpj2tcA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-643-KEpW5GwAMr2VL0dhjMkRwg-1; Thu, 24 Nov 2022 05:53:46 -0500 X-MC-Unique: KEpW5GwAMr2VL0dhjMkRwg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 45CE2101A5BB; Thu, 24 Nov 2022 10:53:46 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 859E5111E3F8; Thu, 24 Nov 2022 10:53:45 +0000 (UTC) From: Florian Weimer To: Jakub Jelinek Cc: Joseph Myers , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] c: Propagate erroneous types to declaration specifiers [PR107805] References: <87cz9fqixe.fsf@oldenburg.str.redhat.com> <5350a633-56bb-cb4e-5e93-e6dce4b92a1@codesourcery.com> <87pmdc658b.fsf@oldenburg.str.redhat.com> Date: Thu, 24 Nov 2022 11:53:41 +0100 In-Reply-To: (Jakub Jelinek's message of "Thu, 24 Nov 2022 11:28:41 +0100") Message-ID: <87leo062tm.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Jakub Jelinek: > On Thu, Nov 24, 2022 at 11:01:40AM +0100, Florian Weimer via Gcc-patches wrote: >> * Joseph Myers: >> >> > On Tue, 22 Nov 2022, Florian Weimer via Gcc-patches wrote: >> > >> >> Without this change, finish_declspecs cannot tell that whether there >> >> was an erroneous type specified, or no type at all. This may result >> >> in additional diagnostics for implicit ints, or missing diagnostics >> >> for multiple types. >> >> >> >> PR c/107805 >> >> >> >> gcc/c/ >> >> * c-decl.cc (declspecs_add_type): Propagate error_mark_bode >> >> from type to specs. >> >> >> >> gcc/testsuite/ >> >> * gcc.dg/pr107805-1.c: New test. >> >> * gcc.dg/pr107805-1.c: Likewise. >> > >> > OK. >> >> Thanks. Permission to backport this to GCC 12 after a week or two? > > In this case I'd wait a month, it will take some time until possible > error recovery bugs are discovered. Okay, I have made a note to backport it in the new year. Hopefully any regressions will be flagged on the PR or linked to it. Thanks, Florian