From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id A32B23848034 for ; Wed, 21 Jul 2021 22:06:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A32B23848034 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: O5lW7RsRNuPySbbtHYCEJrsOhy/EVraue6bB85M7XKaKLC/W9LT/U63+5MQAzYx8+Uwes5lOTW 33GVEVkN/WZ2qNV+WrGYPKcEpMRL5acEWclC2atM6FQUf2Jkv89Yqs1Ltt+uE/W7T7cxcG4XEg BJG1CHNih2sm4OHnVqZZLtjIcsWGX3K1RNGih//GMGmrUqj4tJtTwl92OKr26eOUGzGCQNhvDT TLN2hSYZ0w1p2EKD1jt4jY776ac8jlVo/9KwfYfgiF9+eAsCl/Z74Y+FPdr6edCDn0yjAOzxGr fmT4GA07JvLSswKlMbw1kSKw X-IronPort-AV: E=Sophos;i="5.84,258,1620720000"; d="scan'208,223";a="63788891" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 21 Jul 2021 14:06:17 -0800 IronPort-SDR: CElD4nXY8LtRXoxBgN2fzdKTdl9gj3NHEYS2UTAdf/fWLSHuovnJe6OqEa0kbjApTQq71eUwrN 0f7QdVr1oSxwwr/KZ24Er1Lag6UwRtPZDmu/vjzIN8xVVlpYTX10OqJ/ytqKSoGgphnTSLUU0O XPZhq4RW5UOnmtnIBmswWNW+KciaMXIW0XXnAlPdS/y0k8uJPaf3mIFR5Nwovs0UuD2HFOBPaY 5y7bnr7kl5eCbAnfZyHXYlD7j8BLj6iLKMuS2jyiAZoLYUsmbBAVUbdnWNkmijyjMcdjJxrIu3 bM4= From: Thomas Schwinge To: Subject: Re: [openacc] tile, independent, default, private and firstprivate support in c/++ In-Reply-To: <563C0C29.6040209@codesourcery.com> References: <5639325B.90006@codesourcery.com> <87k2pwzlqa.fsf@kepler.schwinge.homeip.net> <563B6C1E.8070408@codesourcery.com> <87twp02xdr.fsf@schwinge.name> <563B8E1E.1020400@codesourcery.com> <563C0C29.6040209@codesourcery.com> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Thu, 22 Jul 2021 00:06:05 +0200 Message-ID: <87lf5ziape.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-09.mgc.mentorg.com (139.181.222.9) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jul 2021 22:06:19 -0000 --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi! Half a decade later... ;-) On 2015-11-05T18:10:49-0800, Cesar Philippidis wro= te: > I've applied this patch to trunk. > [...] > --- /dev/null > +++ b/gcc/testsuite/g++.dg/goacc/template.C > @@ -0,0 +1,141 @@ > +[...] > +#pragma acc atomic capture > + c =3D b++; > + > +#pragma atomic update > + c++; > + > +#pragma acc atomic read > + b =3D a; > + > +#pragma acc atomic write > + b =3D a; > +[...] Pushed "[OpenACC] Fix '#pragma atomic update' typo in 'g++.dg/goacc/template.C'" to master branch in commit 6099b9cc8ce70d2ec7f2fc9f71da95fbb66d335f, see attached. (Did I suggest to enable '-Wunknown-pragmas' for '-fopenacc'/'-fopenmp*', or if that's not permissible, then at least do it in the relevant testsuite '*.exp' files?) Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --=-=-= Content-Type: text/x-diff; charset="utf-8" Content-Disposition: inline; filename="0001-OpenACC-Fix-pragma-atomic-update-typo-in-g-.dg-goacc.patch" Content-Transfer-Encoding: quoted-printable >From 6099b9cc8ce70d2ec7f2fc9f71da95fbb66d335f Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Wed, 21 Jul 2021 08:20:18 +0200 Subject: [PATCH] [OpenACC] Fix '#pragma atomic update' typo in 'g++.dg/goacc/template.C' MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit [...]/g++.dg/goacc/template.C:58: warning: ignoring =E2=80=98#pragma at= omic update=E2=80=99 [-Wunknown-pragmas] 58 | #pragma atomic update | Small fix-up for r229832 (commit 7a5e4956cc026cba54159d5c764486ac4151db85) "[openacc] tile, independent, default, private and firstprivate support in c/++". gcc/testsuite/ * g++.dg/goacc/template.C: Fix '#pragma atomic update' typo. --- gcc/testsuite/g++.dg/goacc/template.C | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/g++.dg/goacc/template.C b/gcc/testsuite/g++.dg/g= oacc/template.C index 8bcd2a1ce43..51a3f54e43f 100644 --- a/gcc/testsuite/g++.dg/goacc/template.C +++ b/gcc/testsuite/g++.dg/goacc/template.C @@ -55,7 +55,7 @@ oacc_parallel_copy (T a) #pragma acc atomic capture c =3D b++; =20 -#pragma atomic update +#pragma acc atomic update c++; =20 #pragma acc atomic read --=20 2.30.2 --=-=-=--